From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7613BEB64D9 for ; Fri, 7 Jul 2023 07:16:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 55E49861E6; Fri, 7 Jul 2023 09:16:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="WQuge1Nl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EA0F086386; Fri, 7 Jul 2023 09:16:19 +0200 (CEST) Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CC99C861C5 for ; Fri, 7 Jul 2023 09:16:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1b8c364ad3bso2627985ad.1 for ; Fri, 07 Jul 2023 00:16:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688714175; x=1691306175; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=nKaZA6EF+dtGcstKQIICfsOwfHPA0pl/BE/8fkJcI0s=; b=WQuge1NlkA3xVvY032WwDoXIAyJikYUEiNsvEVn8LIl8twYLYxzlaDySE8TG1bw13I sF+yelIZSzBem1P1o/iwGpC5y5CQEmkhB0CzBkLN7+84Iw89ukfifSET4orOop8d0Al3 CgccNhKTmPEOaexoTu3wd6+DGFYFmIdkhyfy8CnlRBbBKY4eIHpCk02vYSyTh7iYbfyC UUQvc8Ug2wBgwY1nw2Gthb4wvYGHX2hTE06KH8gpIWCngsqgLa0vaLgEZCIVNuP8m5tO vvbjRJdCsoItM8746y2Cu/cJ6WdqxqqgmibeYZmkUt0GQo9YAwbWrs+QEuk7pFhW/xsH lolg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688714175; x=1691306175; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nKaZA6EF+dtGcstKQIICfsOwfHPA0pl/BE/8fkJcI0s=; b=Gk8SVdh1BswpAlkK2a+xRhbmXJqAqtun1Lqgd1gfKw7slvNReoEU9obZhY+x/z50vt 1oQ9WGhZZbO7a8XWvuIaBBOBB+RDndtl6oW+xpRjF3je9q5YIbldutggABCfzC9uTHhU kzsL4h1u3Rik2ED2WyOGTMhlSMQgTKV0cf020F4U00FHIZmRfJZyA4xMKXFf4n7eryma cumvknBqZmYxUdvc4Gs8Nu3jOs0hhVcmkCGZ1j66gBBSnNy893GSJ8dvPnJRUFGvBtDU TKSBjlH4BMfDHTRqOCOwKagB4uwL6WUI7RIXvIRybQubJHSUWZwiSK4wtRfngPzV6ETk uGNw== X-Gm-Message-State: ABy/qLbUz4TW5KP/Y9EyzPfxQUYhqAI/LNat1bqbo67wFQL448EA9gu5 giDv0uZJtTmEDprvzGpdLT5E4w== X-Google-Smtp-Source: APBJJlEL6m/TIhiq8akJz04KLYEv8j2MTNouNueOdoDd2Zo8HfioVIFhiDqM2LGwh7RsDBpXfwv9ZQ== X-Received: by 2002:a17:902:f683:b0:1b1:9272:55e2 with SMTP id l3-20020a170902f68300b001b1927255e2mr5337343plg.3.1688714174992; Fri, 07 Jul 2023 00:16:14 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:183b:6d83:5ded:d465]) by smtp.gmail.com with ESMTPSA id jb14-20020a170903258e00b001b39ffff838sm2538545plb.25.2023.07.07.00.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 00:16:14 -0700 (PDT) Date: Fri, 7 Jul 2023 16:16:11 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: Masahisa Kojima , Ilias Apalodimas , u-boot@lists.denx.de, Simon Glass Subject: Re: [PATCH 0/4] introduce EFI_RAM_DISK_PROTOCOL Message-ID: Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , Masahisa Kojima , Ilias Apalodimas , u-boot@lists.denx.de, Simon Glass References: <20230707040045.485790-1-masahisa.kojima@linaro.org> <3bab3fdc-23d1-85fd-5cc8-7ed9c77097a4@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3bab3fdc-23d1-85fd-5cc8-7ed9c77097a4@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, Jul 07, 2023 at 08:29:12AM +0200, Heinrich Schuchardt wrote: > On 7/7/23 06:00, Masahisa Kojima wrote: > > This series introduces the EFI_RAM_DISK_PROTOCOL implementation. > > The major purpose of this series is a preparation for EFI HTTP(S) boot. > > > > Now U-Boot can download the distro installer ISO image > > via wget or tftpboot commands, but U-Boot can not mount > > the downloaded ISO image. > > By calling EFI_RAM_DISK_PROTOCOL->register API, user can > > mount the ISO image and boot the distro installer. > > If I understand you correctly, with your design RAM disks will only > exist in the EFI sub-system. Probably, not. As Kojima-san's "dm tree" shows, there is a U-Boot block device (and associated partition devices) thanks to your efi_driver framework. > We strive to synchronize what is happening on the driver model level and > on the UEFI level. I would prefer a design where we have a UCLASS_BLK > driver ram disks and the EFI_RAM_DISK_PROTOCOL is a one method of > managing ram disk devices. That said, I agree to starting with U-Boot block device implementation, UEFI_DISK comes automatically. It benefits both U-Boot proper and UEFI subsystem equally as well. (That is also what I meant to say in my first response.) > A big issue we have is RAM management. malloc() can only assign limited > amount of memory which is probably too small for the RAM disk you are > looking at. We manage page sized memory in the EFI sub-system but this > is not integrated with the LMB memory checks. Not sure, is it enough simply to add some restrictions on the start size and the size when a memory region is specified for a raw disk? -Takahiro Akashi > The necessary sequence of development is probably: > > * Rework memory management > * Implement ramdisks as UCLASS_BLK driver > * Implement the EFI_RAM_DISK_PROTOCOL based on the UCLASS_BLK driver. > > Best regards > > Heinrich > > > > > Note that the installation process may not proceed > > after the distro installer calls ExitBootServices() > > since there is no hand-off process for the block device of > > memory mapped ISO image. > > > > The EFI_RAM_DISK_PROTOCOL was tested with the > > debian network installer[1] on qemu_arm64 platform. > > The example procedure is as follows. > > => tftpboot 41000000 mini.iso > > => efidebug disk load 41000000 $filesize > > > > After these commands, ISO image is mounted like: > > > > => efidebug dh > > > > 000000007eec5910 (efiblk#0) > > /RamDisk(0x41000000,4974afff,3d5abd30-4175-87ce-6d64-d2ade523c4bb,0x0) > > Block IO > > > > 000000007eec6140 (efiblk#0:1) > > /RamDisk(0x41000000,4974afff,3d5abd30-4175-87ce-6d64-d2ade523c4bb,0x0)/HD(1,0x01,0,0x0,0x33800) > > Block IO > > > > 000000007eec62b0 (efiblk#0:2) > > /RamDisk(0x41000000,4974afff,3d5abd30-4175-87ce-6d64-d2ade523c4bb,0x0)/HD(2,0x01,0,0x33800,0x10000) > > Block IO > > System Partition > > Simple File System > > > > => dm tree > > > > blk 0 [ + ] efi_blk `-- efiblk#0 > > partition 0 [ + ] blk_partition |-- efiblk#0:1 > > partition 1 [ + ] blk_partition `-- efiblk#0:2 > > > > Debian can be successfully installed with this RAM disk on QEMU. > > > > [TODO] > > - udevices created in ./lib/efi_driver/efi_block_device.c::efi_bl_bind() > > are not removed when the efi_handle is removed. > > So after unload the RAM disk, udevices still exist. > > I plan to add a udevice removal process in ./lib/efi_driver/efi_uclass.c::efi_uc_stop(). > > In addition, I also plan to add unbind() callback in struct efi_driver_ops. > > > > > > [1] https://deb.debian.org/debian/dists/bookworm/main/installer-arm64/current/images/netboot/mini.iso > > > > Masahisa Kojima (4): > > efi_loader: add RAM disk device path > > efi_loader: add EFI_RAM_DISK_PROTOCOL implementation > > cmd: efidebug: add RAM disk mount command > > efi_selftest: add EFI_RAM_DISK_PROTOCOL selftest > > > > cmd/efidebug.c | 117 ++++++ > > include/efi_api.h | 32 ++ > > include/efi_loader.h | 4 + > > lib/efi_driver/efi_uclass.c | 7 +- > > lib/efi_loader/Kconfig | 6 + > > lib/efi_loader/Makefile | 1 + > > lib/efi_loader/efi_device_path_to_text.c | 14 + > > lib/efi_loader/efi_ram_disk.c | 334 +++++++++++++++ > > lib/efi_loader/efi_setup.c | 6 + > > lib/efi_selftest/Makefile | 1 + > > lib/efi_selftest/efi_selftest_ram_disk.c | 511 +++++++++++++++++++++++ > > lib/uuid.c | 4 + > > 12 files changed, 1035 insertions(+), 2 deletions(-) > > create mode 100644 lib/efi_loader/efi_ram_disk.c > > create mode 100644 lib/efi_selftest/efi_selftest_ram_disk.c > > > > > > base-commit: e2e2aea5733f0d23cd9593bbefe5c803c552dcb9 >