From: Leo Liang <ycliang@andestech.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: "Tom Rini" <trini@konsulko.com>, "Simon Glass" <sjg@chromium.org>,
"Marek Vasut" <marex@denx.de>,
"Mayuresh Chitale" <mchitale@ventanamicro.com>,
"Pali Rohár" <pali@kernel.org>, "Peng Fan" <peng.fan@nxp.com>,
"Nikita Shubin" <n.shubin@yadro.com>,
"Roger Quadros" <rogerq@kernel.org>, "Stefan Roese" <sr@denx.de>,
"Michal Simek" <michal.simek@amd.com>,
"Mark Kettenis" <kettenis@openbsd.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH] spl: CONFIG_SPL_PCI_PNP should depend on CONFIG_SPL_PCI
Date: Mon, 24 Jul 2023 07:51:05 +0000 [thread overview]
Message-ID: <ZL4taayaTitjKKvD@ubuntu01> (raw)
In-Reply-To: <20230724070310.23790-1-heinrich.schuchardt@canonical.com>
On Mon, Jul 24, 2023 at 09:03:10AM +0200, Heinrich Schuchardt wrote:
> CONFIG_SPL_PCI_PNP=y without CONFIG_SPL_PCI=y makes no sense.
>
> Move CONFIG_SPL_PCI_PNP to the SPL menu and add the missing dependency.
>
> Fixes: 32f5e9e5c1a7 ("nvme: pci: Enable for SPL")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> common/spl/Kconfig | 12 ++++++++++++
> drivers/pci/Kconfig | 11 -----------
> 2 files changed, 12 insertions(+), 11 deletions(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
next prev parent reply other threads:[~2023-07-24 7:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 7:03 [PATCH] spl: CONFIG_SPL_PCI_PNP should depend on CONFIG_SPL_PCI Heinrich Schuchardt
2023-07-24 7:51 ` Leo Liang [this message]
2023-07-24 14:53 ` Simon Glass
2023-07-24 15:14 ` Tom Rini
2023-07-24 17:46 ` Heinrich Schuchardt
2023-07-24 17:52 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL4taayaTitjKKvD@ubuntu01 \
--to=ycliang@andestech.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=kettenis@openbsd.org \
--cc=marex@denx.de \
--cc=mchitale@ventanamicro.com \
--cc=michal.simek@amd.com \
--cc=n.shubin@yadro.com \
--cc=pali@kernel.org \
--cc=peng.fan@nxp.com \
--cc=rogerq@kernel.org \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox