From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0846C0015E for ; Mon, 24 Jul 2023 07:51:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0AC5A866DA; Mon, 24 Jul 2023 09:51:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 40EEA8675D; Mon, 24 Jul 2023 09:51:55 +0200 (CEST) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EFF3C8666F for ; Mon, 24 Jul 2023 09:51:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 36O7pET3050271; Mon, 24 Jul 2023 15:51:14 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from ubuntu01 (10.0.12.75) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Mon, 24 Jul 2023 15:51:13 +0800 Date: Mon, 24 Jul 2023 07:51:05 +0000 From: Leo Liang To: Heinrich Schuchardt CC: Tom Rini , Simon Glass , Marek Vasut , Mayuresh Chitale , Pali =?utf-8?B?Um9ow6Fy?= , Peng Fan , "Nikita Shubin" , Roger Quadros , Stefan Roese , Michal Simek , Mark Kettenis , Subject: Re: [PATCH] spl: CONFIG_SPL_PCI_PNP should depend on CONFIG_SPL_PCI Message-ID: References: <20230724070310.23790-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230724070310.23790-1-heinrich.schuchardt@canonical.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Originating-IP: [10.0.12.75] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 36O7pET3050271 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Mon, Jul 24, 2023 at 09:03:10AM +0200, Heinrich Schuchardt wrote: > CONFIG_SPL_PCI_PNP=y without CONFIG_SPL_PCI=y makes no sense. > > Move CONFIG_SPL_PCI_PNP to the SPL menu and add the missing dependency. > > Fixes: 32f5e9e5c1a7 ("nvme: pci: Enable for SPL") > Signed-off-by: Heinrich Schuchardt > --- > common/spl/Kconfig | 12 ++++++++++++ > drivers/pci/Kconfig | 11 ----------- > 2 files changed, 12 insertions(+), 11 deletions(-) Reviewed-by: Leo Yu-Chi Liang