public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] clk: scmi: claim the dependency on CONFIG_CLK
@ 2023-06-12  1:14 AKASHI Takahiro
  2023-07-14  0:52 ` Reminder, " AKASHI Takahiro
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: AKASHI Takahiro @ 2023-06-12  1:14 UTC (permalink / raw)
  To: lukma, seanga2; +Cc: etienne.carriere, u-boot, AKASHI Takahiro

Without CONFIG_CLK, the build fails with the following message:
  LD      u-boot
aarch64-none-linux-gnu-ld.bfd: drivers/firmware/scmi/scmi_agent-uclass.o: \
			in function `scmi_bind_protocols':
.../drivers/firmware/scmi/scmi_agent-uclass.c:79: undefined reference to \
			`_u_boot_list_2_driver_2_scmi_clock'

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
 drivers/clk/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 3ad5af964f3f..29859cdfa158 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -160,6 +160,7 @@ config SANDBOX_CLK_CCF
 
 config CLK_SCMI
 	bool "Enable SCMI clock driver"
+	depends on CLK
 	depends on SCMI_FIRMWARE
 	help
 	  Enable this option if you want to support clock devices exposed
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Reminder, Re: [PATCH] clk: scmi: claim the dependency on CONFIG_CLK
  2023-06-12  1:14 [PATCH] clk: scmi: claim the dependency on CONFIG_CLK AKASHI Takahiro
@ 2023-07-14  0:52 ` AKASHI Takahiro
  2023-07-14  2:14 ` Sean Anderson
  2023-07-15 15:03 ` Tom Rini
  2 siblings, 0 replies; 4+ messages in thread
From: AKASHI Takahiro @ 2023-07-14  0:52 UTC (permalink / raw)
  To: lukma, seanga2; +Cc: etienne.carriere, u-boot

Hi Lukasz, Sean,

Can you review this patch, please?

-Takahiro Akashi

On Mon, Jun 12, 2023 at 10:14:49AM +0900, AKASHI Takahiro wrote:
> Without CONFIG_CLK, the build fails with the following message:
>   LD      u-boot
> aarch64-none-linux-gnu-ld.bfd: drivers/firmware/scmi/scmi_agent-uclass.o: \
> 			in function `scmi_bind_protocols':
> .../drivers/firmware/scmi/scmi_agent-uclass.c:79: undefined reference to \
> 			`_u_boot_list_2_driver_2_scmi_clock'
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  drivers/clk/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 3ad5af964f3f..29859cdfa158 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -160,6 +160,7 @@ config SANDBOX_CLK_CCF
>  
>  config CLK_SCMI
>  	bool "Enable SCMI clock driver"
> +	depends on CLK
>  	depends on SCMI_FIRMWARE
>  	help
>  	  Enable this option if you want to support clock devices exposed
> -- 
> 2.41.0
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: scmi: claim the dependency on CONFIG_CLK
  2023-06-12  1:14 [PATCH] clk: scmi: claim the dependency on CONFIG_CLK AKASHI Takahiro
  2023-07-14  0:52 ` Reminder, " AKASHI Takahiro
@ 2023-07-14  2:14 ` Sean Anderson
  2023-07-15 15:03 ` Tom Rini
  2 siblings, 0 replies; 4+ messages in thread
From: Sean Anderson @ 2023-07-14  2:14 UTC (permalink / raw)
  To: AKASHI Takahiro, lukma; +Cc: etienne.carriere, u-boot

On 6/11/23 21:14, AKASHI Takahiro wrote:
> Without CONFIG_CLK, the build fails with the following message:
>    LD      u-boot
> aarch64-none-linux-gnu-ld.bfd: drivers/firmware/scmi/scmi_agent-uclass.o: \
> 			in function `scmi_bind_protocols':
> .../drivers/firmware/scmi/scmi_agent-uclass.c:79: undefined reference to \
> 			`_u_boot_list_2_driver_2_scmi_clock'
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>   drivers/clk/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 3ad5af964f3f..29859cdfa158 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -160,6 +160,7 @@ config SANDBOX_CLK_CCF
>   
>   config CLK_SCMI
>   	bool "Enable SCMI clock driver"
> +	depends on CLK
>   	depends on SCMI_FIRMWARE
>   	help
>   	  Enable this option if you want to support clock devices exposed

Reviewed-by: Sean Anderson <seanga2@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: scmi: claim the dependency on CONFIG_CLK
  2023-06-12  1:14 [PATCH] clk: scmi: claim the dependency on CONFIG_CLK AKASHI Takahiro
  2023-07-14  0:52 ` Reminder, " AKASHI Takahiro
  2023-07-14  2:14 ` Sean Anderson
@ 2023-07-15 15:03 ` Tom Rini
  2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2023-07-15 15:03 UTC (permalink / raw)
  To: AKASHI Takahiro; +Cc: lukma, seanga2, etienne.carriere, u-boot

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

On Mon, Jun 12, 2023 at 10:14:49AM +0900, AKASHI Takahiro wrote:

> Without CONFIG_CLK, the build fails with the following message:
>   LD      u-boot
> aarch64-none-linux-gnu-ld.bfd: drivers/firmware/scmi/scmi_agent-uclass.o: \
> 			in function `scmi_bind_protocols':
> .../drivers/firmware/scmi/scmi_agent-uclass.c:79: undefined reference to \
> 			`_u_boot_list_2_driver_2_scmi_clock'
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Reviewed-by: Sean Anderson <seanga2@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-15 15:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-12  1:14 [PATCH] clk: scmi: claim the dependency on CONFIG_CLK AKASHI Takahiro
2023-07-14  0:52 ` Reminder, " AKASHI Takahiro
2023-07-14  2:14 ` Sean Anderson
2023-07-15 15:03 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox