From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Michal Simek <michal.simek@amd.com>
Cc: sughosh.ganu@linaro.org, Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
u-boot@lists.denx.de, git@xilinx.com
Subject: Re: [PATCH] efi_loader: Allow also empty capsule to be process
Date: Thu, 20 Jul 2023 14:49:09 +0900 [thread overview]
Message-ID: <ZLjK1TM5-lV_nZEj@laputa> (raw)
In-Reply-To: <9f2b578b-9e10-bf3a-2ce5-229f64b37fd3@amd.com>
Hi,
On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote:
>
>
> On 7/18/23 17:41, Heinrich Schuchardt wrote:
> > On 13.07.23 16:35, Michal Simek wrote:
> > > Empty capsule are also allowed to be process. Without it updated images
> > > can't change their Image Acceptance state from no to yes.
> >
> > Is there any documentation describing the usage of empty capsule to set
> > the image acceptance state?
>
> I actually don't know about documentation. I was talking to Ilias to make
> sure that documentation is up2date because there are missing couple of
> things there.
Sughosh should have more to say here about A/B update.
> I am testing A/B update and if you setup oemflags to 0x8000 then capsules
> are not automatically accepted and waiting for acceptance capsule to be
> passed.
> When I tested it I found out that they are not process that's why I created
> this patch.
The path you tried to modify is only executed by "efidebug capsule update"
or more specifically via the runtime service, UPDATE_CAPSULE.
But this API is NOT officially supported in the current capsule implementation
(at least, in my initial intention).
The only way to invoke capsule updates is to reboot the system.
If you want to test A/B update, please do the reboot.
-Takahiro Akashi
> But definitely someone should check that logic that the patch is
> right based on intention how these empty capsules should be used.
> I am actually not quite sure how revert capsules should be used and how to
> revert only certain image if you use multiple images in the same bank.
>
> Thanks,
> Michal
next prev parent reply other threads:[~2023-07-20 5:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 14:35 [PATCH] efi_loader: Allow also empty capsule to be process Michal Simek
2023-07-18 15:41 ` Heinrich Schuchardt
2023-07-19 6:28 ` Michal Simek
2023-07-20 5:49 ` AKASHI Takahiro [this message]
2023-07-20 6:07 ` Michal Simek
2023-07-20 6:36 ` Sughosh Ganu
2023-07-20 7:56 ` Michal Simek
2023-07-20 8:45 ` Sughosh Ganu
2023-07-20 9:26 ` Michal Simek
2023-07-20 9:48 ` Sughosh Ganu
2023-07-20 20:42 ` Heinrich Schuchardt
2023-07-21 4:48 ` AKASHI Takahiro
2023-07-26 13:07 ` Ilias Apalodimas
2023-07-26 16:36 ` Michal Simek
2023-07-27 0:46 ` AKASHI Takahiro
2023-07-26 12:54 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLjK1TM5-lV_nZEj@laputa \
--to=takahiro.akashi@linaro.org \
--cc=git@xilinx.com \
--cc=ilias.apalodimas@linaro.org \
--cc=michal.simek@amd.com \
--cc=sughosh.ganu@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox