From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35BC4EB64DD for ; Wed, 26 Jul 2023 03:12:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4FCCE8638E; Wed, 26 Jul 2023 05:12:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id CEAEB861C3; Wed, 26 Jul 2023 05:12:09 +0200 (CEST) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 100438638E for ; Wed, 26 Jul 2023 05:12:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 36Q3BsLu047726; Wed, 26 Jul 2023 11:11:54 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from ubuntu01 (10.0.12.75) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Wed, 26 Jul 2023 11:11:53 +0800 Date: Wed, 26 Jul 2023 03:11:53 +0000 From: Leo Liang To: Heinrich Schuchardt CC: Bin Meng , Rick Chen , , Simon Glass Subject: Re: [PATCH 1/1] acpi: Add missing RISC-V acpi_table header Message-ID: References: <20230725012310.7926-1-heinrich.schuchardt@canonical.com> <7f86bee0-90f1-d143-3519-f65f2ec68845@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7f86bee0-90f1-d143-3519-f65f2ec68845@canonical.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Originating-IP: [10.0.12.75] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 36Q3BsLu047726 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Tue, Jul 25, 2023 at 09:44:00AM +0200, Heinrich Schuchardt wrote: > On 7/25/23 04:26, Bin Meng wrote: > > +Simon, > > > > On Tue, Jul 25, 2023 at 9:30 AM Heinrich Schuchardt > > wrote: > > > > > > The pci_mmc.c driver can generate ACPI info and therefore includes > > > asm/acpi_table.h. This file does not exist for the RISC-V architecture > > > and thus code compilation fails when using this driver on RISC-V > > > > Which header file includes the in pci_mmc.c? > > > > I feel like we should fix the header file dependency of the driver, > > not by adding a dummy file for random architecture. > > The error is: > > In file included from include/acpi/acpigen.h:13, > from drivers/mmc/pci_mmc.c:15: > include/acpi/acpi_table.h:936:10: fatal error: asm/acpi_table.h: No such > file or directory > 936 | #include > | ^~~~~~~~~~~~~~~~~~ > > Currently we have: > > ./arch/x86/include/asm/acpi_table.h > ./arch/arm/include/asm/acpi_table.h > ./arch/sandbox/include/asm/acpi_table.h > > Only arch/x86/include/asm/acpi_table.h has content. > > The RISC-V architecture in general supports ACPI but has some requirements > that are different to x86. > > So I think we will end up with a arch/riscv/include/asm/acpi_table.h anyway > in the future. > LGTM! But could we also add something like what is in ./arch/sandbox/include/asm/acpi_table.h instead of just an empty file ? Best regards, Leo > Best regards > > Heinrich > > > > > > > > > Create an empty include file. > > > > > > Signed-off-by: Heinrich Schuchardt > > > --- > > > arch/riscv/include/asm/acpi_table.h | 0 > > > 1 file changed, 0 insertions(+), 0 deletions(-) > > > create mode 100644 arch/riscv/include/asm/acpi_table.h > > > > > > diff --git a/arch/riscv/include/asm/acpi_table.h b/arch/riscv/include/asm/acpi_table.h > > > new file mode 100644 > > > index 0000000000..e69de29bb2 > > > -- > > > > Regards, > > Bin