From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73764C0015E for ; Thu, 27 Jul 2023 09:59:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1F52D86795; Thu, 27 Jul 2023 11:59:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="JNQG2cCL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 64F88867D8; Thu, 27 Jul 2023 11:59:07 +0200 (CEST) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A15A186604 for ; Thu, 27 Jul 2023 11:59:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3fbc5d5746cso8077175e9.2 for ; Thu, 27 Jul 2023 02:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690451940; x=1691056740; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Jl3nsMiFF8extvu9KB/oj0BkZorsyMUGvc4YEQ3z26s=; b=JNQG2cCLt+rO0nZEmLzlbRpWbZovyJ1MSj/V5pgKtya3Gx/Mfu6qJMc34GU7zn7vzD 5d3nJeRdLZjH7XT51sQhBSZKtADP0VWKXLOLpRtUt5wHmoBhPVohHSol/lGOyCYsZtYX YSeT1U671b0WCyoBkp/GTTQhizDOFHbyC04MMZalntcSCEKevROtJW3kMMtZNy/fPpCQ w/vwKKQH+k5cZGWqjUv2xFGqh5xFHZRS9/JIJtNvwopMwie0VEgr6WD+QT8Os9kCH2PI kiBHb6WB94zV9B0ZWM6Ih8Dq8UlMgSyNva72Cy5EZVBA3RN4zYNUTxA6yAsWVeEdQxmV n4zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690451940; x=1691056740; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Jl3nsMiFF8extvu9KB/oj0BkZorsyMUGvc4YEQ3z26s=; b=kWLP+IQK92fnCd40dhD+RBCUx++dttiW6u89PcgpA9v+LdjSZK4Yo9XQTzNa30pRka pW2N6w0frqiZSLKMqxhWgcSnHJRQMip0fmnXpWAyfe2dI9yfCwY1d4M0TUe71dEPNQZ3 6IXYIUiDylfu0Kz02frhdNabFW9kwkvAsaRSjFie27eCB2ztc4x1mx89IN8pubL6h4M5 diyTLhGZZmZYLSuShLJsKhhET5hxecoHB4WLStcXEaxYIzgFgNSZjwPdKleU9sN1lNCP fQMsFGl3AQZDoYSOPxjMrQyCiUAMbjZ/+fbAkwk84JtsKor+a3A2hk3Y/GgxQRJ/uSnm +x1A== X-Gm-Message-State: ABy/qLbOgQKcJ0+/IXlYrmFznoUcuyPayXCQLl8Doil86byVIJB1NNM6 0SuJ+cTGhV1NbRpnYGXl3ufrcwvEgYsNJakeos8= X-Google-Smtp-Source: APBJJlEJigPb2MZs1CdR5Gpwyg5mEOjDOqXcn80D8jnCGsIQWB6hTWhK4Azf0kfFuwciyVxTeJokoQ== X-Received: by 2002:a05:600c:231a:b0:3fa:95c7:e891 with SMTP id 26-20020a05600c231a00b003fa95c7e891mr1250420wmo.35.1690451939914; Thu, 27 Jul 2023 02:58:59 -0700 (PDT) Received: from hades (ppp089210088142.access.hol.gr. [89.210.88.142]) by smtp.gmail.com with ESMTPSA id y19-20020a7bcd93000000b003fc06169ab3sm4243661wmj.20.2023.07.27.02.58.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 02:58:59 -0700 (PDT) Date: Thu, 27 Jul 2023 12:58:57 +0300 From: Ilias Apalodimas To: Abdellatif El Khlifi Cc: trini@konsulko.com, nd@arm.com, u-boot@lists.denx.de, Gowtham Suresh Kumar , Simon Glass , Jens Wiklander Subject: Re: [PATCH v16 09/10] arm_ffa: efi: introduce FF-A MM communication Message-ID: References: <20230725185246.GE3630934@bill-the-cat> <20230726094503.100497-1-abdellatif.elkhlifi@arm.com> <20230726094503.100497-10-abdellatif.elkhlifi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726094503.100497-10-abdellatif.elkhlifi@arm.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Wed, Jul 26, 2023 at 10:45:02AM +0100, Abdellatif El Khlifi wrote: > Add MM communication support using FF-A transport > > This feature allows accessing MM partitions services through > EFI MM communication protocol. MM partitions such as StandAlonneMM > or smm-gateway secure partitions which reside in secure world. > > An MM shared buffer and a door bell event are used to exchange > the data. > > The data is used by EFI services such as GetVariable()/SetVariable() > and copied from the communication buffer to the MM shared buffer. > > The secure partition is notified about availability of data in the > MM shared buffer by an FF-A message (door bell). > > On such event, MM SP can read the data and updates the MM shared > buffer with the response data. > > The response data is copied back to the communication buffer and > consumed by the EFI subsystem. > > MM communication protocol supports FF-A 64-bit direct messaging. > > Signed-off-by: Abdellatif El Khlifi > Tested-by: Gowtham Suresh Kumar Is there a public record of thise tested-by? If not please don't inject them like this or have Gowtham respond on the mailing list Thanks /Ilias > Reviewed-by: Simon Glass > Cc: Tom Rini > Cc: Ilias Apalodimas > Cc: Jens Wiklander > > --- > > Changelog: > =============== > > v16: > > * lib/efi_loader/Kconfig: > rather than automatically selecting OPTEE and ARM_FFA_TRANSPORT configs by > EFI_MM_COMM_TEE, set them as dependencies (Otherwise FF-A will be automatically > enabled for boards that don't need it). > > v15: > > Simon: > > * replace FFA_SHARED_MM_BUFFER_* defines with configs > > v14: > > Ilias: > > * drop truncating var_payload->size when using FF-A > * map the MM SP return codes to errnos > > v13: > > * remove FF-A and Optee ifdefs > > v12: > > * drop use of calloc when querying SPs > * address nits > > v11: > > * rename select_ffa_mm_comms() to select_mm_comms() > * improve the logic of MM transport selection in mm_communicate() > * addressing nits > > v10: > > * use the FF-A driver Uclass operations > * use uclass_first_device() > * addressing nits > > v9: align how FF-A is used with FF-A discovery through DM > > v8: > > * isolate the compilation choices between FF-A and OP-TEE > * update partition_info_get() second argument to be an SP count > * pass NULL device pointer to the FF-A bus discovery and operations > > v7: > > * set the MM door bell event to use 64-bit direct messaging > * issue a compile time error when one of these macros are not found : > FFA_SHARED_MM_BUFFER_SIZE, FFA_SHARED_MM_BUFFER_OFFSET, FFA_SHARED_MM_BUFFER_ADDR > * make mm_sp_svc_uuid static > * replace EINVAL with ENOMEM in ffa_discover_mm_sp_id() when calloc() fails > * improve use of unmap_sysmem() in ffa_mm_communicate() > > v6: > > * add FF-A runtime discovery at MM communication level > * drop EFI runtime support for FF-A MM communication > * revert the changes in include/mm_communication.h for > efi_mm_communicate_header and smm_variable_access structures > > v4: > > * use the new FF-A driver interfaces > * discover MM partitions at runtime > * copy FF-A driver private data to EFI runtime section at > ExitBootServices() > * drop use of FFA_ERR_STAT_SUCCESS error code > * replace EFI_BUFFER_TOO_SMALL with EFI_OUT_OF_RESOURCES > in ffa_mm_communicate(). No need for efi_memcpy_runtime() anymore > * revert the error log in mm_communicate() in case of failure > * remove packed attribute from efi_mm_communicate_header and > smm_variable_communicate_header > > v2: > > * set default values to 0 for FFA_SHARED_MM_BUFFER_SIZE, FFA_SHARED_MM_BUFFER_ADDR and MM_SP_UUID_DATA and add warnings > > v1: > > * introduce FF-A MM communication > > include/mm_communication.h | 13 ++ > lib/efi_loader/Kconfig | 44 ++++- > lib/efi_loader/efi_variable_tee.c | 257 +++++++++++++++++++++++++++++- > 3 files changed, 307 insertions(+), 7 deletions(-) > > diff --git a/include/mm_communication.h b/include/mm_communication.h > index e65fbde60d..f17847583b 100644 > --- a/include/mm_communication.h > +++ b/include/mm_communication.h > @@ -6,6 +6,9 @@ > * Copyright (c) 2017, Intel Corporation. All rights reserved. > * Copyright (C) 2020 Linaro Ltd. > * Copyright (C) 2020 Linaro Ltd. > + * Copyright 2022-2023 Arm Limited and/or its affiliates > + * Authors: > + * Abdellatif El Khlifi > */ > > #ifndef _MM_COMMUNICATION_H_ > @@ -13,6 +16,9 @@ > > #include > > +/* MM service UUID string (big-endian format). This UUID is common across all MM SPs */ > +#define MM_SP_UUID "33d532ed-e699-0942-c09c-a798d9cd722d" > + > /* > * Interface to the pseudo Trusted Application (TA), which provides a > * communication channel with the Standalone MM (Management Mode) > @@ -248,4 +254,11 @@ struct smm_variable_var_check_property { > u16 name[]; > }; > > +/* supported MM transports */ > +enum mm_comms_select { > + MM_COMMS_UNDEFINED, > + MM_COMMS_FFA, > + MM_COMMS_OPTEE > +}; > + > #endif /* _MM_COMMUNICATION_H_ */ > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > index c5835e6ef6..8fbadb9201 100644 > --- a/lib/efi_loader/Kconfig > +++ b/lib/efi_loader/Kconfig > @@ -55,13 +55,53 @@ config EFI_VARIABLE_FILE_STORE > stored as file /ubootefi.var on the EFI system partition. > > config EFI_MM_COMM_TEE > - bool "UEFI variables storage service via OP-TEE" > - depends on OPTEE > + bool "UEFI variables storage service via the trusted world" > + depends on OPTEE && ARM_FFA_TRANSPORT > help > + Allowing access to the MM SP services (SPs such as StandAlonneMM, smm-gateway). > + When using the u-boot OP-TEE driver, StandAlonneMM is supported. > + When using the u-boot FF-A driver any MM SP is supported. > + > If OP-TEE is present and running StandAloneMM, dispatch all UEFI > variable related operations to that. The application will verify, > authenticate and store the variables on an RPMB. > > + When ARM_FFA_TRANSPORT is used, dispatch all UEFI variable related > + operations to the MM SP running in the secure world. > + A door bell mechanism is used to notify the SP when there is data in the shared > + MM buffer. The data is copied by u-boot to the shared buffer before issuing > + the door bell event. > + > +config FFA_SHARED_MM_BUF_SIZE > + int "Memory size of the shared MM communication buffer" > + default 0 > + depends on EFI_MM_COMM_TEE > + help > + This defines the size in bytes of the memory area reserved for the shared > + buffer used for communication between the MM feature in U-Boot and > + the MM SP in secure world. > + The size of the memory region must be a multiple of the size of the maximum > + translation granule size that is specified in the ID_AA64MMFR0_EL1 System register. > + It is assumed that the MM SP knows the size of the shared MM communication buffer. > + > +config FFA_SHARED_MM_BUF_OFFSET > + int "Data offset in the shared MM communication buffer" > + default 0 > + depends on EFI_MM_COMM_TEE > + help > + This defines the offset in bytes of the data read or written to in the shared > + buffer by the MM SP. > + > +config FFA_SHARED_MM_BUF_ADDR > + hex "Define the address of the shared MM communication buffer" > + default 0x0 > + depends on EFI_MM_COMM_TEE > + help > + This defines the address of the shared MM communication buffer > + used for communication between the MM feature in U-Boot and > + the MM SP in secure world. > + It is assumed that the MM SP knows the address of the shared MM communication buffer. > + > config EFI_VARIABLE_NO_STORE > bool "Don't persist non-volatile UEFI variables" > help > diff --git a/lib/efi_loader/efi_variable_tee.c b/lib/efi_loader/efi_variable_tee.c > index dfef18435d..5137b871ea 100644 > --- a/lib/efi_loader/efi_variable_tee.c > +++ b/lib/efi_loader/efi_variable_tee.c > @@ -4,17 +4,34 @@ > * > * Copyright (C) 2019 Linaro Ltd. > * Copyright (C) 2019 Linaro Ltd. > + * Copyright 2022-2023 Arm Limited and/or its affiliates > + * > + * Authors: > + * Abdellatif El Khlifi > */ > > #include > +#include > +#include > +#include > #include > #include > #include > #include > -#include > #include > +#include > #include > +#include > + > +/* MM return codes */ > +#define MM_SUCCESS (0) > +#define MM_NOT_SUPPORTED (-1) > +#define MM_INVALID_PARAMETER (-2) > +#define MM_DENIED (-3) > +#define MM_NO_MEMORY (-5) > > +static const char *mm_sp_svc_uuid = MM_SP_UUID; > +static u16 mm_sp_id; > extern struct efi_var_file __efi_runtime_data *efi_var_buf; > static efi_uintn_t max_buffer_size; /* comm + var + func + data */ > static efi_uintn_t max_payload_size; /* func + data */ > @@ -145,16 +162,241 @@ static efi_status_t optee_mm_communicate(void *comm_buf, ulong dsize) > } > > /** > - * mm_communicate() - Adjust the cmonnucation buffer to StandAlonneMM and send > + * ffa_notify_mm_sp() - Announce there is data in the shared buffer > + * > + * Notify the MM partition in the trusted world that > + * data is available in the shared buffer. > + * This is a blocking call during which trusted world has exclusive access > + * to the MM shared buffer. > + * > + * Return: > + * > + * 0 on success > + */ > +static int ffa_notify_mm_sp(void) > +{ > + struct ffa_send_direct_data msg = {0}; > + int ret; > + int sp_event_ret; > + struct udevice *dev; > + > + ret = uclass_first_device_err(UCLASS_FFA, &dev); > + if (ret) { > + log_err("EFI: Cannot find FF-A bus device, notify MM SP failure\n"); > + return ret; > + } > + > + msg.data0 = CONFIG_FFA_SHARED_MM_BUF_OFFSET; /* x3 */ > + > + ret = ffa_sync_send_receive(dev, mm_sp_id, &msg, 1); > + if (ret) > + return ret; > + > + sp_event_ret = msg.data0; /* x3 */ > + > + switch (sp_event_ret) { > + case MM_SUCCESS: > + ret = 0; > + break; > + case MM_NOT_SUPPORTED: > + ret = -EINVAL; > + break; > + case MM_INVALID_PARAMETER: > + ret = -EPERM; > + break; > + case MM_DENIED: > + ret = -EACCES; > + break; > + case MM_NO_MEMORY: > + ret = -EBUSY; > + break; > + default: > + ret = -EACCES; > + } > + > + return ret; > +} > + > +/** > + * ffa_discover_mm_sp_id() - Query the MM partition ID > + * > + * Use the FF-A driver to get the MM partition ID. > + * If multiple partitions are found, use the first one. > + * This is a boot time function. > + * > + * Return: > + * > + * 0 on success > + */ > +static int ffa_discover_mm_sp_id(void) > +{ > + u32 count = 0; > + int ret; > + struct ffa_partition_desc *descs; > + struct udevice *dev; > + > + ret = uclass_first_device_err(UCLASS_FFA, &dev); > + if (ret) { > + log_err("EFI: Cannot find FF-A bus device, MM SP discovery failure\n"); > + return ret; > + } > + > + /* Ask the driver to fill the buffer with the SPs info */ > + ret = ffa_partition_info_get(dev, mm_sp_svc_uuid, &count, &descs); > + if (ret) { > + log_err("EFI: Failure in querying SPs info (%d), MM SP discovery failure\n", ret); > + return ret; > + } > + > + /* MM SPs found , use the first one */ > + > + mm_sp_id = descs[0].info.id; > + > + log_info("EFI: MM partition ID 0x%x\n", mm_sp_id); > + > + return 0; > +} > + > +/** > + * ffa_mm_communicate() - Exchange EFI services data with the MM partition using FF-A > + * @comm_buf: locally allocated communication buffer used for rx/tx > + * @dsize: communication buffer size > + * > + * Issue a door bell event to notify the MM partition (SP) running in OP-TEE > + * that there is data to read from the shared buffer. > + * Communication with the MM SP is performed using FF-A transport. > + * On the event, MM SP can read the data from the buffer and > + * update the MM shared buffer with response data. > + * The response data is copied back to the communication buffer. > + * > + * Return: > + * > + * EFI status code > + */ > +static efi_status_t ffa_mm_communicate(void *comm_buf, ulong comm_buf_size) > +{ > + ulong tx_data_size; > + int ffa_ret; > + efi_status_t efi_ret; > + struct efi_mm_communicate_header *mm_hdr; > + void *virt_shared_buf; > + > + if (!comm_buf) > + return EFI_INVALID_PARAMETER; > + > + /* Discover MM partition ID at boot time */ > + if (!mm_sp_id && ffa_discover_mm_sp_id()) { > + log_err("EFI: Failure to discover MM SP ID at boot time, FF-A MM comms failure\n"); > + return EFI_UNSUPPORTED; > + } > + > + mm_hdr = (struct efi_mm_communicate_header *)comm_buf; > + tx_data_size = mm_hdr->message_len + sizeof(efi_guid_t) + sizeof(size_t); > + > + if (comm_buf_size != tx_data_size || tx_data_size > CONFIG_FFA_SHARED_MM_BUF_SIZE) > + return EFI_INVALID_PARAMETER; > + > + /* Copy the data to the shared buffer */ > + > + virt_shared_buf = map_sysmem((phys_addr_t)CONFIG_FFA_SHARED_MM_BUF_ADDR, 0); > + memcpy(virt_shared_buf, comm_buf, tx_data_size); > + > + /* > + * The secure world might have cache disabled for > + * the device region used for shared buffer (which is the case for Optee). > + * In this case, the secure world reads the data from DRAM. > + * Let's flush the cache so the DRAM is updated with the latest data. > + */ > +#ifdef CONFIG_ARM64 > + invalidate_dcache_all(); > +#endif > + > + /* Announce there is data in the shared buffer */ > + > + ffa_ret = ffa_notify_mm_sp(); > + > + switch (ffa_ret) { > + case 0: { > + ulong rx_data_size; > + /* Copy the MM SP response from the shared buffer to the communication buffer */ > + rx_data_size = ((struct efi_mm_communicate_header *)virt_shared_buf)->message_len + > + sizeof(efi_guid_t) + > + sizeof(size_t); > + > + if (rx_data_size > comm_buf_size) { > + efi_ret = EFI_OUT_OF_RESOURCES; > + break; > + } > + > + memcpy(comm_buf, virt_shared_buf, rx_data_size); > + efi_ret = EFI_SUCCESS; > + break; > + } > + case -EINVAL: > + efi_ret = EFI_DEVICE_ERROR; > + break; > + case -EPERM: > + efi_ret = EFI_INVALID_PARAMETER; > + break; > + case -EACCES: > + efi_ret = EFI_ACCESS_DENIED; > + break; > + case -EBUSY: > + efi_ret = EFI_OUT_OF_RESOURCES; > + break; > + default: > + efi_ret = EFI_ACCESS_DENIED; > + } > + > + unmap_sysmem(virt_shared_buf); > + return efi_ret; > +} > + > +/** > + * get_mm_comms() - detect the available MM transport > + * > + * Make sure the FF-A bus is probed successfully > + * which means FF-A communication with secure world works and ready > + * for use. > + * > + * If FF-A bus is not ready, use OPTEE comms. > + * > + * Return: > + * > + * MM_COMMS_FFA or MM_COMMS_OPTEE > + */ > +static enum mm_comms_select get_mm_comms(void) > +{ > + struct udevice *dev; > + int ret; > + > + ret = uclass_first_device_err(UCLASS_FFA, &dev); > + if (ret) { > + log_err("EFI: Cannot find FF-A bus device, trying Optee comms\n"); > + return MM_COMMS_OPTEE; > + } > + > + return MM_COMMS_FFA; > +} > + > +/** > + * mm_communicate() - Adjust the communication buffer to the MM SP and send > * it to OP-TEE > * > - * @comm_buf: locally allocted communcation buffer > + * @comm_buf: locally allocated communication buffer > * @dsize: buffer size > + * > + * The SP (also called partition) can be any MM SP such as StandAlonneMM or smm-gateway. > + * The comm_buf format is the same for both partitions. > + * When using the u-boot OP-TEE driver, StandAlonneMM is supported. > + * When using the u-boot FF-A driver, any MM SP is supported. > + * > * Return: status code > */ > static efi_status_t mm_communicate(u8 *comm_buf, efi_uintn_t dsize) > { > efi_status_t ret; > + enum mm_comms_select mm_comms; > struct efi_mm_communicate_header *mm_hdr; > struct smm_variable_communicate_header *var_hdr; > > @@ -162,7 +404,12 @@ static efi_status_t mm_communicate(u8 *comm_buf, efi_uintn_t dsize) > mm_hdr = (struct efi_mm_communicate_header *)comm_buf; > var_hdr = (struct smm_variable_communicate_header *)mm_hdr->data; > > - ret = optee_mm_communicate(comm_buf, dsize); > + mm_comms = get_mm_comms(); > + if (mm_comms == MM_COMMS_FFA) > + ret = ffa_mm_communicate(comm_buf, dsize); > + else > + ret = optee_mm_communicate(comm_buf, dsize); > + > if (ret != EFI_SUCCESS) { > log_err("%s failed!\n", __func__); > return ret; > @@ -697,7 +944,7 @@ void efi_variables_boot_exit_notify(void) > ret = EFI_NOT_FOUND; > > if (ret != EFI_SUCCESS) > - log_err("Unable to notify StMM for ExitBootServices\n"); > + log_err("Unable to notify the MM partition for ExitBootServices\n"); > free(comm_buf); > > /* > -- > 2.25.1 >