From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Maxim Uvarov <maxim.uvarov@linaro.org>
Cc: u-boot@lists.denx.de, pbrobinson@redhat.com,
joe.hershberger@ni.com, rfried.dev@gmail.com, trini@konsulko.com,
goldsimon@gmx.de, lwip-devel@nongnu.org
Subject: Re: [PATCHv4 1/5] net/lwip: add lwip-external submodule
Date: Thu, 27 Jul 2023 15:34:48 +0300 [thread overview]
Message-ID: <ZMJkaKt8aueleo1y@hades> (raw)
In-Reply-To: <20230714142000.5534-2-maxim.uvarov@linaro.org>
Tom, Simon
are you ok with submodules on this one?
thanks
/Ilias
On Fri, Jul 14, 2023 at 08:19:56PM +0600, Maxim Uvarov wrote:
> This commit adds the lwip library as a git submodule. I think
> there has to be advantages to compile lwip inside U-boot,
> i.e. use the same compiler and flags as the main code.
> One of them is LTO and the other is to enable additional debug
> options for network protocol during development. Also we can
> copy lwip library code inside U-boot, but for now I don't want
> to send all lwip code to the mailing list. So it's git submodule.
>
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> ---
> .gitmodules | 3 +++
> lib/lwip/lwip-external | 1 +
> 2 files changed, 4 insertions(+)
> create mode 100644 .gitmodules
> create mode 160000 lib/lwip/lwip-external
>
> diff --git a/.gitmodules b/.gitmodules
> new file mode 100644
> index 0000000000..afc709af10
> --- /dev/null
> +++ b/.gitmodules
> @@ -0,0 +1,3 @@
> +[submodule "lib/lwip/lwip-external"]
> + path = lib/lwip/lwip-external
> + url = https://git.savannah.nongnu.org/git/lwip.git
> diff --git a/lib/lwip/lwip-external b/lib/lwip/lwip-external
> new file mode 160000
> index 0000000000..3fe8d2fc43
> --- /dev/null
> +++ b/lib/lwip/lwip-external
> @@ -0,0 +1 @@
> +Subproject commit 3fe8d2fc43a9b69f7ed28c63d44a7744f9c0def9
> --
> 2.30.2
>
next prev parent reply other threads:[~2023-07-27 12:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 14:19 [PATCHv4 0/5] net/lwip: add lwip library for the network stack Maxim Uvarov
2023-07-14 14:19 ` [PATCHv4 1/5] net/lwip: add lwip-external submodule Maxim Uvarov
2023-07-27 12:34 ` Ilias Apalodimas [this message]
2023-07-28 18:08 ` Tom Rini
2023-07-28 22:17 ` Simon Glass
2023-07-30 22:06 ` Peter Robinson
2023-08-02 8:03 ` Maxim Uvarov
2023-08-02 16:32 ` Tom Rini
2023-07-14 14:19 ` [PATCHv4 2/5] net/lwip: add lwip library for the network stack Maxim Uvarov
2023-07-27 13:29 ` Ilias Apalodimas
2023-07-27 14:23 ` Maxim Uvarov
2023-07-28 14:26 ` Maxim Uvarov
2023-07-14 14:19 ` [PATCHv4 3/5] net/lwip: add doc/develop/net_lwip.rst Maxim Uvarov
2023-07-27 12:33 ` Ilias Apalodimas
2023-07-14 14:19 ` [PATCHv4 4/5] net/lwip: add dns command Maxim Uvarov
2023-07-14 14:20 ` [PATCHv4 5/5] net/lwip: apps/http: add dns support Maxim Uvarov
2023-07-27 12:59 ` Ilias Apalodimas
2023-07-27 12:22 ` [PATCHv4 0/5] net/lwip: add lwip library for the network stack Ilias Apalodimas
2023-07-28 1:51 ` Simon Glass
2023-07-28 11:24 ` Maxim Uvarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMJkaKt8aueleo1y@hades \
--to=ilias.apalodimas@linaro.org \
--cc=goldsimon@gmx.de \
--cc=joe.hershberger@ni.com \
--cc=lwip-devel@nongnu.org \
--cc=maxim.uvarov@linaro.org \
--cc=pbrobinson@redhat.com \
--cc=rfried.dev@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox