From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C118C001E0 for ; Thu, 27 Jul 2023 12:35:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DDE8C86768; Thu, 27 Jul 2023 14:35:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="VvaOSSXt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ADA40867F7; Thu, 27 Jul 2023 14:34:54 +0200 (CEST) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 620A586768 for ; Thu, 27 Jul 2023 14:34:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fde57684d7so9034375e9.2 for ; Thu, 27 Jul 2023 05:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690461291; x=1691066091; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SIsPPfpRrGUgQzFFpICe4wc6CNt1ZBMmQL+CzLk0hew=; b=VvaOSSXtNQGs6sK8Nx4rqSS0gkjxOMlWZxxRvnB2NP0HFEC1IXqD2LWl3Sxq4kNOFf 1+j9/ePhsGm2Jr74noMISFIht6EOQIaQ8lg4yJ60es0h1a4h7yyHkX21jVdim2hIy7JJ oRC6koBZoYxte9RCFaagqsk5nmYz4kTppMhFn5x6fRNlN8gYnV2jzfTRCk3P5AqFKbP5 oxN8lryoKRGWGT7KQ/M2U3E0998MjIdmiF0ecB03YVK1+h5UYRcAwyGZGtH/bqmXkRr8 qrI+kZC1i8AFT188Sp7FnHm9sDLZ4DTD3IPjBtk1jLbM0KO/BeoSyyjf7Ej2lgDQp4fF 7nuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690461291; x=1691066091; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SIsPPfpRrGUgQzFFpICe4wc6CNt1ZBMmQL+CzLk0hew=; b=RBK7e5q3mxZFp44m8PejPDS/GFjpqy1caxwejw39EYTNvSb9K107rDn56Tm7sHpYVL UGZF69CflQld4UCve5feA/1W+cQuu0d8OJbLBRG+Qr3YMlQcvzZ8pK3bZm3qH0jm0gMg RkfId9vyHPd6uMTlltS2knmKj66F+xiAep86MSdJY8By2ncQWNUxlVHZtrnedZnUPNOg jsD1a5hfCb6HmYxsEvWUsiaEXbVzS1Pwcm1uHCReenUlQP2c6LrVzciZ4ilVhTvnlA/E yIM/TlOYwONJ9kZH38ItNpCRRn60oSLdOXuC2LZM/Cu15Wmmh3Mlk1t5CBD3cDEz1wJ1 nR0g== X-Gm-Message-State: ABy/qLYk4BKrhiBAJWhGEupflr71WDmdozHsqqVCJNwIOxgk5dg0RbN7 uhs8qkeVpa8s0LWLFnLNANC02A== X-Google-Smtp-Source: APBJJlFImyS0esvh3hUPN5mMbUwGa6is39Vp9Og/S8LYsEd5q0yRAx84wctdL/nHcUdFk2dJAk4/hw== X-Received: by 2002:adf:e586:0:b0:313:ee2e:dae1 with SMTP id l6-20020adfe586000000b00313ee2edae1mr1648610wrm.18.1690461290781; Thu, 27 Jul 2023 05:34:50 -0700 (PDT) Received: from hades (ppp089210088142.access.hol.gr. [89.210.88.142]) by smtp.gmail.com with ESMTPSA id a4-20020adfe5c4000000b00313fd294d6csm1993794wrn.7.2023.07.27.05.34.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 05:34:50 -0700 (PDT) Date: Thu, 27 Jul 2023 15:34:48 +0300 From: Ilias Apalodimas To: Maxim Uvarov Cc: u-boot@lists.denx.de, pbrobinson@redhat.com, joe.hershberger@ni.com, rfried.dev@gmail.com, trini@konsulko.com, goldsimon@gmx.de, lwip-devel@nongnu.org Subject: Re: [PATCHv4 1/5] net/lwip: add lwip-external submodule Message-ID: References: <20230714142000.5534-1-maxim.uvarov@linaro.org> <20230714142000.5534-2-maxim.uvarov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714142000.5534-2-maxim.uvarov@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Tom, Simon are you ok with submodules on this one? thanks /Ilias On Fri, Jul 14, 2023 at 08:19:56PM +0600, Maxim Uvarov wrote: > This commit adds the lwip library as a git submodule. I think > there has to be advantages to compile lwip inside U-boot, > i.e. use the same compiler and flags as the main code. > One of them is LTO and the other is to enable additional debug > options for network protocol during development. Also we can > copy lwip library code inside U-boot, but for now I don't want > to send all lwip code to the mailing list. So it's git submodule. > > Signed-off-by: Maxim Uvarov > --- > .gitmodules | 3 +++ > lib/lwip/lwip-external | 1 + > 2 files changed, 4 insertions(+) > create mode 100644 .gitmodules > create mode 160000 lib/lwip/lwip-external > > diff --git a/.gitmodules b/.gitmodules > new file mode 100644 > index 0000000000..afc709af10 > --- /dev/null > +++ b/.gitmodules > @@ -0,0 +1,3 @@ > +[submodule "lib/lwip/lwip-external"] > + path = lib/lwip/lwip-external > + url = https://git.savannah.nongnu.org/git/lwip.git > diff --git a/lib/lwip/lwip-external b/lib/lwip/lwip-external > new file mode 160000 > index 0000000000..3fe8d2fc43 > --- /dev/null > +++ b/lib/lwip/lwip-external > @@ -0,0 +1 @@ > +Subproject commit 3fe8d2fc43a9b69f7ed28c63d44a7744f9c0def9 > -- > 2.30.2 >