public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Simon Glass <sjg@chromium.org>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
	"Bin Meng" <bmeng.cn@gmail.com>, "Tom Rini" <trini@konsulko.com>,
	"Adam Ford" <aford173@gmail.com>,
	"Aiden Park" <aiden.park@intel.com>,
	"Aleksandar Gerasimovski"
	<aleksandar.gerasimovski@hitachienergy.com>,
	"Andrew Davis" <afd@ti.com>, "Anup Patel" <anup@brainfault.org>,
	"Aswath Govindraju" <a-govindraju@ti.com>,
	"Atish Patra" <atishp@atishpatra.org>,
	"Bryan Brattlof" <bb@ti.com>, "Dave Gerlach" <d-gerlach@ti.com>,
	"Derald D. Woods" <woods.technical@gmail.com>,
	"Heiko Schocher" <hs@denx.de>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Holger Brunck" <holger.brunck@hitachienergy.com>,
	"Jan Kiszka" <jan.kiszka@siemens.com>,
	"Joe Hershberger" <joe.hershberger@ni.com>,
	"Judith Mendez" <jm@ti.com>, "Le Jin" <le.jin@siemens.com>,
	"Manorit Chawdhry" <m-chawdhry@ti.com>,
	"Neha Malcom Francis" <n-francis@ti.com>,
	"Niel Fourie" <lusus@denx.de>, "Nikhil M Jain" <n-jain1@ti.com>,
	"Pali Rohár" <pali@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Parthiban Nallathambi" <parthiban@linumiz.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Philip Oberfichtner" <pro@denx.de>,
	"Rainer Boschung" <rainer.boschung@hitachienergy.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Wolfgang Denk" <wd@denx.de>
Subject: Re: [PATCH 00/22] x86: Move some boards to text environment
Date: Mon, 31 Jul 2023 11:09:16 +0300	[thread overview]
Message-ID: <ZMdsLDYAXYDVFqsY@smile.fi.intel.com> (raw)
In-Reply-To: <20230731030211.955875-1-sjg@chromium.org>

On Sun, Jul 30, 2023 at 09:01:43PM -0600, Simon Glass wrote:
> This series starts the process of moving x86 boards to a text environment.
> 
> This includes conversions for about half the boards.
> 
> The rest (including the more complicated Chromebooks) can come in a later
> series.

Patch wise it looks good to me
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> # Intel Edison

Where can I read about this new edison.env file and what is expected to be there?

>   doc: Explain how to avoid the distro-boot scripts
>   env: Use include/env for text-environment includes
>   env: Explain how to use #include files in text environment
>   x86: Drop CFG_SYS_STACK_SIZE
>   x86: i8254: Include required ibmpc.h header
>   x86: edison: Drop inclusion of ibmpc.h
>   x86: Drop inclusion of ibmpc.h
>   x86: Drop unused distro settings
>   x86: Add a common include for environment settings
>   x86: coreboot: Convert to text environment
>   x86: crownbay: Convert to text environment
>   x86: bayleybay: Convert to text environment
>   x86: galileo: Convert to text environment
>   x86: edison: Convert to text environment
>   x86: cherryhill: Convert to text environment
>   x86: cougarcanyon2: Convert to text environment
>   x86: minnowmax: Convert to text environment
>   x86: slimbootloader: Convert to text environment
>   x86: efi-x86_app: Convert to text environment
>   x86: efi-x86_payload: Convert to text environment
>   x86: qemu: Add required linux/sizes.h include
>   x86: qemu-x86: Convert to text environment
> 
>  arch/x86/cpu/qemu/dram.c                      |  1 +
>  arch/x86/cpu/qemu/e820.c                      |  1 +
>  arch/x86/lib/i8254.c                          |  1 +
>  arch/x86/lib/physmem.c                        |  3 +-
>  board/coreboot/coreboot/coreboot.env          |  9 +++++
>  board/efi/efi-x86_app/efi-x86_app.env         |  6 ++++
>  board/efi/efi-x86_payload/efi-x86_payload.env |  6 ++++
>  board/emulation/qemu-x86/qemu-x86.env         |  6 ++++
>  board/intel/bayleybay/bayleybay.env           |  9 +++++
>  board/intel/cherryhill/cherryhill.env         |  9 +++++
>  board/intel/cougarcanyon2/cougarcanyon2.env   |  6 ++++
>  board/intel/crownbay/crownbay.env             |  6 ++++
>  board/intel/edison/edison.env                 |  6 ++++
>  board/intel/galileo/galileo.env               | 11 ++++++
>  board/intel/minnowmax/minnowmax.env           | 11 ++++++
>  board/intel/slimbootloader/slimbootloader.env | 25 +++++++++++++
>  board/keymile/km83xx/km83xx.env               |  4 +--
>  board/keymile/kmcent2/kmcent2.env             |  2 +-
>  .../keymile/pg-wcom-ls102xa/pg-wcom-expu1.env |  2 +-
>  .../keymile/pg-wcom-ls102xa/pg-wcom-seli8.env |  2 +-
>  board/siemens/iot2050/iot2050.env             |  2 +-
>  board/ti/am62ax/am62ax.env                    |  4 +--
>  board/ti/am62x/am62x.env                      |  4 +--
>  board/ti/am64x/am64x.env                      |  6 ++--
>  board/ti/am65x/am65x.env                      |  8 ++---
>  board/ti/j721e/j721e.env                      | 10 +++---
>  board/ti/j721s2/j721s2.env                    | 10 +++---
>  board/ti/ks2_evm/k2e_evm.env                  |  4 +--
>  board/ti/ks2_evm/k2g_evm.env                  |  6 ++--
>  board/ti/ks2_evm/k2hk_evm.env                 |  4 +--
>  board/ti/ks2_evm/k2l_evm.env                  |  4 +--
>  doc/usage/environment.rst                     |  8 ++++-
>  include/configs/am335x_evm.h                  |  2 +-
>  include/configs/am43xx_evm.h                  |  2 +-
>  include/configs/am57xx_evm.h                  |  2 +-
>  include/configs/am62ax_evm.h                  |  4 +--
>  include/configs/am62x_evm.h                   |  2 +-
>  include/configs/am64x_evm.h                   |  4 +--
>  include/configs/am65x_evm.h                   |  6 ++--
>  include/configs/bayleybay.h                   | 17 ---------
>  include/configs/cherryhill.h                  | 13 -------
>  include/configs/coreboot.h                    | 20 -----------
>  include/configs/cougarcanyon2.h               | 13 -------
>  include/configs/crownbay.h                    | 17 ---------
>  include/configs/da850evm.h                    |  2 +-
>  include/configs/dra7xx_evm.h                  |  2 +-
>  include/configs/edison.h                      | 11 ------
>  include/configs/efi-x86_app.h                 | 11 ------
>  include/configs/efi-x86_payload.h             | 17 ---------
>  include/configs/galileo.h                     | 19 ----------
>  include/configs/minnowmax.h                   | 16 ---------
>  include/configs/omap3_evm.h                   |  2 +-
>  include/configs/omapl138_lcdk.h               |  2 +-
>  include/configs/phycore_am335x_r2.h           |  4 +--
>  include/configs/qemu-x86.h                    | 23 ------------
>  include/configs/sifive-unleashed.h            |  2 +-
>  include/configs/slimbootloader.h              | 35 -------------------
>  include/configs/ti_omap4_common.h             |  2 +-
>  include/configs/ti_omap5_common.h             |  4 +--
>  include/configs/x86-common.h                  | 19 ----------
>  include/{environment => env}/distro/sf.h      |  0
>  .../{environment => env}/pg-wcom/common.env   |  0
>  .../{environment => env}/pg-wcom/ls102xa.env  |  2 +-
>  .../{environment => env}/pg-wcom/powerpc.env  |  0
>  include/{environment => env}/ti/dfu.h         |  0
>  include/{environment => env}/ti/k3_dfu.env    |  0
>  include/{environment => env}/ti/k3_dfu.h      |  0
>  include/{environment => env}/ti/k3_rproc.env  |  0
>  include/{environment => env}/ti/k3_rproc.h    |  0
>  include/{environment => env}/ti/mmc.env       |  0
>  include/{environment => env}/ti/mmc.h         |  0
>  include/{environment => env}/ti/nand.env      |  0
>  include/{environment => env}/ti/nand.h        |  0
>  .../ti/ti_armv7_common.env                    |  0
>  .../ti/ti_armv7_keystone2.env                 |  0
>  include/{environment => env}/ti/ufs.env       |  0
>  include/{environment => env}/ti/ufs.h         |  0
>  include/env/x86.env                           | 20 +++++++++++
>  78 files changed, 200 insertions(+), 291 deletions(-)
>  create mode 100644 board/coreboot/coreboot/coreboot.env
>  create mode 100644 board/efi/efi-x86_app/efi-x86_app.env
>  create mode 100644 board/efi/efi-x86_payload/efi-x86_payload.env
>  create mode 100644 board/emulation/qemu-x86/qemu-x86.env
>  create mode 100644 board/intel/bayleybay/bayleybay.env
>  create mode 100644 board/intel/cherryhill/cherryhill.env
>  create mode 100644 board/intel/cougarcanyon2/cougarcanyon2.env
>  create mode 100644 board/intel/crownbay/crownbay.env
>  create mode 100644 board/intel/edison/edison.env
>  create mode 100644 board/intel/galileo/galileo.env
>  create mode 100644 board/intel/minnowmax/minnowmax.env
>  create mode 100644 board/intel/slimbootloader/slimbootloader.env
>  rename include/{environment => env}/distro/sf.h (100%)
>  rename include/{environment => env}/pg-wcom/common.env (100%)
>  rename include/{environment => env}/pg-wcom/ls102xa.env (95%)
>  rename include/{environment => env}/pg-wcom/powerpc.env (100%)
>  rename include/{environment => env}/ti/dfu.h (100%)
>  rename include/{environment => env}/ti/k3_dfu.env (100%)
>  rename include/{environment => env}/ti/k3_dfu.h (100%)
>  rename include/{environment => env}/ti/k3_rproc.env (100%)
>  rename include/{environment => env}/ti/k3_rproc.h (100%)
>  rename include/{environment => env}/ti/mmc.env (100%)
>  rename include/{environment => env}/ti/mmc.h (100%)
>  rename include/{environment => env}/ti/nand.env (100%)
>  rename include/{environment => env}/ti/nand.h (100%)
>  rename include/{environment => env}/ti/ti_armv7_common.env (100%)
>  rename include/{environment => env}/ti/ti_armv7_keystone2.env (100%)
>  rename include/{environment => env}/ti/ufs.env (100%)
>  rename include/{environment => env}/ti/ufs.h (100%)
>  create mode 100644 include/env/x86.env
> 
> -- 
> 2.41.0.487.g6d72f3e995-goog
> 

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2023-07-31 12:01 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31  3:01 [PATCH 00/22] x86: Move some boards to text environment Simon Glass
2023-07-31  3:01 ` [PATCH 01/22] doc: Explain how to avoid the distro-boot scripts Simon Glass
2023-07-31  3:01 ` [PATCH 02/22] env: Use include/env for text-environment includes Simon Glass
2023-07-31  3:01 ` [PATCH 03/22] env: Explain how to use #include files in text environment Simon Glass
2023-07-31  3:01 ` [PATCH 04/22] x86: Drop CFG_SYS_STACK_SIZE Simon Glass
2023-07-31  3:01 ` [PATCH 05/22] x86: i8254: Include required ibmpc.h header Simon Glass
2023-07-31  3:01 ` [PATCH 06/22] x86: edison: Drop inclusion of ibmpc.h Simon Glass
2023-07-31  3:01 ` [PATCH 07/22] x86: " Simon Glass
2023-07-31  3:01 ` [PATCH 08/22] x86: Drop unused distro settings Simon Glass
2023-07-31  3:01 ` [PATCH 09/22] x86: Add a common include for environment settings Simon Glass
2023-07-31  3:01 ` [PATCH 10/22] x86: coreboot: Convert to text environment Simon Glass
2023-07-31  3:01 ` [PATCH 11/22] x86: crownbay: " Simon Glass
2023-07-31  3:01 ` [PATCH 12/22] x86: bayleybay: " Simon Glass
2023-07-31  3:01 ` [PATCH 13/22] x86: galileo: " Simon Glass
2023-07-31  3:01 ` [PATCH 14/22] x86: edison: " Simon Glass
2023-07-31  3:01 ` [PATCH 15/22] x86: cherryhill: " Simon Glass
2023-07-31  3:01 ` [PATCH 16/22] x86: cougarcanyon2: " Simon Glass
2023-07-31  3:02 ` [PATCH 17/22] x86: minnowmax: " Simon Glass
2023-07-31  3:02 ` [PATCH 18/22] x86: slimbootloader: " Simon Glass
2023-08-03 11:25   ` Bin Meng
2023-07-31  3:02 ` [PATCH 19/22] x86: efi-x86_app: " Simon Glass
2023-07-31  3:02 ` [PATCH 20/22] x86: efi-x86_payload: " Simon Glass
2023-07-31  3:02 ` [PATCH 21/22] x86: qemu: Add required linux/sizes.h include Simon Glass
2023-07-31  3:02 ` [PATCH 22/22] x86: qemu-x86: Convert to text environment Simon Glass
2023-07-31  8:09 ` Andy Shevchenko [this message]
2023-07-31 17:08   ` [PATCH 00/22] x86: Move some boards " Simon Glass
2023-08-03 11:27   ` Bin Meng
2023-08-03 11:31     ` Bin Meng
2023-08-06 10:51 ` Pali Rohár
2023-08-06 14:39   ` Simon Glass
2023-08-06 15:55     ` Pali Rohár
2023-08-07  1:43       ` Bin Meng
2023-08-07  7:24         ` Pali Rohár
2023-08-07 12:44           ` Michael Nazzareno Trimarchi
2023-08-07 13:03             ` Andy Shevchenko
2023-08-07 13:17               ` Tom Rini
2023-08-07 13:30               ` Michael Nazzareno Trimarchi
2023-08-07 14:21                 ` Andy Shevchenko
2023-08-07 17:04                 ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMdsLDYAXYDVFqsY@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=a-govindraju@ti.com \
    --cc=afd@ti.com \
    --cc=aford173@gmail.com \
    --cc=aiden.park@intel.com \
    --cc=aleksandar.gerasimovski@hitachienergy.com \
    --cc=anup@brainfault.org \
    --cc=atishp@atishpatra.org \
    --cc=bb@ti.com \
    --cc=bmeng.cn@gmail.com \
    --cc=d-gerlach@ti.com \
    --cc=holger.brunck@hitachienergy.com \
    --cc=hs@denx.de \
    --cc=jan.kiszka@siemens.com \
    --cc=jm@ti.com \
    --cc=joe.hershberger@ni.com \
    --cc=le.jin@siemens.com \
    --cc=lusus@denx.de \
    --cc=m-chawdhry@ti.com \
    --cc=n-francis@ti.com \
    --cc=n-jain1@ti.com \
    --cc=pali@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=parthiban@linumiz.com \
    --cc=paul.walmsley@sifive.com \
    --cc=pro@denx.de \
    --cc=rainer.boschung@hitachienergy.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    --cc=wd@denx.de \
    --cc=woods.technical@gmail.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox