From: Leo Liang <ycliang@andestech.com>
To: Shengyu Qu <wiagn233@outlook.com>
Cc: <rick@andestech.com>, <bmeng@tinylab.org>, <ganboing@gmail.com>,
<yanhong.wang@starfivetech.com>, <n.shubin@yadro.com>,
<u-boot@lists.denx.de>
Subject: Re: [PATCH v4 2/3] riscv: Add SPL_ZERO_MEM_BEFORE_USE implementation
Date: Thu, 10 Aug 2023 10:53:34 +0800 [thread overview]
Message-ID: <ZNRRLu489f593l2r@swlinux02> (raw)
In-Reply-To: <TY3P286MB2611DDEE053C755283E153199812A@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
On Wed, Aug 09, 2023 at 09:11:32PM +0800, Shengyu Qu wrote:
> Add the actual support code for SPL_ZERO_MEM_BEFORE_USE and remove
> existing Starfive JH7110's L2 LIM clean code, since existing code has
> following issues:
> 1. Each hart (in the middle of a function call) overwriting its own
> stack and other harts' stacks.
> (data-race and data-corruption)
> 2. Lottery winner hart can be doing "board_init_f_init_reserve",
> while other harts are in the middle of zeroing L2 LIM.
> (data-race)
>
> Signed-off-by: Bo Gan <ganboing@gmail.com>
> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
> ---
> Changes since v2:
> - Fix typo (ZERO_MEM_BEFORE_USE to SPL_ZERO_MEM_BEFORE_USE)
> Changes since v3:
> - Revert v3's fix since original implementation is actually right
> ---
> arch/riscv/cpu/jh7110/spl.c | 25 -------------------------
> arch/riscv/cpu/start.S | 12 ++++++++++++
> common/init/board_init.c | 3 +++
> 3 files changed, 15 insertions(+), 25 deletions(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
next prev parent reply other threads:[~2023-08-10 2:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230809131133.28646-1-wiagn233@outlook.com>
2023-08-09 13:11 ` [PATCH v4 1/3] riscv: Kconfig: Add SPL_ZERO_MEM_BEFORE_USE Shengyu Qu
2023-08-09 13:11 ` [PATCH v4 2/3] riscv: Add SPL_ZERO_MEM_BEFORE_USE implementation Shengyu Qu
2023-08-10 2:53 ` Leo Liang [this message]
2023-08-09 13:11 ` [PATCH v4 3/3] riscv: cpu: jh7110: Select SPL_ZERO_MEM_BEFORE_USE Shengyu Qu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNRRLu489f593l2r@swlinux02 \
--to=ycliang@andestech.com \
--cc=bmeng@tinylab.org \
--cc=ganboing@gmail.com \
--cc=n.shubin@yadro.com \
--cc=rick@andestech.com \
--cc=u-boot@lists.denx.de \
--cc=wiagn233@outlook.com \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox