From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3FCAC001B0 for ; Thu, 10 Aug 2023 09:10:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A7D34866AA; Thu, 10 Aug 2023 11:10:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Ov+lJoWL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B5540866B5; Thu, 10 Aug 2023 11:10:48 +0200 (CEST) Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7CD9686128 for ; Thu, 10 Aug 2023 11:10:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3fe4cdb724cso6055405e9.1 for ; Thu, 10 Aug 2023 02:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691658646; x=1692263446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8QA/A8hk46gyGrGvXqppDeNWqsWMLfxew5w5shAqwb4=; b=Ov+lJoWLJYDasxFfHlXC5LgLVOUzRmwx8pYey1ChAogo+s2Iu86YHqVRV7qwx9fGBR ctF8HB09PoqUVBkKn1+BcK+S5Hy/skM6yd22BF3VLGTMwMqmf+b8Uw6abx/QyXEkCAfk 2zpdHLJWMTXwTnreeruXb9kCS2shOg8etphwlIB9HBDdhyRDN/soEuz77e94tKpTLfzo LARXp4aTWDlppThRIW4eSDQIhLKSqUbuCC2KQT1aEIcI3q4XiHXbFbqzk32xEVdmGSnS hfgmbJ16C9Ia2xnjyIXqQDdugKwfOaJAGY1mrXe2snMPr9eZ0YZAVebDYc319qOrL6aY HYDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691658646; x=1692263446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8QA/A8hk46gyGrGvXqppDeNWqsWMLfxew5w5shAqwb4=; b=ZuWHtNmZhoCtnizeeeEZkyddRYixQ2jzqhckupqAk0suzke/sm66ktWM1JPGzbjY7H dXbEVe/3vEa1hvY2KfTZ03pQTlf/MjH/7+5hsVAoR/bmsh5cYYnTdnfKL74FXXcycMts bqH/G79o6vfPfPu4FZ2jILPsw5Olzs3k0Gg3eZw9TBM8cqUDmWt8B0Mfn3Lwi5paphI/ h5va7TcUPz8xF8BarXsYHs4qlUxrc4dIBQ8SbPsjDYK5bjT3rKhOUTppEzUmuKT9rEkm ggq5sqkP0Cm1n3QxinbwDMLI8bPuy7arBlAWOR6wsLVsw400uPj2C/kkbdsPAxyXw5xB ClVg== X-Gm-Message-State: AOJu0YyAYhTpi0XfpSvtJe/XHSziV+KRjAonKK/qN2PyD8xh8NSmkcZ6 1wezoizSFM4PPfxyDq/Nvi+n1A== X-Google-Smtp-Source: AGHT+IGj7v1MoJG9RFx6sp9z15JgTf5aNFchXOXksSDLQzsx899P63+mg8GqCb6hHGquVFHJArdM+A== X-Received: by 2002:a1c:7219:0:b0:3fb:e206:ca5f with SMTP id n25-20020a1c7219000000b003fbe206ca5fmr1503611wmc.31.1691658645832; Thu, 10 Aug 2023 02:10:45 -0700 (PDT) Received: from hades (ppp089210246083.access.hol.gr. [89.210.246.83]) by smtp.gmail.com with ESMTPSA id k1-20020a5d4281000000b00317a29af4b2sm1467615wrq.68.2023.08.10.02.10.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 02:10:45 -0700 (PDT) Date: Thu, 10 Aug 2023 12:10:43 +0300 From: Ilias Apalodimas To: Julia Daxenberger Cc: u-boot@lists.denx.de, sjg@chromium.org Subject: Re: [PATCH v2 0/2] tpm: Add TPM2_GetTestResult command support Message-ID: References: <20230802083521.22585-1-julia.daxenberger@infineon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230802083521.22585-1-julia.daxenberger@infineon.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Julia, On Wed, Aug 02, 2023 at 10:35:19AM +0200, Julia Daxenberger wrote: > Add TPM2_GetTestResult command support and change the command file and the > help accordingly. Add Python tests and sandbox driver functionality. > > Currently, the tpm2_self_test function is implemented and can be called > directly. The get_test_result function enables interested parties to > retrieve the test result provided by the self test. > Some of the TPM tests fail with these patches applied [0]. Can you please take a look and fix those? [0] https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/17277 Thanks /Ilias > --- > Changes in v2: > - Apply style changes suggested by Ilias Apalodimas > > - Move test cases reliant on restart_uboot() to seperate patch in > response to Simon Glass > - Change test result data to be read directly from the response > - Fix minor style issues > > Julia Daxenberger (2): > tpm: Add TPM2_GetTestResult command support > tpm: Add error scenarios to get_test_result test > > cmd/tpm-v2.c | 60 +++++++++++++++++++++ > drivers/tpm/tpm2_tis_sandbox.c | 51 +++++++++++++++++- > include/tpm-v2.h | 23 ++++++++ > lib/tpm-v2.c | 97 ++++++++++++++++++++++++++++++++++ > test/py/tests/test_tpm2.py | 50 ++++++++++++++++ > 5 files changed, 280 insertions(+), 1 deletion(-) >