From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF72BC0015E for ; Fri, 11 Aug 2023 23:44:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A29A886915; Sat, 12 Aug 2023 01:44:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="nRPAeJeX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 434978693C; Sat, 12 Aug 2023 01:44:08 +0200 (CEST) Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0F53F861E1 for ; Sat, 12 Aug 2023 01:44:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6872c60b572so515176b3a.1 for ; Fri, 11 Aug 2023 16:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691797444; x=1692402244; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=9QG783iBe3yIitt6KeXXCO+nyHHk2mOaMY03qssQX/M=; b=nRPAeJeXzXZ6x03VJUrBHSTMF1/nJmInKEWlXtC8EC9xNa0mZDKtO3PzElX63sPJ2M yo94eNczYYm8Mk26z2kXZQ/CeE55V7KUUewDymF23PCUcBtlHTlt6ONSJ5+IrrX/stF7 RSDw42JhhYttkdZD3e+GjdcHpQt1eP3yi5lpgIZFRbv8tb+zKVSwXQGCogwgnQgLOblT E0NTRgKu3ZcoJRSnQ2ye6rLRO1Ji7UXdI7e/83h8/RNe/Or4/SKz1OBJ7lDVR5TgNa5/ 5O7O+g6OjzzMS5EZEexwMURbpHBFYVOx83YzxdYQGXZMe4jlKfobOroxB/OClRS/4QmD A38A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691797444; x=1692402244; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9QG783iBe3yIitt6KeXXCO+nyHHk2mOaMY03qssQX/M=; b=GxnAf1ehsv6hjPSdHs0PR9Vh3OFNbV2pUlLZ3DAGeadMryt2KwgYksMzbmd/xZFoHv uRPSNXIRCWEvsExb+QYuw3FT2ckUIW5lyaRpSN5oxGS6cFsx0sLwGOvikCEHCosLme86 wIn3xidbSO/sFvbEHlnhfWB7kNRRYlnA4Y74FAIaH2UeQZfuttT0jCv+q4hfmsigSmYH bE+hlBNWS/yzizbQoP/jM1QBlaLUwbpDcGUVM4/nAOsi5JtgtVffv0CaJsff0RtDyHP7 7xCOOFJd63W40XEjuW9MSQFBES3p63eY600zxSm8HfYzT3ae18q0kLJPmXfxwyE35nMK XFsw== X-Gm-Message-State: AOJu0Yzn2Am4XPQB6n22tzeGQ/ZQUmNvD6UdDSOfYxfaKxvAiMsXdld/ JvWARJ22gUt5FjlKs9qWamv54g== X-Google-Smtp-Source: AGHT+IEkqd9IfUsUCbjcBAZqT0FLZBP9mvruDE467hwJv6lnndg+lkAR2TI6u7MKBOsIsPy2iUJX+Q== X-Received: by 2002:a05:6a21:3390:b0:137:3eba:b808 with SMTP id yy16-20020a056a21339000b001373ebab808mr4837591pzb.5.1691797444101; Fri, 11 Aug 2023 16:44:04 -0700 (PDT) Received: from octopus ([2400:4050:c3e1:100:a91d:8473:8de6:5605]) by smtp.gmail.com with ESMTPSA id j18-20020aa783d2000000b00662610cf7a8sm3959168pfn.172.2023.08.11.16.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 16:44:03 -0700 (PDT) Date: Sat, 12 Aug 2023 08:43:59 +0900 From: Takahiro Akashi To: Sughosh Ganu Cc: Simon Glass , Tom Rini , u-boot@lists.denx.de, Heinrich Schuchardt , Ilias Apalodimas , Malte Schmidt , Michal Simek Subject: Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants Message-ID: Mail-Followup-To: Takahiro Akashi , Sughosh Ganu , Simon Glass , Tom Rini , u-boot@lists.denx.de, Heinrich Schuchardt , Ilias Apalodimas , Malte Schmidt , Michal Simek References: <20230810142338.3402963-1-sughosh.ganu@linaro.org> <20230810142338.3402963-5-sughosh.ganu@linaro.org> <20230810155232.GS3630934@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, Aug 11, 2023 at 07:54:11PM +0530, Sughosh Ganu wrote: > hi Simon, > > On Fri, 11 Aug 2023 at 19:07, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Fri, 11 Aug 2023 at 05:23, Sughosh Ganu wrote: > > > > > > hi Simon, > > > > > > On Thu, 10 Aug 2023 at 22:57, Simon Glass wrote: > > > > > > > > Hi, > > > > > > > > On Thu, 10 Aug 2023 at 09:52, Tom Rini wrote: > > > > > > > > > > On Thu, Aug 10, 2023 at 07:53:33PM +0530, Sughosh Ganu wrote: > > > > > > > > > > > Build the mkeficapsule tool for all the sandbox variants. This tool > > > > > > will be used subsequently for testing capsule generation in binman. > > > > > > > > > > > > Signed-off-by: Sughosh Ganu > > > > > > --- > > > > > > Changes since V7: None > > > > > > > > > > > > tools/Kconfig | 6 +++--- > > > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > > > > > diff --git a/tools/Kconfig b/tools/Kconfig > > > > > > index 6e23f44d55..353a855243 100644 > > > > > > --- a/tools/Kconfig > > > > > > +++ b/tools/Kconfig > > > > > > @@ -91,10 +91,10 @@ config TOOLS_SHA512 > > > > > > Enable SHA512 support in the tools builds > > > > > > > > > > > > config TOOLS_MKEFICAPSULE > > > > > > - bool "Build efimkcapsule command" > > > > > > - default y if EFI_CAPSULE_ON_DISK > > > > > > + bool "Build mkeficapsule tool" > > > > > > + default y if EFI_CAPSULE_ON_DISK || SANDBOX > > > > > > help > > > > > > - This command allows users to create a UEFI capsule file and, > > > > > > + This tool allows users to create a UEFI capsule file and, > > > > > > optionally sign that file. If you want to enable UEFI capsule > > > > > > update feature on your target, you certainly need this. > > > > > > > > > > Sorry, what is this fixing exactly? > > > > > > > > s/command/tool/ is mixed in with this commit, but the main purpose is > > > > to enable it on sandbox. > > > > > > Sorry, I did not understand this statement. The changes made here are > > > using the same nomenclature(tool) for referring to mkeficapsule. > > > > > > > > > > > The commit message really should mention both changes. > > > > > > Which two changes? The commit message states what the commit is doing, > > > and then states the reason for the change. What more information is > > > needed in the commit message? > > > > The two changes are: > > > > 1. The one the commit message mentions > > 2. Changing 'command' to 'tool' in the Kconfig > > Okay, will put in a mention for the second point as well. Thanks. There is another use of 'command' in CONFIG_TOOLS_MKFWUDATA. So it would be better to separate (2) from (1) and to fix both 'command'. -Takahiro Akashi > > -sughosh