From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Simon Glass <sjg@chromium.org>, u-boot@lists.denx.de
Cc: Bin Meng <bmeng.cn@gmail.com>
Subject: Re: [PATCH v1 2/2] x86: Prevent from missing the FADT chaining
Date: Fri, 25 Aug 2023 17:02:00 +0300 [thread overview]
Message-ID: <ZOi0WOZZTnJC/mMR@smile.fi.intel.com> (raw)
In-Reply-To: <20230825135141.3210006-2-andriy.shevchenko@linux.intel.com>
On Fri, Aug 25, 2023 at 04:51:41PM +0300, Andy Shevchenko wrote:
...
> +static inline int acpi_add_fadt(struct acpi_ctx *ctx, struct acpi_fadt *fadt)
> +{
> + acpi_add_table(ctx, fadt);
> + acpi_inc(ctx, sizeof(struct acpi_fadt));
> + return 0;
> +}
Ideally it should be like
int ret;
ret = acpi_add_table(ctx, fadt);
if (ret)
return ret;
acpi_inc(ctx, sizeof(struct acpi_fadt));
return 0;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-25 14:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 18:23 [PATCH 1/2] Reland "x86: Move FACP table into separate functions"" Simon Glass
2023-08-24 18:23 ` [PATCH 2/2] RFC: x86: acpi: Add some debugging Simon Glass
2023-08-25 11:06 ` [PATCH 1/2] Reland "x86: Move FACP table into separate functions"" Andy Shevchenko
2023-08-25 11:10 ` Andy Shevchenko
2023-08-25 12:59 ` Andy Shevchenko
2023-08-25 13:17 ` Andy Shevchenko
2023-08-25 13:25 ` Andy Shevchenko
2023-08-25 13:27 ` Andy Shevchenko
2023-08-25 13:51 ` [PATCH v1 1/2] TO BE FOLDED: x86: tangier: Add FADT to the chain Andy Shevchenko
2023-08-25 13:51 ` [PATCH v1 2/2] x86: Prevent from missing the FADT chaining Andy Shevchenko
2023-08-25 14:02 ` Andy Shevchenko [this message]
2023-08-25 18:06 ` [PATCH v1 1/2] TO BE FOLDED: x86: tangier: Add FADT to the chain Simon Glass
2023-09-19 7:28 ` Bin Meng
2023-09-19 7:56 ` Bin Meng
2023-09-19 19:58 ` Simon Glass
2023-08-25 18:06 ` [PATCH 1/2] Reland "x86: Move FACP table into separate functions"" Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOi0WOZZTnJC/mMR@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bmeng.cn@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox