From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Bin Meng <bmeng.cn@gmail.com>
Subject: Re: [PATCH 1/2] Reland "x86: Move FACP table into separate functions""
Date: Fri, 25 Aug 2023 16:25:29 +0300 [thread overview]
Message-ID: <ZOiryc6qOuentDqF@smile.fi.intel.com> (raw)
In-Reply-To: <ZOiqBvuZ6Z1gWd4h@smile.fi.intel.com>
On Fri, Aug 25, 2023 at 04:17:58PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 25, 2023 at 02:06:34PM +0300, Andy Shevchenko wrote:
> > On Thu, Aug 24, 2023 at 12:23:32PM -0600, Simon Glass wrote:
> > > Each board has its own way of creating this table. Rather than calling the
> > > acpi_create_fadt() function for each one from a common acpi_write_fadt()
> > > function, just move the writer into the board-specific code.
> >
> > No luck, but I have a bit of time to debug more.
>
> Okay, after your patch even U-Boot can't see those tables
>
> => acpi list
> Name Base Size Detail
> ---- -------- ----- ------
> RSDP 000e4500 24 v02 U-BOOT
> RSDT 000e4530 34 v01 U-BOOT U-BOOTBL 20231001 INTL 0
> XSDT 000e45e0 44 v01 U-BOOT U-BOOTBL 20231001 INTL 0
> CSRT 000e5490 58 v00 U-BOOT U-BOOTBL 20231001 INTL 0
> MCFG 000e5610 3c v01 U-BOOT U-BOOTBL 20231001 INTL 0
> SPCR 000e5650 50 v02 U-BOOT U-BOOTBL 20231001 INTL 0
> APIC 000e56a0 48 v02 U-BOOT U-BOOTBL 20231001 INTL 0
>
> Because the base is badly corrupted:
>
> -00000030: 52 53 44 54 38 00 00 00 01 95 55 2d 42 4f 4f 54 RSDT8.....U-BOOT
> +00000030: 52 53 44 54 34 00 00 00 01 eb 55 2d 42 4f 4f 54 RSDT4.....U-BOOT
Length -4 bytes, another checksum as a result.
> -00000050: 00 00 00 00 90 54 0e 00 f0 54 0e 00 10 56 0e 00 .....T...T...V..
> +00000050: 00 00 00 00 90 54 0e 00 10 56 0e 00 50 56 0e 00 .....T...V..PV..
Missing pointer to 0x0e54f0 which is... FADT!
> -00000060: 50 56 0e 00 a0 56 0e 00 00 00 00 00 00 00 00 00 PV...V..........
> +00000060: a0 56 0e 00 00 00 00 00 00 00 00 00 00 00 00 00 .V..............
>
> -000000e0: 58 53 44 54 4c 00 00 00 01 7b 55 2d 42 4f 4f 54 XSDTL....{U-BOOT
> +000000e0: 58 53 44 54 44 00 00 00 01 d5 55 2d 42 4f 4f 54 XSDTD.....U-BOOT
Wrong length, another checksum.
> -00000100: 00 00 00 00 90 54 0e 00 00 00 00 00 f0 54 0e 00 .....T.......T..
> +00000100: 00 00 00 00 90 54 0e 00 00 00 00 00 10 56 0e 00 .....T.......V..
>
> -00000110: 00 00 00 00 10 56 0e 00 00 00 00 00 50 56 0e 00 .....V......PV..
> +00000110: 00 00 00 00 50 56 0e 00 00 00 00 00 a0 56 0e 00 ....PV.......V..
>
> -00000120: 00 00 00 00 a0 56 0e 00 00 00 00 00 00 00 00 00 .....V..........
> +00000120: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
Same reason. So, your code forgot to link FADT to the main tables.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-25 13:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 18:23 [PATCH 1/2] Reland "x86: Move FACP table into separate functions"" Simon Glass
2023-08-24 18:23 ` [PATCH 2/2] RFC: x86: acpi: Add some debugging Simon Glass
2023-08-25 11:06 ` [PATCH 1/2] Reland "x86: Move FACP table into separate functions"" Andy Shevchenko
2023-08-25 11:10 ` Andy Shevchenko
2023-08-25 12:59 ` Andy Shevchenko
2023-08-25 13:17 ` Andy Shevchenko
2023-08-25 13:25 ` Andy Shevchenko [this message]
2023-08-25 13:27 ` Andy Shevchenko
2023-08-25 13:51 ` [PATCH v1 1/2] TO BE FOLDED: x86: tangier: Add FADT to the chain Andy Shevchenko
2023-08-25 13:51 ` [PATCH v1 2/2] x86: Prevent from missing the FADT chaining Andy Shevchenko
2023-08-25 14:02 ` Andy Shevchenko
2023-08-25 18:06 ` [PATCH v1 1/2] TO BE FOLDED: x86: tangier: Add FADT to the chain Simon Glass
2023-09-19 7:28 ` Bin Meng
2023-09-19 7:56 ` Bin Meng
2023-09-19 19:58 ` Simon Glass
2023-08-25 18:06 ` [PATCH 1/2] Reland "x86: Move FACP table into separate functions"" Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOiryc6qOuentDqF@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bmeng.cn@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox