Re: [PATCH v3 05/13] firmware: scmi: install base protocol to SCMI agent

[AKASHI Takahiro <takahiro.akashi@linaro.org>]

On Fri, Sep 08, 2023 at 02:19:22PM +0000, Etienne CARRIERE wrote:
> > From: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > Sent: Friday, September 8, 2023 04:51
> >  
> > SCMI base protocol is mandatory, and once SCMI node is found in a device
> > tree, the protocol handle (udevice) is unconditionally installed to
> > the agent. Then basic information will be retrieved from SCMI server via
> > the protocol and saved into the agent instance's local storage.
> > 
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> > Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>
> > ---
> > v3
> > * typo fix: add '@' for argument name in function description
> > * eliminate dev_get_uclass_plat()'s repeated in inline
> > * modify the code for dynamically allocated sub-vendor/agent names
> > v2
> > * use helper functions, removing direct uses of ops
> > ---
> 
> For info, I see that this patch, as placed in this PATCH v3 series, breaks pytest.
> Patch v3 08/13 ("firmware: scmi: fake base protocol commands on sandbox")
> and patch v3 09/13 ("test: dm: simplify SCMI unit test on sandbox") should be
> picked before to have scmi DM pytest running.

Thank you for catching this problem.
Will shuffle the commits.

-Takahiro Akashi


> BR,
> etienne