From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C90A0C83F3E for ; Tue, 5 Sep 2023 09:04:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1183C8654B; Tue, 5 Sep 2023 11:04:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 323D4868BC; Tue, 5 Sep 2023 11:04:19 +0200 (CEST) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7722E8653D for ; Tue, 5 Sep 2023 11:04:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 3859401D030245; Tue, 5 Sep 2023 17:04:00 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from swlinux02 (10.0.15.183) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Tue, 5 Sep 2023 17:03:59 +0800 Date: Tue, 5 Sep 2023 17:02:58 +0800 From: Leo Liang To: Heinrich Schuchardt CC: , Tom Rini Subject: Re: [PATCH 1/2] riscv: Rework riscv_cpu_probe for current event macros Message-ID: References: <20230904190635.3896494-1-trini@konsulko.com> <9cc69902-f8d7-4b86-b071-f293463a8f5d@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <9cc69902-f8d7-4b86-b071-f293463a8f5d@canonical.com> User-Agent: Mutt/2.2.10 (e0e92c31) (2023-03-25) X-Originating-IP: [10.0.15.183] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 3859401D030245 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Tue, Sep 05, 2023 at 10:58:31AM +0200, Heinrich Schuchardt wrote: > On 05.09.23 05:01, Leo Liang wrote: > > Hi Tom, > > > > On Mon, Sep 04, 2023 at 03:06:34PM -0400, Tom Rini wrote: > > > This function should now be a EVENT_SPY_SIMPLE call, update it. > > > > > > Signed-off-by: Tom Rini > > > --- > > > arch/riscv/cpu/cpu.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/riscv/cpu/cpu.c b/arch/riscv/cpu/cpu.c > > > index d64aa330f206..cfe9fdc9df55 100644 > > > --- a/arch/riscv/cpu/cpu.c > > > +++ b/arch/riscv/cpu/cpu.c > > > @@ -66,7 +66,7 @@ static inline bool supports_extension(char ext) > > > #endif /* CONFIG_CPU */ > > > } > > > -static int riscv_cpu_probe(void *ctx, struct event *event) > > > +static int riscv_cpu_probe(void) > > > { > > > #ifdef CONFIG_CPU > > > int ret; > > > @@ -79,7 +79,7 @@ static int riscv_cpu_probe(void *ctx, struct event *event) > > > return 0; > > > } > > > -EVENT_SPY(EVT_DM_POST_INIT_R, riscv_cpu_probe); > > > +EVENT_SPY_SIMPLE(EVT_DM_POST_INIT_R, riscv_cpu_probe); > > > > I cannot seem to find macro "EVENT_SPY_SIMPLE". > > Is there anything that should be added? > > Or did I miss anything? > > This patch is only applicable to origin/next. The definition there is in > include/event.h:311. > Thanks for the pointer! Best regards, Leo > Reviewed-by: Heinrich Schuchardt >