* [PATCH v1] pcie: starfive: Fix the incorrect use of dev_err()
@ 2025-08-27 3:11 Hal Feng
2025-08-27 19:13 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Hal Feng @ 2025-08-27 3:11 UTC (permalink / raw)
To: Tom Rini, Leo, Simon Glass, Sumit Garg; +Cc: Minda Chen, Hal Feng, u-boot
Use dev_info() instead of dev_err() when finishing the probe function.
Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
---
drivers/pci/pcie_starfive_jh7110.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pcie_starfive_jh7110.c b/drivers/pci/pcie_starfive_jh7110.c
index 51aca7359ff..f2256307ab3 100644
--- a/drivers/pci/pcie_starfive_jh7110.c
+++ b/drivers/pci/pcie_starfive_jh7110.c
@@ -292,7 +292,7 @@ static int starfive_pcie_probe(struct udevice *dev)
if (ret)
return ret;
- dev_err(dev, "Starfive PCIe bus probed.\n");
+ dev_info(dev, "StarFive PCIe bus probed\n");
return 0;
}
base-commit: 3dc5e9a0108bb114175b6362f9cb22367402f624
--
2.43.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] pcie: starfive: Fix the incorrect use of dev_err()
2025-08-27 3:11 [PATCH v1] pcie: starfive: Fix the incorrect use of dev_err() Hal Feng
@ 2025-08-27 19:13 ` Fabio Estevam
2025-09-01 8:01 ` Hal Feng
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2025-08-27 19:13 UTC (permalink / raw)
To: Hal Feng; +Cc: Tom Rini, Leo, Simon Glass, Sumit Garg, Minda Chen, u-boot
On Wed, Aug 27, 2025 at 11:26 AM Hal Feng <hal.feng@starfivetech.com> wrote:
>
> Use dev_info() instead of dev_err() when finishing the probe function.
>
> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> ---
> drivers/pci/pcie_starfive_jh7110.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pcie_starfive_jh7110.c b/drivers/pci/pcie_starfive_jh7110.c
> index 51aca7359ff..f2256307ab3 100644
> --- a/drivers/pci/pcie_starfive_jh7110.c
> +++ b/drivers/pci/pcie_starfive_jh7110.c
> @@ -292,7 +292,7 @@ static int starfive_pcie_probe(struct udevice *dev)
> if (ret)
> return ret;
>
> - dev_err(dev, "Starfive PCIe bus probed.\n");
> + dev_info(dev, "StarFive PCIe bus probed\n");
Or maybe remove this line.
We don't need drivers stating that they probed successfully.
Probe errors are helpful to print; probe success is not.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v1] pcie: starfive: Fix the incorrect use of dev_err()
2025-08-27 19:13 ` Fabio Estevam
@ 2025-09-01 8:01 ` Hal Feng
0 siblings, 0 replies; 3+ messages in thread
From: Hal Feng @ 2025-09-01 8:01 UTC (permalink / raw)
To: Fabio Estevam
Cc: Tom Rini, Leo, Simon Glass, Sumit Garg, u-boot@lists.denx.de
> On 28.08.25 03:14, Fabio Estevam wrote:
> On Wed, Aug 27, 2025 at 11:26 AM Hal Feng <hal.feng@starfivetech.com>
> wrote:
> >
> > Use dev_info() instead of dev_err() when finishing the probe function.
> >
> > Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> > ---
> > drivers/pci/pcie_starfive_jh7110.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/pcie_starfive_jh7110.c
> b/drivers/pci/pcie_starfive_jh7110.c
> > index 51aca7359ff..f2256307ab3 100644
> > --- a/drivers/pci/pcie_starfive_jh7110.c
> > +++ b/drivers/pci/pcie_starfive_jh7110.c
> > @@ -292,7 +292,7 @@ static int starfive_pcie_probe(struct udevice *dev)
> > if (ret)
> > return ret;
> >
> > - dev_err(dev, "Starfive PCIe bus probed.\n");
> > + dev_info(dev, "StarFive PCIe bus probed\n");
>
> Or maybe remove this line.
>
> We don't need drivers stating that they probed successfully.
>
> Probe errors are helpful to print; probe success is not.
Agree with you. Let's remove this line. Thanks.
Best regards,
Hal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-01 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-27 3:11 [PATCH v1] pcie: starfive: Fix the incorrect use of dev_err() Hal Feng
2025-08-27 19:13 ` Fabio Estevam
2025-09-01 8:01 ` Hal Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).