Re: [PULL] u-boot-riscv/master

Tom Rini
2021-05-26T15:24:48Z

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

On Wed, May 26, 2021 at 04:12:50PM +0800, Leo Liang wrote:

> Hi Tom,
>
> The following changes since commit eb53b943be2949ca111140a8e05532cd74cda058:
>
> Merge https://source.denx.de/u-boot/custodians/u-boot-sh (2021-05-23 10:15:15 -0400)
>
> are available in the Git repository at:
>
> git@source.denx.de:u-boot/custodians/u-boot-riscv.git
>
> for you to fetch changes up to 9358576a281ab5e3b7348685bbd5f713833a5048:
>
> drivers: pci: pcie_dw_common: fix Werror compilation error (2021-05-24 23:54:54 +0800)
>
> Gitlab CI result shows no issue: https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/7620
>

NAK.
ERROR: fdt or initrd relocation disabled at boot time
#993: FILE: include/configs/sifive-unmatched.h:65:
+ "fdt_high=0xffffffffffffffff\0" \

ERROR: fdt or initrd relocation disabled at boot time
#994: FILE: include/configs/sifive-unmatched.h:66:
+ "initrd_high=0xffffffffffffffff\0" \

You can, but shouldn't disable initrd relocation. You cannot disable
device tree relocation as that leads to too many issues due to
misalignment later. Make use of bootm_size or similar to make sure
everything is within an appropriate area of memory. Thanks.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]