* [PATCH 1/1] starfive: visionfive2: add mmc0 and nvme boot targets
@ 2023-09-18 8:32 Milan P. Stanić
2023-09-20 12:45 ` Leo Liang
0 siblings, 1 reply; 4+ messages in thread
From: Milan P. Stanić @ 2023-09-18 8:32 UTC (permalink / raw)
To: u-boot; +Cc: Shengyu Qu, Jami Kettunen, Milan P . Stanić
boot from SDIO3.0 (mmc sdcard) first if it is plugged.
If mmc is not plugged try to boot from emmc if it is plugged.
If emmc is not plugged then try to boot from nvme.
Signed-off-by: Milan P. Stanić <mps@arvanta.net>
---
include/configs/starfive-visionfive2.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/configs/starfive-visionfive2.h b/include/configs/starfive-visionfive2.h
index 4ee02b8420..13cf2aeef9 100644
--- a/include/configs/starfive-visionfive2.h
+++ b/include/configs/starfive-visionfive2.h
@@ -19,6 +19,8 @@
#define BOOT_TARGET_DEVICES(func) \
func(MMC, mmc, 1) \
+ func(MMC, mmc, 0) \
+ func(NVME, nvme, 0) \
func(DHCP, dhcp, na)
#include <config_distro_bootcmd.h>
--
2.42.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] starfive: visionfive2: add mmc0 and nvme boot targets
2023-09-18 8:32 [PATCH 1/1] starfive: visionfive2: add mmc0 and nvme boot targets Milan P. Stanić
@ 2023-09-20 12:45 ` Leo Liang
2023-09-23 19:53 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: Leo Liang @ 2023-09-20 12:45 UTC (permalink / raw)
To: Milan P. Stanić; +Cc: u-boot, Shengyu Qu, Jami Kettunen
On Mon, Sep 18, 2023 at 10:32:29AM +0200, Milan P. Stanić wrote:
> boot from SDIO3.0 (mmc sdcard) first if it is plugged.
> If mmc is not plugged try to boot from emmc if it is plugged.
> If emmc is not plugged then try to boot from nvme.
>
> Signed-off-by: Milan P. Stanić <mps@arvanta.net>
> ---
> include/configs/starfive-visionfive2.h | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] starfive: visionfive2: add mmc0 and nvme boot targets
2023-09-20 12:45 ` Leo Liang
@ 2023-09-23 19:53 ` Simon Glass
2023-09-25 11:39 ` Leo Liang
0 siblings, 1 reply; 4+ messages in thread
From: Simon Glass @ 2023-09-23 19:53 UTC (permalink / raw)
To: Leo Liang; +Cc: Milan P. Stanić, u-boot, Shengyu Qu, Jami Kettunen
Hi Leo,
On Wed, 20 Sept 2023 at 06:46, Leo Liang <ycliang@andestech.com> wrote:
>
> On Mon, Sep 18, 2023 at 10:32:29AM +0200, Milan P. Stanić wrote:
> > boot from SDIO3.0 (mmc sdcard) first if it is plugged.
> > If mmc is not plugged try to boot from emmc if it is plugged.
> > If emmc is not plugged then try to boot from nvme.
> >
> > Signed-off-by: Milan P. Stanić <mps@arvanta.net>
> > ---
> > include/configs/starfive-visionfive2.h | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
How about converting to standard boot and then this will be automatic?
Regards,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] starfive: visionfive2: add mmc0 and nvme boot targets
2023-09-23 19:53 ` Simon Glass
@ 2023-09-25 11:39 ` Leo Liang
0 siblings, 0 replies; 4+ messages in thread
From: Leo Liang @ 2023-09-25 11:39 UTC (permalink / raw)
To: Simon Glass; +Cc: Milan P. Stanić, u-boot, Shengyu Qu, Jami Kettunen
On Sat, Sep 23, 2023 at 01:53:30PM -0600, Simon Glass wrote:
> Hi Leo,
>
> On Wed, 20 Sept 2023 at 06:46, Leo Liang <ycliang@andestech.com> wrote:
> >
> > On Mon, Sep 18, 2023 at 10:32:29AM +0200, Milan P. Stanić wrote:
> > > boot from SDIO3.0 (mmc sdcard) first if it is plugged.
> > > If mmc is not plugged try to boot from emmc if it is plugged.
> > > If emmc is not plugged then try to boot from nvme.
> > >
> > > Signed-off-by: Milan P. Stanić <mps@arvanta.net>
> > > ---
> > > include/configs/starfive-visionfive2.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> >
> > Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
>
> How about converting to standard boot and then this will be automatic?
Hi Simon,
Do you mean that we should implement this feature in a more general manner,
instead of implementing this in only on vf2 board ?
Best regards,
Leo
>
> Regards,
> Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-25 11:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-18 8:32 [PATCH 1/1] starfive: visionfive2: add mmc0 and nvme boot targets Milan P. Stanić
2023-09-20 12:45 ` Leo Liang
2023-09-23 19:53 ` Simon Glass
2023-09-25 11:39 ` Leo Liang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox