From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31A76E7D24B for ; Tue, 26 Sep 2023 07:54:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 87D4486C13; Tue, 26 Sep 2023 09:54:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 5C47286D42; Tue, 26 Sep 2023 09:54:36 +0200 (CEST) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5AC0786A94 for ; Tue, 26 Sep 2023 09:54:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 38Q7sODw009673; Tue, 26 Sep 2023 15:54:24 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from swlinux02 (10.0.15.183) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Tue, 26 Sep 2023 15:54:19 +0800 Date: Tue, 26 Sep 2023 15:53:17 +0800 From: Leo Liang To: Heinrich Schuchardt CC: Rick Chen , Subject: Re: [PATCH 1/1] riscv: enable CONFIG_DEBUG_UART by default Message-ID: References: <20230922233526.62642-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230922233526.62642-1-heinrich.schuchardt@canonical.com> User-Agent: Mutt/2.2.10 (e0e92c31) (2023-03-25) X-Originating-IP: [10.0.15.183] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 38Q7sODw009673 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Sat, Sep 23, 2023 at 01:35:26AM +0200, Heinrich Schuchardt wrote: > Most boards don't enable the pre-console buffer. So we will not see any > early messages. OpenSBI 1.3 provides us with the debug console extension > that can fill this gap. > > For S-Mode U-Boot enable CONFIG_DEBUG_UART by default. > > Signed-off-by: Heinrich Schuchardt > --- > arch/riscv/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 1c62c2345b..06fae7ebe8 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -141,6 +141,7 @@ config RISCV_MMODE > > config RISCV_SMODE > bool "Supervisor" > + imply DEBUG_UART This patch will cause the following compilation warnings. Could you take a look at them ? It seems that some configuration values will not be set if we imply DEBUG_UART. u-boot$ make qemu-riscv64_spl_defconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o YACC scripts/kconfig/zconf.tab.c LEX scripts/kconfig/zconf.lex.c HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf # # configuration written to .config # u-boot$ make ARCH_FLAGS="-march=rv64imafdc" -j`nproc` scripts/kconfig/conf --syncconfig Kconfig .config:78:warning: symbol value '' invalid for DEBUG_UART_BASE .config:79:warning: symbol value '' invalid for DEBUG_UART_CLOCK .config:1347:warning: symbol value '' invalid for SPL_DEBUG_UART_BASE ... Best regards, Leo > help > Choose this option to build U-Boot for RISC-V S-Mode. > > -- > 2.40.1 >