From: Slawomir Stepien <sst@poczta.fm>
To: Jonas Karlman <jonas@kwiboo.se>
Cc: kever.yang@rock-chips.com, philipp.tomsich@vrull.eu,
sjg@chromium.org, u-boot@lists.denx.de
Subject: Re: [PATCH 2/2] configs: orangepi-5-plus-rk3588: Build SPI image by default
Date: Tue, 31 Oct 2023 18:28:12 +0100 [thread overview]
Message-ID: <ZUE5LCNz3oc3R_9Q@nr200> (raw)
In-Reply-To: <3d718a4e-0977-4a9b-8b9d-dc0e01849c82@kwiboo.se>
On paź 31, 2023 17:49, Jonas Karlman wrote:
> On 2023-10-31 17:13, Slawomir Stepien wrote:
> > Flashing this image to the on-board flash is useful when you want to
> > start Linux from a medium (e.g. nvme) without flashing u-boot elements
> > to it.
> >
> > Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> > ---
> > configs/orangepi-5-plus-rk3588_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/configs/orangepi-5-plus-rk3588_defconfig b/configs/orangepi-5-plus-rk3588_defconfig
> > index 0473699621..9af65026a0 100644
> > --- a/configs/orangepi-5-plus-rk3588_defconfig
> > +++ b/configs/orangepi-5-plus-rk3588_defconfig
> > @@ -103,3 +103,4 @@ CONFIG_USB_OHCI_GENERIC=y
> > CONFIG_USB_DWC3=y
> > CONFIG_USB_DWC3_GENERIC=y
> > CONFIG_ERRNO_STR=y
> > +CONFIG_ROCKCHIP_SPI_IMAGE=y
>
> This was intentionally left out from original submission due to an
> unfinished discussion at [1].
>
> Also note that this option is not added at correct position in defconfig
> file. Next time, please re-sync defconfig changes with a make
> savedefconfig generated file.
Ah yes. I did forget about it. Sorry. I will regenerate it correctly...if there will be v2.
> [1] https://lore.kernel.org/u-boot/b82c02c0-0a37-8553-f498-b03f85394d59@kwiboo.se/
>
> Regards,
> Jonas
--
Slawomir Stepien
next prev parent reply other threads:[~2023-10-31 17:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 16:13 [PATCH 1/2] rockchip: rk3588: Add SPINAND as boot device Slawomir Stepien
2023-10-31 16:13 ` [PATCH 2/2] configs: orangepi-5-plus-rk3588: Build SPI image by default Slawomir Stepien
2023-10-31 16:49 ` Jonas Karlman
2023-10-31 17:28 ` Slawomir Stepien [this message]
2023-10-31 16:45 ` [PATCH 1/2] rockchip: rk3588: Add SPINAND as boot device Jonas Karlman
2023-11-02 7:27 ` Kever Yang
2023-11-03 9:34 ` Slawomir Stepien
2023-11-03 10:02 ` Kever Yang
2023-11-03 10:03 ` Jonas Karlman
2023-11-03 10:30 ` Slawomir Stepien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUE5LCNz3oc3R_9Q@nr200 \
--to=sst@poczta.fm \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox