Re: [PATCH 1/2] rockchip: rk3588: Add SPINAND as boot device

Jonas Karlman
2023-10-31T16:45:23Z

On 2023-10-31 17:13, Slawomir Stepien wrote:
> Mark the flash@0 as BROM_BOOTSOURCE_SPINAND.
> Fixes use of same-as-spl in u-boot,spl-boot-order prop on Orange Pi 5
> Plus.
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> ---
> arch/arm/mach-rockchip/rk3588/rk3588.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-rockchip/rk3588/rk3588.c b/arch/arm/mach-rockchip/rk3588/rk3588.c
> index b1f535fad5..0c8f10a97c 100644
> --- a/arch/arm/mach-rockchip/rk3588/rk3588.c
> +++ b/arch/arm/mach-rockchip/rk3588/rk3588.c
> @@ -42,6 +42,7 @@ const char * const boot_devices[BROM_LAST_BOOTSOURCE + 1] = {
> [BROM_BOOTSOURCE_SPINOR] = "/spi@fe2b0000/flash@0",
> [BROM_BOOTSOURCE_SD] = "/mmc@fe2c0000",
> [BROM_BOOTSOURCE_SPINOR_RK3588] = "/spi@fe2b0000/flash@0",
> + [BROM_BOOTSOURCE_SPINAND] = "/spi@fe2b0000/flash@0",

This is not correct, please see [1] for an open discussion on this issue.

Kever: Do you have any more insights into the question on [1].

Is my assessment about the value BootRom writes to bootsource reg
correct, see [1]?

- FSPI (M0): 3
- FSPI (M1): 4
- FSPI (M2): 6

[1] https://lore.kernel.org/u-boot/b82c02c0-0a37-8553-f498-b03f85394d59@kwiboo.se/

Regards,
Jonas

> };
>
> static struct mm_region rk3588_mem_map[] = {