Re: [PATCH 2/2] configs: orangepi-5-plus-rk3588: Build SPI image by default

Slawomir Stepien
2023-10-31T17:36:18Z

On paź 31, 2023 17:49, Jonas Karlman wrote:
> On 2023-10-31 17:13, Slawomir Stepien wrote:
> > Flashing this image to the on-board flash is useful when you want to
> > start Linux from a medium (e.g. nvme) without flashing u-boot elements
> > to it.
> >
> > Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> > ---
> > configs/orangepi-5-plus-rk3588_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/configs/orangepi-5-plus-rk3588_defconfig b/configs/orangepi-5-plus-rk3588_defconfig
> > index 0473699621..9af65026a0 100644
> > --- a/configs/orangepi-5-plus-rk3588_defconfig
> > +++ b/configs/orangepi-5-plus-rk3588_defconfig
> > @@ -103,3 +103,4 @@ CONFIG_USB_OHCI_GENERIC=y
> > CONFIG_USB_DWC3=y
> > CONFIG_USB_DWC3_GENERIC=y
> > CONFIG_ERRNO_STR=y
> > +CONFIG_ROCKCHIP_SPI_IMAGE=y
>
> This was intentionally left out from original submission due to an
> unfinished discussion at [1].
>
> Also note that this option is not added at correct position in defconfig
> file. Next time, please re-sync defconfig changes with a make
> savedefconfig generated file.

Ah yes. I did forget about it. Sorry. I will regenerate it correctly...if there will be v2.

> [1] https://lore.kernel.org/u-boot/b82c02c0-0a37-8553-f498-b03f85394d59@kwiboo.se/
>
> Regards,
> Jonas

--
Slawomir Stepien