public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Xavier Drudis Ferran <xdrudis@tinet.cat>
To: Sean Anderson <seanga2@gmail.com>
Cc: "Tom Rini" <trini@konsulko.com>,
	u-boot@lists.denx.de, "Simon Glass" <sjg@chromium.org>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Marek Behún" <marek.behun@nic.cz>, "Marek Vasut" <marex@denx.de>,
	"Xavier Drudis Ferran" <xdrudis@tinet.cat>,
	"Stefan Roese" <sr@denx.de>, "Fabio Estevam" <festevam@gmail.com>,
	"Stefano Babic" <sbabic@denx.de>,
	uboot-imx@nxp.com
Subject: Re: [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes
Date: Mon, 6 Nov 2023 13:35:16 +0100	[thread overview]
Message-ID: <ZUjdhAccsYbJS6AL@xdrudis.tinet.cat> (raw)
In-Reply-To: <20231106022603.3405551-9-seanga2@gmail.com>

Thanks for your work. I'm still reading... but...


El Sun, Nov 05, 2023 at 09:25:46PM -0500, Sean Anderson deia:
> diff --git a/include/spl.h b/include/spl.h
> index 951e136b9ea..ecfc50e0095 100644
> --- a/include/spl.h
> +++ b/include/spl.h
> @@ -297,10 +297,10 @@ struct spl_load_info {
>  	 * read() - Read from device
>  	 *
>  	 * @load: Information about the load state
> -	 * @sector: Sector number to read from (each @load->bl_len bytes)
> -	 * @count: Number of sectors to read
> +	 * @offset: Offset to read from in bytes, in multiples of @load->bl_len
> +	 * @count: Number of bytes to read, in multiples of @load->bl_len

I'm no native English speaker, but would it be easier to understand? :

+	 * @offset: Offset to read from in bytes, a multiple of @load->bl_len
+	 * @count: Number of bytes to read, a multiple of @load->bl_len




  reply	other threads:[~2023-11-06 12:35 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-06  2:25 [PATCH v6 00/25] spl: Use common function for loading/parsing images Sean Anderson
2023-11-06  2:25 ` [PATCH v6 01/25] spl: blk_fs: Fix uninitialized return value when we can't get a blk_desc Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 02/25] arm: Disable SPL_FS_FAT when it isn't used Sean Anderson
2023-11-06  6:58   ` Michal Simek
2023-11-06  2:25 ` [PATCH v6 03/25] spl: Make SHOW_ERRORS depend on LIBCOMMON Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 04/25] spl: semihosting: Don't close fd before spl_load_simple_fit Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 05/25] spl: Remove NULL assignments in spl_load_info Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-08 15:30     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 06/25] spl: Remove dev from spl_load_info Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-08 16:19     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 07/25] spl: Take advantage of bl_len's power-of-twoness Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes Sean Anderson
2023-11-06 12:35   ` Xavier Drudis Ferran [this message]
2023-11-06 13:54     ` Sean Anderson
2023-11-07  8:49       ` Xavier Drudis Ferran
2023-11-08 15:59         ` Sean Anderson
2023-11-09  6:24           ` Xavier Drudis Ferran
2023-11-06  2:25 ` [PATCH v6 09/25] spl: Remove filename from spl_load_info Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-08 15:34     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 10/25] spl: Only support bl_len when we have to Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 11/25] spl: nand: Remove spl_nand_legacy_read Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 12/25] spl: legacy: Split off LZMA decompression into its own function Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 13/25] test: spl: Support testing LEGACY_LZMA filesystem images Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 14/25] spl: Add generic spl_load function Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 15/25] spl: Convert ext to use spl_load Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-08 15:37     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 16/25] spl: Convert fat to spl_load Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-08 15:49     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 17/25] spl: Convert mmc " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 18/25] spl: Convert nand " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 19/25] spl: Convert net " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 20/25] spl: Convert nor " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 21/25] spl: Convert NVMe " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:26 ` [PATCH v6 22/25] spl: Convert semihosting " Sean Anderson
2023-11-06  2:26 ` [PATCH v6 23/25] spl: Convert spi " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:26 ` [PATCH v6 24/25] spl: spi: Consolidate spi_load_image_os into spl_spi_load_image Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:26 ` [PATCH v6 25/25] spl: fat: Add option to disable DMA alignment Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  7:49 ` [PATCH v6 00/25] spl: Use common function for loading/parsing images Pali Rohár
2023-11-06  9:18   ` Heinrich Schuchardt
2023-11-06 10:12   ` Marek Behún

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZUjdhAccsYbJS6AL@xdrudis.tinet.cat \
    --to=xdrudis@tinet.cat \
    --cc=festevam@gmail.com \
    --cc=marek.behun@nic.cz \
    --cc=marex@denx.de \
    --cc=sbabic@denx.de \
    --cc=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox