From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60BB8C4167B for ; Mon, 6 Nov 2023 12:35:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4E29286E05; Mon, 6 Nov 2023 13:35:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tinet.cat Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 0021D86CF2; Mon, 6 Nov 2023 13:35:34 +0100 (CET) Received: from mx1.tinet.cat (mx1.dipta.cat [195.76.233.59]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F381386F9A for ; Mon, 6 Nov 2023 13:35:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tinet.cat Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xdrudis@tinet.cat X-ASG-Debug-ID: 1699274127-12aaf231aec43df0002-4l7tJC Received: from smtp01.tinet.cat (smtp.tinet.cat [195.77.216.131]) by mx1.tinet.cat with ESMTP id zqggNoNaViemuyjB; Mon, 06 Nov 2023 13:35:28 +0100 (CET) X-Barracuda-Envelope-From: xdrudis@tinet.cat X-Barracuda-Effective-Source-IP: smtp.tinet.cat[195.77.216.131] X-Barracuda-Apparent-Source-IP: 195.77.216.131 Received: from xdrudis.tinet.cat (191.red-79-152-186.dynamicip.rima-tde.net [79.152.186.191]) by smtp01.tinet.cat (Postfix) with ESMTPSA id 8FA7C605DE4C; Mon, 6 Nov 2023 13:35:28 +0100 (CET) Date: Mon, 6 Nov 2023 13:35:16 +0100 From: Xavier Drudis Ferran To: Sean Anderson Cc: Tom Rini , u-boot@lists.denx.de, Simon Glass , Heinrich Schuchardt , Marek =?utf-8?B?QmVow7pu?= , Marek Vasut , Xavier Drudis Ferran , Stefan Roese , Fabio Estevam , Stefano Babic , uboot-imx@nxp.com Subject: Re: [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes Message-ID: X-ASG-Orig-Subj: Re: [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes References: <20231106022603.3405551-1-seanga2@gmail.com> <20231106022603.3405551-9-seanga2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231106022603.3405551-9-seanga2@gmail.com> X-Barracuda-Connect: smtp.tinet.cat[195.77.216.131] X-Barracuda-Start-Time: 1699274128 X-Barracuda-URL: https://webmail.tinet.cat:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 872 X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.5038 1.0000 0.7500 X-Barracuda-Spam-Score: 0.75 X-Barracuda-Spam-Status: No, SCORE=0.75 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=6.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.116379 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Thanks for your work. I'm still reading... but... El Sun, Nov 05, 2023 at 09:25:46PM -0500, Sean Anderson deia: > diff --git a/include/spl.h b/include/spl.h > index 951e136b9ea..ecfc50e0095 100644 > --- a/include/spl.h > +++ b/include/spl.h > @@ -297,10 +297,10 @@ struct spl_load_info { > * read() - Read from device > * > * @load: Information about the load state > - * @sector: Sector number to read from (each @load->bl_len bytes) > - * @count: Number of sectors to read > + * @offset: Offset to read from in bytes, in multiples of @load->bl_len > + * @count: Number of bytes to read, in multiples of @load->bl_len I'm no native English speaker, but would it be easier to understand? : + * @offset: Offset to read from in bytes, a multiple of @load->bl_len + * @count: Number of bytes to read, a multiple of @load->bl_len