[PATCH 5/8] dm: test: Add a test for rollback driver

seanedmond
2023-09-12T09:48:48Z

From: Sean Edmond <seanedmond@microsoft.com>

Adds a test for a sandbox and TPM backed rollback driver.

Allows for testing of anti-rollback version number get/set API using the
rollback driver.

Signed-off-by: Sean Edmond <seanedmond@microsoft.com>
---
arch/sandbox/dts/test.dts | 9 +++++
configs/sandbox_defconfig | 3 ++
test/dm/Makefile | 1 +
test/dm/rollback.c | 78 +++++++++++++++++++++++++++++++++++++++
4 files changed, 91 insertions(+)
create mode 100644 test/dm/rollback.c

diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
index f351d5cb84..1226bad6a6 100644
--- a/arch/sandbox/dts/test.dts
+++ b/arch/sandbox/dts/test.dts
@@ -1263,6 +1263,10 @@
backlight = <&backlight 0 100>;
};

+ rollback@0 {
+ compatible = "sandbox,rollback";
+ };
+
scsi {
compatible = "sandbox,scsi";
sandbox,filepath = "scsi.img";
@@ -1376,6 +1380,11 @@

tpm2 {
compatible = "sandbox,tpm2";
+
+ rollback@1 {
+ compatible = "tpm,rollback";
+ rollback-nv-index = <0x1001007>;
+ };
};

tpm {
diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
index 1cd1c2ed7c..f2bd10fbf0 100644
--- a/configs/sandbox_defconfig
+++ b/configs/sandbox_defconfig
@@ -346,3 +346,6 @@ CONFIG_UNIT_TEST=y
CONFIG_UT_TIME=y
CONFIG_UT_DM=y
CONFIG_ARM_FFA_TRANSPORT=y
+CONFIG_DM_ROLLBACK=y
+CONFIG_ROLLBACK_SANDBOX=y
+CONFIG_ROLLBACK_TPM=y
diff --git a/test/dm/Makefile b/test/dm/Makefile
index 7ed00733c1..3875ec4f4b 100644
--- a/test/dm/Makefile
+++ b/test/dm/Makefile
@@ -104,6 +104,7 @@ obj-$(CONFIG_DM_RNG) += rng.o
obj-$(CONFIG_DM_RTC) += rtc.o
obj-$(CONFIG_SCMI_FIRMWARE) += scmi.o
obj-$(CONFIG_SCSI) += scsi.o
+obj-$(CONFIG_DM_ROLLBACK) += security.o
obj-$(CONFIG_DM_SERIAL) += serial.o
obj-$(CONFIG_DM_SPI_FLASH) += sf.o
obj-$(CONFIG_SIMPLE_BUS) += simple-bus.o
diff --git a/test/dm/rollback.c b/test/dm/rollback.c
new file mode 100644
index 0000000000..a2984797f9
--- /dev/null
+++ b/test/dm/rollback.c
@@ -0,0 +1,78 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2023 Microsoft Corporation
+ * Written by Sean Edmond <seanedmond@microsoft.com>
+ */
+
+#include <common.h>
+#include <dm.h>
+#include <rollback.h>
+#include <log.h>
+#include <dm/test.h>
+#include <test/test.h>
+#include <test/ut.h>
+
+/*
+ * get_rollback() - Get a rollback driver of a given driver name
+ *
+ * @devp: Returns the rollback device
+ * @driver_name: Driver name to find
+ * Returns: 0 if OK, -ENODEV if not found
+ */
+static int get_rollback(struct udevice **devp, char *driver_name)
+{
+ struct udevice *dev;
+
+ uclass_foreach_dev_probe(UCLASS_ROLLBACK, dev) {
+ if (strcmp(dev->driver->name, driver_name) == 0) {
+ *devp = dev;
+ return 0;
+ }
+ }
+
+ return -ENODEV;
+}
+
+/* Basic test of rollback driver Anti rollback version number read/write */
+static int test_rollback_idx(struct unit_test_state *uts, char *driver_name)
+{
+ struct udevice *dev;
+ u64 rollback_idx;
+
+ /* get the rollback driver */
+ ut_assertok(get_rollback(&dev, driver_name));
+
+ /* ensure initial value is 0 */
+ rollback_idx_get(dev, &rollback_idx);
+ ut_asserteq(0, rollback_idx);
+
+ /* write 1 and ensure it's read back */
+ rollback_idx_set(dev, 1);
+ rollback_idx_get(dev, &rollback_idx);
+ ut_asserteq(1, rollback_idx);
+
+ /* write all ones and ensure it's read back */
+ rollback_idx_set(dev, 0xffffffffffffffffULL);
+ rollback_idx_get(dev, &rollback_idx);
+ ut_asserteq(0xffffffffffffffffULL, rollback_idx);
+
+ return 0;
+}
+
+static int dm_test_rollback_sandbox(struct unit_test_state *uts)
+{
+ ut_assertok(test_rollback_idx(uts, "rollback_sandbox"));
+
+ return 0;
+}
+
+DM_TEST(dm_test_rollback_sandbox, UT_TESTF_SCAN_FDT);
+
+static int dm_test_rollback_tpm(struct unit_test_state *uts)
+{
+ ut_assertok(test_rollback_idx(uts, "rollback_tpm"));
+
+ return 0;
+}
+
+DM_TEST(dm_test_rollback_tpm, UT_TESTF_SCAN_FDT);
--
2.40.0