Re: [PATCH v3 08/12] dts: rockchip: rk356x: Prerelocate VOP in U-Boot proper

[Dang Huynh <danct12@riseup.net>]

On Sun, Apr 13, 2025 at 04:33:25PM +0200, Jonas Karlman wrote:
> Hi,
> 
> On 2025-04-12 16:27, Dang Huynh wrote:
> > We need to prerelocate VOP2 memory so the driver can work. This
> > will only support U-Boot proper.
> > 
> > Signed-off-by: Dang Huynh <danct12@riseup.net>
> > ---
> >  arch/arm/dts/rk356x-u-boot.dtsi | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/arm/dts/rk356x-u-boot.dtsi b/arch/arm/dts/rk356x-u-boot.dtsi
> > index 24a976cf7e21da351cbbb969ba2b4687c344ca6c..1191e2fd567dd18655c88ea1b7a28d160d43c220 100644
> > --- a/arch/arm/dts/rk356x-u-boot.dtsi
> > +++ b/arch/arm/dts/rk356x-u-boot.dtsi
> > @@ -166,6 +166,10 @@
> >  	clock-frequency = <24000000>;
> >  };
> >  
> > +&vop {
> > +	bootph-some-ram;
> > +};
> 
> This node should be sorted after &uart2m0_xfer to be in alphabetical
> order, and not put between &uart2 and &uart2m0_xfer. 
Whoops. I'll fix this in the next revision.
>
> On a related note, I do not understand why U-Boot must allocated its
> framebuffer in pre-reloc phase, but that may be something to change/fix
> in a different series.
> 
> Regards,
> Jonas
> 
> > +
> >  &uart2m0_xfer {
> >  	bootph-all;
> >  };
> > 
>