From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 813E1C369AB for ; Tue, 15 Apr 2025 13:29:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 12BF08056A; Tue, 15 Apr 2025 15:29:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=riseup.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=riseup.net header.i=@riseup.net header.b="NdYcoFkL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A954D829CF; Tue, 15 Apr 2025 15:29:38 +0200 (CEST) Received: from mx0.riseup.net (mx0.riseup.net [198.252.153.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9B20580107 for ; Tue, 15 Apr 2025 15:29:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=riseup.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=danct12@riseup.net Received: from fews01-sea.riseup.net (fews01-sea-pn.riseup.net [10.0.1.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx0.riseup.net (Postfix) with ESMTPS id 4ZcQ4F2NSwz9wKJ; Tue, 15 Apr 2025 13:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1744723773; bh=gBISVC/1AzO1ElNW8IrvV+nRShjV+3TC7UfK71KsyBw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NdYcoFkLLN+9bXYotai7WwLrLMcYUjh6p/FWDe+0sVSE6uQ4qKByRVbSUb5u18u6E cGxcAFEGnBeUcSSBxGupX/j2otl9aiaS02u+H6TOAGwjR++fD+M+su/4s+/U/YbG+0 Wac8TGTSQs0vJY7EZM5XVAYXaqoDgGiaOl/O30kc= X-Riseup-User-ID: 663AA7B50286B41CEA10FA58615D98469F9EA94C39CC35AFFD91656E7A386EA6 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews01-sea.riseup.net (Postfix) with ESMTPSA id 4ZcQ486f6KzJv3q; Tue, 15 Apr 2025 13:29:28 +0000 (UTC) Date: Tue, 15 Apr 2025 20:29:25 +0700 From: Dang Huynh To: Jonas Karlman Cc: Anatolij Gustschin , Simon Glass , Philipp Tomsich , Kever Yang , Tom Rini , Nicolas Frattaroli , Ondrej Jirman , Dragan Simic , Svyatoslav Ryhel , Lukasz Majewski , Sean Anderson , u-boot@lists.denx.de, Piotr Zalewski Subject: Re: [PATCH v3 11/12] configs: pinetab2-rk3566: Enable video and USB keyboard Message-ID: References: <20250412-vop2-pt2-v3-0-7c796db335e9@riseup.net> <20250412-vop2-pt2-v3-11-7c796db335e9@riseup.net> <6d852aca-dcc8-4098-9406-fc09738a205d@kwiboo.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d852aca-dcc8-4098-9406-fc09738a205d@kwiboo.se> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sun, Apr 13, 2025 at 05:26:03PM +0200, Jonas Karlman wrote: > Hi, > > On 2025-04-12 16:27, Dang Huynh wrote: > > Now that we have VOP2 support, let's enable it and support the > > built in USB keyboard. > > > > Signed-off-by: Dang Huynh > > --- > > configs/pinetab2-rk3566_defconfig | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/configs/pinetab2-rk3566_defconfig b/configs/pinetab2-rk3566_defconfig > > index 45e63b42d192dc172f24e071b09c8203675965d8..792ec0ec119437fd7a920558a149363c886c87de 100644 > > --- a/configs/pinetab2-rk3566_defconfig > > +++ b/configs/pinetab2-rk3566_defconfig > > @@ -57,6 +57,7 @@ CONFIG_BUTTON=y > > CONFIG_BUTTON_ADC=y > > CONFIG_BUTTON_GPIO=y > > CONFIG_SPL_CLK=y > > +CONFIG_CLK_CCF=y > > Rockchip clk drivers does not use this, and I do not see any new clock > driver being added in this series. > > Why is this needed? I initially added this to get around clk_enable error, but it seems like you don't need to enable VOP clocks. However, I noticed that enabling CCF will give us clock rate that are pretty close to how it's configured on Linux. > > Regards, > Jonas > > > # CONFIG_USB_FUNCTION_FASTBOOT is not set > > CONFIG_ROCKCHIP_GPIO=y > > CONFIG_SYS_I2C_ROCKCHIP=y > > @@ -69,6 +70,7 @@ CONFIG_MMC_SDHCI_SDMA=y > > CONFIG_MMC_SDHCI_ROCKCHIP=y > > CONFIG_SPI_FLASH_SFDP_SUPPORT=y > > CONFIG_SPI_FLASH_SILICONKAISER=y > > +CONFIG_PHY_ROCKCHIP_INNO_DSIDPHY=y > > CONFIG_PHY_ROCKCHIP_INNO_USB2=y > > CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y > > CONFIG_SPL_PINCTRL=y > > @@ -94,6 +96,7 @@ CONFIG_USB_OHCI_HCD=y > > CONFIG_USB_OHCI_GENERIC=y > > CONFIG_USB_DWC3=y > > CONFIG_USB_DWC3_GENERIC=y > > +CONFIG_USB_KEYBOARD=y > > CONFIG_USB_HOST_ETHER=y > > CONFIG_USB_ETHER_ASIX=y > > CONFIG_USB_ETHER_ASIX88179=y > > @@ -101,4 +104,12 @@ CONFIG_USB_ETHER_RTL8152=y > > CONFIG_USB_GADGET=y > > CONFIG_USB_GADGET_DOWNLOAD=y > > CONFIG_USB_FUNCTION_ROCKUSB=y > > +CONFIG_VIDEO=y > > +CONFIG_VIDEO_LCD_BOE_TH101MB31IG002_28A=y > > +CONFIG_DISPLAY=y > > +CONFIG_VIDEO_ROCKCHIP=y > > +CONFIG_DISPLAY_ROCKCHIP_HDMI=y > > +CONFIG_DISPLAY_ROCKCHIP_DW_MIPI=y > > +CONFIG_VIDEO_BRIDGE=y > > +CONFIG_VIDEO_REMOVE=y > > CONFIG_ERRNO_STR=y > > >