From: Stephan Gerhold <stephan.gerhold@linaro.org>
To: Sam Day <me@samcday.com>
Cc: Lukasz Majewski <lukma@denx.de>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Marek Vasut <marex@denx.de>, Tom Rini <trini@konsulko.com>,
Caleb Connolly <caleb.connolly@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Sumit Garg <sumit.garg@kernel.org>,
u-boot@lists.denx.de, u-boot-qcom@groups.io
Subject: Re: [PATCH 2/3] usb: host: ehci-msm: Register ChipIdea UDC from glue wrapper
Date: Wed, 16 Apr 2025 20:57:00 +0200 [thread overview]
Message-ID: <Z__9fHFbNoAojR4Q@linaro.org> (raw)
In-Reply-To: <20250412-msm8916-usb-v1-2-2925239caf4b@samcday.com>
On Sat, Apr 12, 2025 at 07:40:03PM +0000, Sam Day wrote:
> When CONFIG_DM_USB_GADGET is enabled, the CI UDC driver needs to be
> explicitly bound. So we do this from the newly introduced glue driver.
>
> Signed-off-by: Sam Day <me@samcday.com>
> ---
> drivers/usb/host/ehci-msm.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c
> index 8aeb6a915563453ad2a02721d4828fd1b300a4e4..ae40e96e6349b1a352608e6350ce950a3cff95af 100644
> --- a/drivers/usb/host/ehci-msm.c
> +++ b/drivers/usb/host/ehci-msm.c
> @@ -161,6 +161,13 @@ static int qcom_ci_hdrc_bind(struct udevice *dev)
> if (ret)
> return ret;
>
> + if (IS_ENABLED(CONFIG_DM_USB_GADGET) && IS_ENABLED(CONFIG_CI_UDC)) {
> + ret = device_bind_driver_to_node(dev, "ci-udc", "ci-udc",
> + dev_ofnode(dev), NULL);
Nitpick: Indentation looks off here (we usually align with the open
parenthesis (
Thanks,
Stephan
next prev parent reply other threads:[~2025-04-16 18:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-12 19:39 [PATCH 0/3] Support MSM8916 USB PHY + UDC in qcom_defconfig Sam Day
2025-04-12 19:39 ` [PATCH 1/3] usb: udc: ci: support USB gadget driver model Sam Day
2025-04-16 18:51 ` Stephan Gerhold
2025-04-19 9:32 ` Sam Day
2025-06-04 7:07 ` Wojciech Dubowik
2025-04-12 19:40 ` [PATCH 2/3] usb: host: ehci-msm: Register ChipIdea UDC from glue wrapper Sam Day
2025-04-16 18:57 ` Stephan Gerhold [this message]
2025-04-12 19:40 ` [PATCH 3/3] qcom_defconfig: Enable MSM8916 USB PHY + ChipIdea UDC Sam Day
2025-04-16 19:03 ` Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z__9fHFbNoAojR4Q@linaro.org \
--to=stephan.gerhold@linaro.org \
--cc=caleb.connolly@linaro.org \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=me@samcday.com \
--cc=mkorpershoek@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sumit.garg@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox