Re: [PATCH v4 2/4] efi_loader: rename BOOTEFI_BOOTMGR to EFI_BOOTMGR

[AKASHI Takahiro <takahiro.akashi@linaro.org>]

On Mon, Jan 15, 2024 at 03:16:22PM +0100, Heinrich Schuchardt wrote:
> On 15.01.24 11:12, AKASHI Takahiro wrote:
> > On Mon, Jan 15, 2024 at 09:34:51AM +0100, Heinrich Schuchardt wrote:
> > > On 1/15/24 01:58, AKASHI Takahiro wrote:
> > > > On Sun, Jan 14, 2024 at 01:46:45PM +0100, Heinrich Schuchardt wrote:
> > > > > On 1/10/24 02:16, AKASHI Takahiro wrote:
> > > > > > At this point, EFI boot manager interfaces is fully independent from
> > > > > > bootefi command. So just rename the configuration parameter.
> > > > > > 
> > > > > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > > > > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > > > 
> > > > > This patch breaks the 'bootefi hello' command in
> > > > > qemu-riscv64_smode_defconfig and other QEMU defconfigs.
> > > > 
> > > > What happened? Please elaborate details so that I can trace your issue.
> > > > 
> > > > On my side, I didn't see any problem with "bootefi hello" on qemu-arm64
> > > > and moreover CI check (github pull request) didn't complain anything.
> > > 
> > > The failures are logged in
> > > https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/19302
> > 
> > In the logs for qemu-arm64, qemu-risc64 and maybe others as well,
> > I see the same error:
> > --- ---
> > ______________________________ test_efi_grub_net _______________________________
> > test/py/tests/test_efi_loader.py:188: in test_efi_grub_net
> >      addr = fetch_tftp_file(u_boot_console, 'env__efi_loader_grub_file')
> > test/py/tests/test_efi_loader.py:136: in fetch_tftp_file
> >      assert expected_text in output
> > E   assert 'Bytes transferred = 520192' in "*** ERROR: `serverip' not set"
> > --- ---
> > 
> > This seems to be the root cause and my commit will have nothing to do
> > with the problem.
> > Please check the test environment.
> 
> You are looking at test_efi_grub_net. I referred to 'bootefi hello',
> i.e. test_efi_helloworld_builtin:
> 
> 
> ----------------------------- Captured stdout call
> -----------------------------
> => bootefi hello
> 
> =>
> 
> 
> The command does not provide any output.

Ah, yeah, but

> Best regards
> 
> Heinrich
> 
> 
> > 
> > -Takahiro Akashi
> > 
> > > I have pushed the tag failed_20240114 to
> > > https://source.denx.de/u-boot/custodians/u-boot-efi.git for analysis.

While I compiled this code and tried to run "bootefi hello",
I could not reproduce this issue, always seeing the right output
either on qemu-arm64 or sandbox64.
(I also invoked test_efi_loader/efi_helloworld_builtin locally,
but the test passed.)
So no clue.

-Takahiro Akashi


> > > Best regards
> > > 
> > > Heinrich
>