From: Matthias Brugger <matthias.bgg@kernel.org>
To: Weizhao Ouyang <o451686892@gmail.com>
Cc: Sughosh Ganu <sughosh.ganu@linaro.org>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Tom Rini <trini@konsulko.com>,
Etienne Carriere <etienne.carriere@foss.st.com>,
Simon Glass <sjg@chromium.org>, Peng Fan <peng.fan@nxp.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jens Wiklander <jens.wiklander@linaro.org>,
Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH v3 2/3] driver: rng: Fix SMCCC TRNG crash
Date: Wed, 31 Jan 2024 18:04:29 +0100 [thread overview]
Message-ID: <Zbp9ncssh-Fu9-ef@ziggy.stardust> (raw)
In-Reply-To: <20240131141426.34926-3-o451686892@gmail.com>
On Wed, Jan 31, 2024 at 02:14:25PM +0000, Weizhao Ouyang wrote:
> Fix a SMCCC TRNG null pointer crash due to a failed smccc feature
> binding.
>
> Fixes: 53355bb86c25 ("drivers: rng: add smccc trng driver")
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Signed-off-by: Weizhao Ouyang <o451686892@gmail.com>
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
> ---
> v3: add Fixes tag
> ---
> drivers/rng/smccc_trng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rng/smccc_trng.c b/drivers/rng/smccc_trng.c
> index 3a4bb33941..3087cb991a 100644
> --- a/drivers/rng/smccc_trng.c
> +++ b/drivers/rng/smccc_trng.c
> @@ -166,7 +166,7 @@ static int smccc_trng_probe(struct udevice *dev)
> struct smccc_trng_priv *priv = dev_get_priv(dev);
> struct arm_smccc_res res;
>
> - if (!(smccc_trng_is_supported(smccc->invoke_fn)))
> + if (!smccc || !(smccc_trng_is_supported(smccc->invoke_fn)))
> return -ENODEV;
>
> /* At least one of 64bit and 32bit interfaces is available */
> --
> 2.39.2
next prev parent reply other threads:[~2024-01-31 17:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 14:14 [PATCH v3 0/3] Random Number Generator fixes Weizhao Ouyang
2024-01-31 14:14 ` [PATCH v3 1/3] firmware: psci: Fix bind_smccc_features psci check Weizhao Ouyang
2024-02-01 11:40 ` Abdellatif El Khlifi
2024-02-02 3:40 ` Weizhao Ouyang
2024-02-01 14:36 ` Igor Opaniuk
2024-02-02 3:42 ` Weizhao Ouyang
2024-02-02 21:18 ` Igor Opaniuk
2024-01-31 14:14 ` [PATCH v3 2/3] driver: rng: Fix SMCCC TRNG crash Weizhao Ouyang
2024-01-31 17:04 ` Matthias Brugger [this message]
2024-01-31 14:14 ` [PATCH v3 3/3] cmd: rng: Add rng list command Weizhao Ouyang
2024-01-31 17:06 ` Matthias Brugger
2024-02-01 14:32 ` Igor Opaniuk
2024-02-05 18:14 ` Tom Rini
2024-02-06 8:24 ` Weizhao Ouyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbp9ncssh-Fu9-ef@ziggy.stardust \
--to=matthias.bgg@kernel.org \
--cc=abdellatif.elkhlifi@arm.com \
--cc=etienne.carriere@foss.st.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jens.wiklander@linaro.org \
--cc=o451686892@gmail.com \
--cc=peng.fan@nxp.com \
--cc=sjg@chromium.org \
--cc=sughosh.ganu@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox