Re: [PATCH v3 4/6] usb: Add environment based device ignorelist

[Janne Grunau <j@jannau.net>]

On Fri, Mar 22, 2024 at 12:56:37PM +0100, Marek Vasut wrote:
> On 3/22/24 8:47 AM, Janne Grunau via B4 Relay wrote:
> 
> [...]
> 
> > @@ -1099,6 +1142,20 @@ int usb_select_config(struct usb_device *dev)
> >   	le16_to_cpus(&dev->descriptor.idProduct);
> >   	le16_to_cpus(&dev->descriptor.bcdDevice);
> >   
> > +	/* ignore devices from usb_ignorelist */
> > +	err = usb_device_is_ignored(dev->descriptor.idVendor,
> > +				    dev->descriptor.idProduct);
> > +	if (err == -ENODEV) {
> > +		dev_dbg(dev->dev, "Ignoring USB device 0x%x:0x%x\n",
> > +			dev->descriptor.idVendor, dev->descriptor.idProduct);
> > +		return err;
> > +	} else if (err == -EINVAL) {
> > +		printf("usb_ignorelist parse error in \"%s\"\n",
> > +		       env_get("usb_ignorelist"));
> 
> Please use dev_err() here consistently with dev_dbg() above.

I didn't use dev_err() since the parsing error is not specific to the
device. It doesn't matter much. I'll change it and resend after we've
settled the new discussion about the interface limit.

> With that fixed:
> 
> Reviewed-by: Marek Vasut <marex@denx.de>

thanks,

Janne