From: Leo Liang <ycliang@andestech.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Minda Chen <minda.chen@starfivetech.com>,
Rick Chen <rick@andestech.com>,
Lukasz Tekieli <tekieli.lukasz@gmail.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Chanho Park <chanho61.park@samsung.com>,
Shiji Yang <yangshiji66@outlook.com>,
Shengyu Qu <wiagn233@outlook.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
E Shattow <lucent@gmail.com>, <u-boot@lists.denx.de>
Subject: Re: [PATCH v2 1/6] riscv: do not set default fdt for VisionFive 2
Date: Wed, 27 Mar 2024 17:01:04 +0800 [thread overview]
Message-ID: <ZgPgUGtuuKpbHLBT@swlinux02> (raw)
In-Reply-To: <20240321181149.177356-2-heinrich.schuchardt@canonical.com>
On Thu, Mar 21, 2024 at 07:11:44PM +0100, Heinrich Schuchardt wrote:
> Currently in set_fdtfile() we set the value of environment variable fdtfile
> unconditionally. The implies that a value in the environment will be
> ignored.
>
> With the patch environment variable fdtfile will only be set if it does not
> yet exist. This requires that CONFIG_DEFAULT_FDT_FILE is not set.
>
> Now the user can either set and save fdtfile interactively or in the U-Boot
> configuration to overrule the device-tree name chosen based on the
> hardware in set_fdtfile().
>
> Reported-by: E Shattow <lucent@gmail.com>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> v2:
> new patch
> ---
> .../visionfive2/starfive_visionfive2.c | 4 ++++
> configs/starfive_visionfive2_defconfig | 1 -
> doc/board/starfive/visionfive2.rst | 18 ++++++++++++++++++
> 3 files changed, 22 insertions(+), 1 deletion(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
next prev parent reply other threads:[~2024-03-27 9:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 18:11 [PATCH v2 0/6] riscv: add support for Milk-V Mars board Heinrich Schuchardt
2024-03-21 18:11 ` [PATCH v2 1/6] riscv: do not set default fdt for VisionFive 2 Heinrich Schuchardt
2024-03-27 9:01 ` Leo Liang [this message]
2024-03-21 18:11 ` [PATCH v2 2/6] eeprom: starfive: function get_product_id_from_eeprom() Heinrich Schuchardt
2024-03-27 9:13 ` Leo Liang
2024-03-21 18:11 ` [PATCH v2 3/6] riscv: set fdtfile on Milk-V Mars Heinrich Schuchardt
2024-03-28 3:35 ` Leo Liang
2024-03-21 18:11 ` [PATCH v2 4/6] board: starfive: support Milk-V Mars board Heinrich Schuchardt
2024-03-24 15:00 ` Aurelien Jarno
2024-03-27 11:03 ` Heinrich Schuchardt
2024-03-28 6:24 ` Leo Liang
2024-03-28 16:01 ` Heinrich Schuchardt
2024-04-01 15:28 ` Aurelien Jarno
2024-04-01 15:54 ` Heinrich Schuchardt
2024-04-02 1:19 ` Minda Chen
2024-03-28 5:24 ` Leo Liang
2024-03-21 18:11 ` [PATCH v2 5/6] riscv: starfive: avoid including common.h Heinrich Schuchardt
2024-03-28 3:09 ` Leo Liang
2024-03-21 18:11 ` [PATCH v2 6/6] doc: describe Milk-V Mars board Heinrich Schuchardt
2024-03-25 3:10 ` 回复: [PATCH v2 0/6] riscv: add support for " Minda Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgPgUGtuuKpbHLBT@swlinux02 \
--to=ycliang@andestech.com \
--cc=aurelien@aurel32.net \
--cc=chanho61.park@samsung.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=lucent@gmail.com \
--cc=minda.chen@starfivetech.com \
--cc=rick@andestech.com \
--cc=sw0312.kim@samsung.com \
--cc=tekieli.lukasz@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=wiagn233@outlook.com \
--cc=yangshiji66@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox