From: Leo Liang <ycliang@andestech.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Minda Chen <minda.chen@starfivetech.com>,
Hal Feng <hal.feng@starfivetech.com>,
Rick Chen <rick@andestech.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Lukasz Tekieli <tekieli.lukasz@gmail.com>,
Shiji Yang <yangshiji66@outlook.com>,
Shengyu Qu <wiagn233@outlook.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
E Shattow <lucent@gmail.com>, <u-boot@lists.denx.de>
Subject: Re: [PATCH v3 1/6] riscv: do not set default fdt for VisionFive 2
Date: Mon, 8 Apr 2024 18:10:06 +0800 [thread overview]
Message-ID: <ZhPCfs3-q8Ury5p2@swlinux02> (raw)
In-Reply-To: <20240402084912.43228-2-heinrich.schuchardt@canonical.com>
On Tue, Apr 02, 2024 at 10:49:07AM +0200, Heinrich Schuchardt wrote:
> Currently in set_fdtfile() we set the value of environment variable fdtfile
> unconditionally. The implies that a value in the environment will be
> ignored.
>
> With the patch environment variable fdtfile will only be set if it does not
> yet exist. This requires that CONFIG_DEFAULT_FDT_FILE is not set.
>
> Now the user can either set and save fdtfile interactively or in the U-Boot
> configuration to overrule the device-tree name chosen based on the
> hardware in set_fdtfile().
>
> Reported-by: E Shattow <lucent@gmail.com>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> v3:
> Rephrase last added sentence in doc/board/starfive/visionfive2.rst
> v2:
> new patch
> ---
> .../visionfive2/starfive_visionfive2.c | 4 ++++
> configs/starfive_visionfive2_defconfig | 1 -
> doc/board/starfive/visionfive2.rst | 18 ++++++++++++++++++
> 3 files changed, 22 insertions(+), 1 deletion(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
next prev parent reply other threads:[~2024-04-08 10:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 8:49 [PATCH v3 0/6] riscv: add support for Milk-V Mars board Heinrich Schuchardt
2024-04-02 8:49 ` [PATCH v3 1/6] riscv: do not set default fdt for VisionFive 2 Heinrich Schuchardt
2024-04-08 10:10 ` Leo Liang [this message]
2024-04-02 8:49 ` [PATCH v3 2/6] eeprom: starfive: function get_product_id_from_eeprom() Heinrich Schuchardt
2024-04-02 8:49 ` [PATCH v3 3/6] riscv: set fdtfile on Milk-V Mars Heinrich Schuchardt
2024-04-02 8:49 ` [PATCH v3 4/6] board: starfive: support Milk-V Mars board Heinrich Schuchardt
2024-04-08 10:44 ` Leo Liang
2024-04-02 8:49 ` [PATCH v3 5/6] riscv: starfive: avoid including common.h Heinrich Schuchardt
2024-04-02 8:49 ` [PATCH v3 6/6] doc: describe Milk-V Mars board Heinrich Schuchardt
2024-04-08 10:34 ` Leo Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhPCfs3-q8Ury5p2@swlinux02 \
--to=ycliang@andestech.com \
--cc=aurelien@aurel32.net \
--cc=hal.feng@starfivetech.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=lucent@gmail.com \
--cc=minda.chen@starfivetech.com \
--cc=rick@andestech.com \
--cc=sw0312.kim@samsung.com \
--cc=tekieli.lukasz@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=wiagn233@outlook.com \
--cc=yangshiji66@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox