From: Leo Liang <ycliang@andestech.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Minda Chen <minda.chen@starfivetech.com>,
Hal Feng <hal.feng@starfivetech.com>,
Rick Chen <rick@andestech.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Lukasz Tekieli <tekieli.lukasz@gmail.com>,
Shiji Yang <yangshiji66@outlook.com>,
Shengyu Qu <wiagn233@outlook.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
E Shattow <lucent@gmail.com>, <u-boot@lists.denx.de>
Subject: Re: [PATCH v3 4/6] board: starfive: support Milk-V Mars board
Date: Mon, 8 Apr 2024 18:44:28 +0800 [thread overview]
Message-ID: <ZhPKjBZsCPTKgH09@swlinux02> (raw)
In-Reply-To: <20240402084912.43228-5-heinrich.schuchardt@canonical.com>
On Tue, Apr 02, 2024 at 10:49:10AM +0200, Heinrich Schuchardt wrote:
> The differences between the Milk-V Mars board and the VisionFive 2 board
> are small enough that we can support both using the same U-Boot build.
>
> * The model and compatible property are taken from proposed Linux patches.
> * The EEPROM is atmel,24c02 according to the vendor U-Boot.
> * The second Ethernet port is not available.
>
> usb@10100000 does not exist in U-Boot yet. So we don't have to reflect
> differences in usage here.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> For the mmc card-detect a separate patch has been created:
> https://lore.kernel.org/u-boot/20240328214615.21501-1-heinrich.schuchardt@canonical.com/
>
> v3:
> Replace misplaced starfive_verb[i] by milk_v_mars[i].
> v2:
> do not overwrite /soc/i2c@12050000/eeprom@50/compatible
> ---
> board/starfive/visionfive2/spl.c | 99 ++++++++++++++++++++++++++++----
> 1 file changed, 87 insertions(+), 12 deletions(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
next prev parent reply other threads:[~2024-04-08 10:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 8:49 [PATCH v3 0/6] riscv: add support for Milk-V Mars board Heinrich Schuchardt
2024-04-02 8:49 ` [PATCH v3 1/6] riscv: do not set default fdt for VisionFive 2 Heinrich Schuchardt
2024-04-08 10:10 ` Leo Liang
2024-04-02 8:49 ` [PATCH v3 2/6] eeprom: starfive: function get_product_id_from_eeprom() Heinrich Schuchardt
2024-04-02 8:49 ` [PATCH v3 3/6] riscv: set fdtfile on Milk-V Mars Heinrich Schuchardt
2024-04-02 8:49 ` [PATCH v3 4/6] board: starfive: support Milk-V Mars board Heinrich Schuchardt
2024-04-08 10:44 ` Leo Liang [this message]
2024-04-02 8:49 ` [PATCH v3 5/6] riscv: starfive: avoid including common.h Heinrich Schuchardt
2024-04-02 8:49 ` [PATCH v3 6/6] doc: describe Milk-V Mars board Heinrich Schuchardt
2024-04-08 10:34 ` Leo Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhPKjBZsCPTKgH09@swlinux02 \
--to=ycliang@andestech.com \
--cc=aurelien@aurel32.net \
--cc=hal.feng@starfivetech.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=lucent@gmail.com \
--cc=minda.chen@starfivetech.com \
--cc=rick@andestech.com \
--cc=sw0312.kim@samsung.com \
--cc=tekieli.lukasz@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=wiagn233@outlook.com \
--cc=yangshiji66@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox