From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE37DC67861 for ; Mon, 8 Apr 2024 10:45:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 22ADE87EA9; Mon, 8 Apr 2024 12:45:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 0B3078800C; Mon, 8 Apr 2024 12:45:05 +0200 (CEST) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AE0CB87DCA for ; Mon, 8 Apr 2024 12:45:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 438AiZeO083642; Mon, 8 Apr 2024 18:44:35 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from swlinux02 (10.0.15.183) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Mon, 8 Apr 2024 18:44:31 +0800 Date: Mon, 8 Apr 2024 18:44:28 +0800 From: Leo Liang To: Heinrich Schuchardt CC: Minda Chen , Hal Feng , Rick Chen , Aurelien Jarno , Lukasz Tekieli , Shiji Yang , Shengyu Qu , Seung-Woo Kim , E Shattow , Subject: Re: [PATCH v3 4/6] board: starfive: support Milk-V Mars board Message-ID: References: <20240402084912.43228-1-heinrich.schuchardt@canonical.com> <20240402084912.43228-5-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240402084912.43228-5-heinrich.schuchardt@canonical.com> User-Agent: Mutt/2.2.10 (e0e92c31) (2023-03-25) X-Originating-IP: [10.0.15.183] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 438AiZeO083642 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Tue, Apr 02, 2024 at 10:49:10AM +0200, Heinrich Schuchardt wrote: > The differences between the Milk-V Mars board and the VisionFive 2 board > are small enough that we can support both using the same U-Boot build. > > * The model and compatible property are taken from proposed Linux patches. > * The EEPROM is atmel,24c02 according to the vendor U-Boot. > * The second Ethernet port is not available. > > usb@10100000 does not exist in U-Boot yet. So we don't have to reflect > differences in usage here. > > Signed-off-by: Heinrich Schuchardt > --- > For the mmc card-detect a separate patch has been created: > https://lore.kernel.org/u-boot/20240328214615.21501-1-heinrich.schuchardt@canonical.com/ > > v3: > Replace misplaced starfive_verb[i] by milk_v_mars[i]. > v2: > do not overwrite /soc/i2c@12050000/eeprom@50/compatible > --- > board/starfive/visionfive2/spl.c | 99 ++++++++++++++++++++++++++++---- > 1 file changed, 87 insertions(+), 12 deletions(-) Reviewed-by: Leo Yu-Chi Liang