From: Leo Liang <ycliang@andestech.com>
To: <lukas.funke-oss@weidmueller.com>
Cc: <u-boot@lists.denx.de>, E Shattow <lucent@gmail.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Lukas Funke <lukas.funke@weidmueller.com>,
Anup Patel <anup@brainfault.org>,
Atish Patra <atishp@atishpatra.org>,
Green Wan <green.wan@sifive.com>,
Nylon Chen <nylon.chen@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Tom Rini <trini@konsulko.com>,
Vincent Chen <vincent.chen@sifive.com>,
Zong Li <zong.li@sifve.com>
Subject: Re: [PATCH v3 1/2] board: sifive: Rename spl_soc_init() to spl_dram_init()
Date: Fri, 26 Apr 2024 15:51:49 +0800 [thread overview]
Message-ID: <ZitdFfUfBRHb5tNL@swlinux02> (raw)
In-Reply-To: <20240424074339.210851-2-lukas.funke-oss@weidmueller.com>
On Wed, Apr 24, 2024 at 09:43:38AM +0200, lukas.funke-oss@weidmueller.com wrote:
> From: Lukas Funke <lukas.funke@weidmueller.com>
>
> Rename spl_soc_init() to spl_dram_init() because the generic function
> name does not reflect what the function actually does. Also
> spl_dram_init() is commonly used for dram initialization and should be
> called from board_init_f().
>
> Signed-off-by: Lukas Funke <lukas.funke@weidmueller.com>
> ---
>
> (no changes since v1)
>
> arch/riscv/cpu/fu540/spl.c | 2 +-
> arch/riscv/cpu/fu740/spl.c | 2 +-
> arch/riscv/include/asm/arch-fu540/spl.h | 2 +-
> arch/riscv/include/asm/arch-fu740/spl.h | 2 +-
> board/sifive/unleashed/spl.c | 4 ++--
> board/sifive/unmatched/spl.c | 4 ++--
> 6 files changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
next prev parent reply other threads:[~2024-04-26 7:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 7:43 [PATCH v3 0/2] riscv: Rename spl_soc_init() to spl_dram_init() lukas.funke-oss
2024-04-24 7:43 ` [PATCH v3 1/2] board: sifive: " lukas.funke-oss
2024-04-26 7:51 ` Leo Liang [this message]
2024-04-24 7:43 ` [PATCH v3 2/2] board: starfive: " lukas.funke-oss
2024-04-24 11:01 ` Heinrich Schuchardt
2024-05-02 6:06 ` Lukas Funke
2024-05-02 6:33 ` Leo Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZitdFfUfBRHb5tNL@swlinux02 \
--to=ycliang@andestech.com \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=green.wan@sifive.com \
--cc=lucent@gmail.com \
--cc=lukas.funke-oss@weidmueller.com \
--cc=lukas.funke@weidmueller.com \
--cc=nylon.chen@sifive.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vincent.chen@sifive.com \
--cc=xypron.glpk@gmx.de \
--cc=zong.li@sifve.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox