Re: [PATCH 09/11] board: sniper: convert to DM_I2C

[Paul Kocialkowski <paulk@sys-base.io>]

[-- Attachment #1: Type: text/plain, Size: 2310 bytes --]

Hi,

Le Sat 03 Aug 24, 18:15, Anatolij Gustschin a écrit :
> Conversion to DM_I2C is mandatory, enable DM_I2C
> to disable board removal warning. Also enable
> OF_UPSTREAM since we do not have a default device
> tree.

Thanks for looking into this, but I already submitted a similar patch just
a few days ago, with additional cleanups!

See https://patchwork.ozlabs.org/project/uboot/patch/20240729204439.429900-3-paulk@sys-base.io/

Cheers,

Paul

> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
> Cc: Paul Kocialkowski <contact@paulk.fr>
> Cc: Tom Rini <trini@konsulko.com>
> ---
>  arch/arm/mach-omap2/omap3/Kconfig | 1 +
>  configs/sniper_defconfig          | 6 ++++--
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap3/Kconfig b/arch/arm/mach-omap2/omap3/Kconfig
> index f15f44fe7d..b56e379ca1 100644
> --- a/arch/arm/mach-omap2/omap3/Kconfig
> +++ b/arch/arm/mach-omap2/omap3/Kconfig
> @@ -115,6 +115,7 @@ config TARGET_SNIPER
>  	select OMAP3_GPIO_5
>  	select OMAP3_GPIO_6
>  	imply CMD_DM
> +	imply OF_UPSTREAM
>  
>  endchoice
>  
> diff --git a/configs/sniper_defconfig b/configs/sniper_defconfig
> index 0243b15f31..29e783da8a 100644
> --- a/configs/sniper_defconfig
> +++ b/configs/sniper_defconfig
> @@ -7,6 +7,7 @@ CONFIG_SYS_MALLOC_F_LEN=0x400
>  CONFIG_NR_DRAM_BANKS=2
>  CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
>  CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x4020ff00
> +CONFIG_DEFAULT_DEVICE_TREE="ti/omap/omap3-sniper"
>  CONFIG_SPL_TEXT_BASE=0x40200000
>  CONFIG_TARGET_SNIPER=y
>  CONFIG_SPL_STACK=0x4020fffc
> @@ -32,12 +33,13 @@ CONFIG_CMD_GPIO=y
>  CONFIG_CMD_I2C=y
>  CONFIG_CMD_MMC=y
>  # CONFIG_CMD_SETEXPR is not set
> +CONFIG_OF_CONTROL=y
>  CONFIG_ENV_OVERWRITE=y
>  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_SYS_I2C_LEGACY=y
> +# CONFIG_TI_SYSC is not set
> +CONFIG_DM_I2C=y
>  CONFIG_SPL_SYS_I2C_LEGACY=y
>  CONFIG_SYS_I2C_SPEED=400000
>  CONFIG_TWL4030_INPUT=y
>  CONFIG_MMC_OMAP_HS=y
>  CONFIG_CONS_INDEX=3
> -CONFIG_OF_LIBFDT=y
> -- 
> 2.25.1
> 

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expertise in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]