From: Leo Liang <ycliang@andestech.com>
To: Jacky Chou <jacky_chou@aspeedtech.com>
Cc: <ryan_chen@aspeedtech.com>, <chiawei_wang@aspeedtech.com>,
<BMC-SW@aspeedtech.com>, <joel@jms.id.au>,
<joe.hershberger@ni.com>, <rfried.dev@gmail.com>,
<trini@konsulko.com>, <sjg@chromium.org>, <kobedylan@gmail.com>,
<u-boot@lists.denx.de>
Subject: Re: [PATCH] net: ftgmac100: Modify desc. size to cache line
Date: Mon, 9 Sep 2024 15:50:05 +0800 [thread overview]
Message-ID: <Zt6orSTxXoTh4-AS@swlinux02> (raw)
In-Reply-To: <20240628093850.3063206-1-jacky_chou@aspeedtech.com>
On Fri, Jun 28, 2024 at 05:38:50PM +0800, Jacky Chou wrote:
> The TX/RX descriptor size is 16 byte.
> When the cache line size is larger than 16 bytes, descriptors
> flushed to RAM will flush more than one descriptor.
> It is possible that it may mistakenly flush to other descriptor
> that has been updated by MAC in RAM.
>
> To avoid this issue, align the descriptors to cache line size.
> Only one desc will be flushed or invalidated at a time.
>
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
> drivers/net/ftgmac100.c | 13 ++++++++++++-
> drivers/net/ftgmac100.h | 5 +++--
> 2 files changed, 15 insertions(+), 3 deletions(-)
Acked-by: Leo Yu-Chi Liang <ycliang@andestech.com>
prev parent reply other threads:[~2024-09-09 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 9:38 [PATCH] net: ftgmac100: Modify desc. size to cache line Jacky Chou
2024-09-09 7:50 ` Leo Liang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zt6orSTxXoTh4-AS@swlinux02 \
--to=ycliang@andestech.com \
--cc=BMC-SW@aspeedtech.com \
--cc=chiawei_wang@aspeedtech.com \
--cc=jacky_chou@aspeedtech.com \
--cc=joe.hershberger@ni.com \
--cc=joel@jms.id.au \
--cc=kobedylan@gmail.com \
--cc=rfried.dev@gmail.com \
--cc=ryan_chen@aspeedtech.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox