From: Leo Liang <ycliang@andestech.com>
To: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
Cc: <rick@andestech.com>, <trini@konsulko.com>,
<ryan_chen@aspeedtech.com>, <joel@jms.id.au>,
<u-boot@lists.denx.de>
Subject: Re: [PATCH 4/8] riscv: Add AST2700 SoC initial platform support
Date: Mon, 9 Sep 2024 20:17:15 +0800 [thread overview]
Message-ID: <Zt7nSz9oUJiPiFrx@swlinux02> (raw)
In-Reply-To: <20240819101704.1612317-5-chiawei_wang@aspeedtech.com>
On Mon, Aug 19, 2024 at 06:17:00PM +0800, Chia-Wei Wang wrote:
> AST2700 SoCs integrates a Ibex 32-bits RISC-V core as the boot MCU
> for the first stage bootloader execution, namely SPL.
>
> This patch implements the preliminary base to successfully run SPL
> on this RV32-based MCU to the console banner message.
>
> Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> ---
> arch/riscv/Kconfig | 5 +
> arch/riscv/cpu/ast2700/Kconfig | 6 +
> arch/riscv/cpu/ast2700/Makefile | 1 +
> arch/riscv/cpu/ast2700/cpu.c | 23 ++++
> arch/riscv/dts/Makefile | 1 +
> arch/riscv/dts/ast2700-ibex.dts | 22 ++++
> arch/riscv/dts/ast2700-u-boot.dtsi | 40 ++++++
> arch/riscv/dts/ast2700.dtsi | 76 ++++++++++++
> arch/riscv/include/asm/arch-ast2700/scu.h | 145 ++++++++++++++++++++++
> arch/riscv/include/asm/arch-ast2700/sli.h | 82 ++++++++++++
> board/aspeed/ibex_ast2700/Kconfig | 21 ++++
> board/aspeed/ibex_ast2700/MAINTAINERS | 7 ++
> board/aspeed/ibex_ast2700/Makefile | 2 +
> board/aspeed/ibex_ast2700/ibex_ast2700.c | 85 +++++++++++++
> board/aspeed/ibex_ast2700/sli.c | 72 +++++++++++
> configs/ibex-ast2700_defconfig | 92 ++++++++++++++
> include/configs/ibex_ast2700.h | 12 ++
> 17 files changed, 692 insertions(+)
> create mode 100644 arch/riscv/cpu/ast2700/Kconfig
> create mode 100644 arch/riscv/cpu/ast2700/Makefile
> create mode 100644 arch/riscv/cpu/ast2700/cpu.c
> create mode 100644 arch/riscv/dts/ast2700-ibex.dts
> create mode 100644 arch/riscv/dts/ast2700-u-boot.dtsi
> create mode 100644 arch/riscv/dts/ast2700.dtsi
> create mode 100644 arch/riscv/include/asm/arch-ast2700/scu.h
> create mode 100644 arch/riscv/include/asm/arch-ast2700/sli.h
> create mode 100644 board/aspeed/ibex_ast2700/Kconfig
> create mode 100644 board/aspeed/ibex_ast2700/MAINTAINERS
> create mode 100644 board/aspeed/ibex_ast2700/Makefile
> create mode 100644 board/aspeed/ibex_ast2700/ibex_ast2700.c
> create mode 100644 board/aspeed/ibex_ast2700/sli.c
> create mode 100644 configs/ibex-ast2700_defconfig
> create mode 100644 include/configs/ibex_ast2700.h
Hi Chia-Wei,
Could you also provide proper document under ${u-boot}/doc/board regarding
how to build and run U-boot-SPL on AST2700?
Other than that, LGTM.
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
Best regards,
Leo
next prev parent reply other threads:[~2024-09-09 12:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 10:16 [PATCH 0/8] riscv: Add AST2700 platform support Chia-Wei Wang
2024-08-19 10:16 ` [PATCH 1/8] riscv: Make A ISA extension selectable Chia-Wei Wang
2024-09-09 8:17 ` Leo Liang
2024-08-19 10:16 ` [PATCH 2/8] riscv: Make stack size shift configurable Chia-Wei Wang
2024-09-09 8:18 ` Leo Liang
2024-08-19 10:16 ` [PATCH 3/8] riscv: u-boot-spl.lds: Remove _image_binary_end alignment Chia-Wei Wang
2024-09-09 12:20 ` Leo Liang
2024-08-19 10:17 ` [PATCH 4/8] riscv: Add AST2700 SoC initial platform support Chia-Wei Wang
2024-09-09 12:17 ` Leo Liang [this message]
2024-09-10 2:32 ` ChiaWei Wang
2024-08-19 10:17 ` [PATCH 5/8] timer: Add AST2700 IBEX timer support Chia-Wei Wang
2024-09-09 12:21 ` Leo Liang
2024-08-19 10:17 ` [PATCH 6/8] board: ibex_ast2700: Add FMC header support Chia-Wei Wang
2024-09-09 12:22 ` Leo Liang
2024-08-19 10:17 ` [PATCH 7/8] ram: ast2700: Add DRAM controller initialization Chia-Wei Wang
2024-09-09 12:22 ` Leo Liang
2024-08-19 10:17 ` [PATCH 8/8] configs: ibex-ast2700: Enable DRAM and timer driver Chia-Wei Wang
2024-09-09 12:23 ` Leo Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zt7nSz9oUJiPiFrx@swlinux02 \
--to=ycliang@andestech.com \
--cc=chiawei_wang@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=rick@andestech.com \
--cc=ryan_chen@aspeedtech.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox