Re: [PATCH 3/4] rockchip: rk3399-rockpro64: Disable bootstage instrumentation config

[Paul Kocialkowski <paulk@sys-base.io>]

[-- Attachment #1: Type: text/plain, Size: 2308 bytes --]

Hi,

Le Mon 30 Sep 24, 12:52, Simon Glass a écrit :
> On Mon, 30 Sept 2024 at 03:03, Peter Robinson <pbrobinson@gmail.com> wrote:
> > On Thu, 26 Sept 2024 at 19:32, Paul Kocialkowski <paulk@sys-base.io> wrote:
> > > The boot timing and reporting (bootstage) infrastructure is useful for
> > > performance analysis and debug but adds overhead and console noise when
> > > using the device normally. Remove it from the device config.
> > >
> > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > Reviewed-by: Peter Robinson <pbrobinson@gmail.com>
> >
> > This makes sense, for those that want this information will know how
> > to build it for testing.
> 
> Can you just disable the report? There should be no need to disable
> bootstage itself.

I see bootstage as a debug/development feature, so I don't really see why it
should be enabled on default builds.

Besides the console noise aspect, my intent here is also to tidy up this config.

Cheers,

Paul

> Regards,
> Simon
> 
> 
> > > ---
> > >  configs/rockpro64-rk3399_defconfig | 3 ---
> > >  1 file changed, 3 deletions(-)
> > >
> > > diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig
> > > index fc0804a0b80d..095d27ffaa04 100644
> > > --- a/configs/rockpro64-rk3399_defconfig
> > > +++ b/configs/rockpro64-rk3399_defconfig
> > > @@ -19,8 +19,6 @@ CONFIG_SPL_SPI=y
> > >  CONFIG_SYS_LOAD_ADDR=0x800800
> > >  CONFIG_PCI=y
> > >  CONFIG_DEBUG_UART=y
> > > -CONFIG_BOOTSTAGE=y
> > > -CONFIG_BOOTSTAGE_REPORT=y
> > >  CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rockpro64.dtb"
> > >  CONFIG_DISPLAY_BOARDINFO_LATE=y
> > >  CONFIG_SPL_MAX_SIZE=0x40000
> > > @@ -38,7 +36,6 @@ CONFIG_CMD_POWEROFF=y
> > >  CONFIG_CMD_USB=y
> > >  # CONFIG_CMD_SETEXPR is not set
> > >  CONFIG_CMD_TIME=y
> > > -CONFIG_CMD_BOOTSTAGE=y
> > >  CONFIG_SPL_OF_CONTROL=y
> > >  CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
> > >  CONFIG_ENV_IS_IN_SPI_FLASH=y
> > > --
> > > 2.46.2
> > >

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Specialist in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]