Re: [PATCH v1 1/4] x86: cpu: Use default print_cpuinfo() for all

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Tue, Oct 08, 2024 at 07:56:43PM -0600, Simon Glass wrote:
> On Sat, 5 Oct 2024 at 13:14, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Most of the copies of the print_cpuinfo() call the default method.
> > Remove all of those in order to have only the default one when
> > no `cpu` command is compiled.
> >
> > This also helps avoiding compiler warning, e.g.:
> >
> >   arch/x86/cpu/tangier/tangier.c:23:5: warning: no previous prototype for ‘print_cpuinfo’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  arch/x86/cpu/broadwell/cpu.c                 | 12 ------------
> >  arch/x86/cpu/coreboot/coreboot.c             |  5 -----
> >  arch/x86/cpu/cpu.c                           |  6 +++++-
> >  arch/x86/cpu/efi/app.c                       |  5 -----
> >  arch/x86/cpu/efi/payload.c                   |  5 -----
> >  arch/x86/cpu/ivybridge/cpu.c                 | 14 --------------
> >  arch/x86/cpu/qemu/qemu.c                     |  6 ------
> >  arch/x86/cpu/quark/quark.c                   |  6 ------
> >  arch/x86/cpu/slimbootloader/slimbootloader.c |  5 -----
> >  arch/x86/cpu/tangier/tangier.c               |  5 -----
> >  arch/x86/cpu/x86_64/misc.c                   |  5 -----
> >  arch/x86/include/asm/u-boot-x86.h            |  1 -
> >  arch/x86/lib/fsp/fsp_common.c                |  6 ------
> >  13 files changed, 5 insertions(+), 76 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>

Thanks!

> BTW, this function is deprecated...since with CONFIG_CPU it is shown
> by the CPU driver.

Is it docemented somewhere? In any case this patch I think is good on
its own as it drastically reduces the possible churn in the future.

-- 
With Best Regards,
Andy Shevchenko