public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>,
	u-boot@lists.denx.de, Bin Meng <bmeng.cn@gmail.com>
Subject: Re: [PATCH v1 3/4] x86: cpu: Add a few prototypes to the header file
Date: Wed, 9 Oct 2024 17:07:59 +0300	[thread overview]
Message-ID: <ZwaOPy9NTV4PmY5E@black.fi.intel.com> (raw)
In-Reply-To: <CAFLszTjff52keqouqR3WK=cM=PX+EiTJQqz+YWBbDe3dSTYY8g@mail.gmail.com>

On Tue, Oct 08, 2024 at 07:55:33PM -0600, Simon Glass wrote:
> On Sat, 5 Oct 2024 at 13:14, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > The compiler is not happy to have no prototypes for the functions that
> > are not defined static. Add them. This helps avoiding the compiler warnings:
> >
> >   arch/x86/cpu/cpu.c:197:13: warning: no previous prototype for ‘board_final_init’ [-Wmissing-prototypes]
> >   arch/x86/cpu/cpu.c:205:13: warning: no previous prototype for ‘board_final_cleanup’ [-Wmissing-prototypes]
> >   arch/x86/cpu/cpu.c:307:5: warning: no previous prototype for ‘reserve_arch’ [-Wmissing-prototypes]
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>

Thanks!

> OK, but could you add proper comments for these?

Any proposed texts for them? The comments were out of scope of my patch,
but I may add anything that is provided as a template.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-10-09 14:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-05 19:11 [PATCH v1 0/4] x86: Clean up and fix to avoid compiler warnings Andy Shevchenko
2024-10-05 19:11 ` [PATCH v1 1/4] x86: cpu: Use default print_cpuinfo() for all Andy Shevchenko
2024-10-09  1:56   ` Simon Glass
2024-10-09 14:06     ` Andy Shevchenko
2024-10-09 21:14       ` Simon Glass
2024-10-17 23:11         ` Simon Glass
2024-10-05 19:11 ` [PATCH v1 2/4] x86: cpu: Mark a few functions static Andy Shevchenko
2024-10-09  1:56   ` Simon Glass
2024-10-17 23:11     ` Simon Glass
2024-10-05 19:11 ` [PATCH v1 3/4] x86: cpu: Add a few prototypes to the header file Andy Shevchenko
2024-10-09  1:55   ` Simon Glass
2024-10-09 14:07     ` Andy Shevchenko [this message]
2024-10-09 21:14       ` Simon Glass
2024-10-17 23:11         ` Simon Glass
2024-10-18 11:43           ` Andy Shevchenko
2024-10-18 14:55             ` Simon Glass
2024-10-18 15:56               ` Andy Shevchenko
2024-10-05 19:12 ` [PATCH v1 4/4] x86: cpu: Add missing header inclusion Andy Shevchenko
2024-10-09  1:55   ` Simon Glass
2024-10-17 23:11     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZwaOPy9NTV4PmY5E@black.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=bmeng.cn@gmail.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox