From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>,
u-boot@lists.denx.de, Bin Meng <bmeng.cn@gmail.com>
Subject: Re: [PATCH v1 3/4] x86: cpu: Add a few prototypes to the header file
Date: Fri, 18 Oct 2024 18:56:27 +0300 [thread overview]
Message-ID: <ZxKFK96o5PGRCWSR@smile.fi.intel.com> (raw)
In-Reply-To: <CAFLszTjPNafOL+Qmbq8JCjJ0tY7GiC-1TycVZZxy+6aY4pZLNQ@mail.gmail.com>
On Fri, Oct 18, 2024 at 08:55:00AM -0600, Simon Glass wrote:
> On Fri, 18 Oct 2024 at 05:43, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, Oct 17, 2024 at 04:11:48PM -0700, Simon Glass wrote:
> > > On Wed, 9 Oct 2024 at 08:08, Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
...
> > > /*
> > > * Implement a weak default function for boards that need to do some final init
> > > * before the system is ready.
> > > */
> > > __weak void board_final_init(void)
> > > {
> > > }
> > >
> > > /*
> > > * Implement a weak default function for boards that need to do some final
> > > * processing before booting the OS.
> > > */
> > > __weak void board_final_cleanup(void)
> > > {
> > > }
> > >
> > > Applied to u-boot-dm, thanks!
> >
> > Thanks, but what does it mean to me? Should I send an update to add the comments?
>
> Yes, please. I'm just tidying up some x86 patches while Bin is away.
Patch has just been sent.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-18 15:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 19:11 [PATCH v1 0/4] x86: Clean up and fix to avoid compiler warnings Andy Shevchenko
2024-10-05 19:11 ` [PATCH v1 1/4] x86: cpu: Use default print_cpuinfo() for all Andy Shevchenko
2024-10-09 1:56 ` Simon Glass
2024-10-09 14:06 ` Andy Shevchenko
2024-10-09 21:14 ` Simon Glass
2024-10-17 23:11 ` Simon Glass
2024-10-05 19:11 ` [PATCH v1 2/4] x86: cpu: Mark a few functions static Andy Shevchenko
2024-10-09 1:56 ` Simon Glass
2024-10-17 23:11 ` Simon Glass
2024-10-05 19:11 ` [PATCH v1 3/4] x86: cpu: Add a few prototypes to the header file Andy Shevchenko
2024-10-09 1:55 ` Simon Glass
2024-10-09 14:07 ` Andy Shevchenko
2024-10-09 21:14 ` Simon Glass
2024-10-17 23:11 ` Simon Glass
2024-10-18 11:43 ` Andy Shevchenko
2024-10-18 14:55 ` Simon Glass
2024-10-18 15:56 ` Andy Shevchenko [this message]
2024-10-05 19:12 ` [PATCH v1 4/4] x86: cpu: Add missing header inclusion Andy Shevchenko
2024-10-09 1:55 ` Simon Glass
2024-10-17 23:11 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxKFK96o5PGRCWSR@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bmeng.cn@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox