public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Simon Glass <sjg@chromium.org>
Cc: jerome.forissier@linaro.org, raymond.mao@linaro.org,
	xypron.glpk@gmx.de, Tom Rini <trini@konsulko.com>,
	Joe Hershberger <joe.hershberger@ni.com>,
	Ramon Fried <rfried.dev@gmail.com>,
	Mattijs Korpershoek <mkorpershoek@baylibre.com>,
	AKASHI Takahiro <akashi.tkhro@gmail.com>,
	Jonathan Humphreys <j-humphreys@ti.com>,
	Wei Ming Chen <jj251510319013@gmail.com>,
	Masahisa Kojima <kojima.masahisa@socionext.com>,
	Caleb Connolly <caleb.connolly@linaro.org>,
	Javier Tia <javier.tia@linaro.org>,
	u-boot@lists.denx.de
Subject: Re: [PATCH 4/6] net: lwip: Enable https:// support for wget
Date: Thu, 24 Oct 2024 20:02:43 +0300	[thread overview]
Message-ID: <Zxp9s_tc_rQRqUHX@hera> (raw)
In-Reply-To: <CAC_iWjJrUtTnymNK-GpNOp+Qjd2H2z+pPP8caK7KW4DzCVpP5Q@mail.gmail.com>

Hi Simon,

[...]

> > >         memset(&conn, 0, sizeof(conn));
> > > +#if defined CONFIG_WGET_HTTPS
> >
> > if (IS_ENABLED(CONFIG_WGET_HTTPS))
> >
>
> Unfortunately, I don't think we can use that here. If
> CONFIG_WGET_HTTPS is not enabled LWIP_ALTCP will not be defined, and
> the altcp_allocator_t field will be missing from the struct leading to
> a compilation error

I forgot to update this in v2 [0].
I'll send a v3 regardless and will change this to
#if IS_ENABLED(CONFIG_MBEDTLS_LIB_TLS)

which is a better fit anyway

[...]

Cheers
/Ilias

  reply	other threads:[~2024-10-24 17:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 14:21 [PATCH 0/6] Enable https for wget Ilias Apalodimas
2024-10-18 14:21 ` [PATCH 1/6] mbedtls: Enable TLS 1.2 support Ilias Apalodimas
2024-10-18 14:38   ` Raymond Mao
2024-10-18 14:54     ` Ilias Apalodimas
2024-10-18 15:26       ` Raymond Mao
2024-10-21 10:31         ` Ilias Apalodimas
2024-10-21 14:03           ` Raymond Mao
2024-10-18 14:21 ` [PATCH 2/6] net: lwip: Update lwIP for mbedTLS > 3.0 support and enable https Ilias Apalodimas
2024-10-18 14:21 ` [PATCH 3/6] net: lwip: Add Support Server Name Indication support Ilias Apalodimas
2024-10-18 14:21 ` [PATCH 4/6] net: lwip: Enable https:// support for wget Ilias Apalodimas
2024-10-19 11:50   ` Simon Glass
2024-10-21 11:00     ` Ilias Apalodimas
2024-10-24 17:02       ` Ilias Apalodimas [this message]
2024-10-18 14:21 ` [PATCH 5/6] configs: Enable htts for wget on qemu arm64 Ilias Apalodimas
2024-10-19 11:50   ` Simon Glass
2024-10-21 21:39   ` Peter Robinson
2024-10-22 11:53   ` Jérôme Forissier
2024-10-18 14:22 ` [PATCH 6/6] doc: uefi: Describe UEFI HTTPs boot Ilias Apalodimas
2024-10-19 11:50   ` Simon Glass
2024-10-18 15:02 ` [PATCH 0/6] Enable https for wget Simon Glass
2024-10-18 15:05   ` Ilias Apalodimas
2024-10-18 17:20     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zxp9s_tc_rQRqUHX@hera \
    --to=ilias.apalodimas@linaro.org \
    --cc=akashi.tkhro@gmail.com \
    --cc=caleb.connolly@linaro.org \
    --cc=j-humphreys@ti.com \
    --cc=javier.tia@linaro.org \
    --cc=jerome.forissier@linaro.org \
    --cc=jj251510319013@gmail.com \
    --cc=joe.hershberger@ni.com \
    --cc=kojima.masahisa@socionext.com \
    --cc=mkorpershoek@baylibre.com \
    --cc=raymond.mao@linaro.org \
    --cc=rfried.dev@gmail.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox