From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Igor Opaniuk <igor.opaniuk@gmail.com>,
u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH] cmd/eficonfig: capitalize 'enter description'
Date: Sat, 26 Oct 2024 10:24:42 +0300 [thread overview]
Message-ID: <ZxyZOk35IJDGUKM8@hades> (raw)
In-Reply-To: <20241025211505.361296-1-heinrich.schuchardt@canonical.com>
On Fri, Oct 25, 2024 at 11:15:05PM +0200, Heinrich Schuchardt wrote:
> To conform with other messages capitalize the first letter:
> %s/enter description/Enter description/g
>
> Adjust the unit tests accordingly.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> cmd/eficonfig.c | 2 +-
> test/py/tests/test_eficonfig/test_eficonfig.py | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c
> index bea09e4ecc7..029180250f0 100644
> --- a/cmd/eficonfig.c
> +++ b/cmd/eficonfig.c
> @@ -963,7 +963,7 @@ static efi_status_t eficonfig_boot_add_enter_description(void *data)
> return handle_user_input(bo->description, EFICONFIG_DESCRIPTION_MAX, 22,
> "\n ** Edit Description **\n"
> "\n"
> - " enter description: ");
> + " Enter description: ");
> }
>
> /**
> diff --git a/test/py/tests/test_eficonfig/test_eficonfig.py b/test/py/tests/test_eficonfig/test_eficonfig.py
> index 1d8e033f75d..d98de5249df 100644
> --- a/test/py/tests/test_eficonfig/test_eficonfig.py
> +++ b/test/py/tests/test_eficonfig/test_eficonfig.py
> @@ -117,7 +117,7 @@ def test_efi_eficonfig(u_boot_console, efi_eficonfig_data):
> press_up_down_enter_and_wait(0, 0, True, 'Quit')
>
> # Press the enter key to select 'Description:' entry, then enter Description
> - press_up_down_enter_and_wait(0, 0, True, 'enter description:')
> + press_up_down_enter_and_wait(0, 0, True, 'Enter description:')
> # Send Description user input, press ENTER key to complete
> send_user_input_and_wait('test 1', 'Quit')
>
> @@ -166,7 +166,7 @@ def test_efi_eficonfig(u_boot_console, efi_eficonfig_data):
> press_up_down_enter_and_wait(0, 0, True, 'Quit')
>
> # Press the enter key to select 'Description:' entry, then enter Description
> - press_up_down_enter_and_wait(0, 0, True, 'enter description:')
> + press_up_down_enter_and_wait(0, 0, True, 'Enter description:')
> # Send Description user input, press ENTER key to complete
> send_user_input_and_wait('test 2', 'Quit')
>
> @@ -278,7 +278,7 @@ def test_efi_eficonfig(u_boot_console, efi_eficonfig_data):
> u_boot_console.p.expect([i])
>
> # Press the enter key to select 'Description:' entry, then enter Description
> - press_up_down_enter_and_wait(0, 0, True, 'enter description:')
> + press_up_down_enter_and_wait(0, 0, True, 'Enter description:')
> # Send Description user input, press ENTER key to complete
> send_user_input_and_wait('test 3', 'Quit')
>
> --
> 2.45.2
>
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
prev parent reply other threads:[~2024-10-26 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 21:15 [PATCH] cmd/eficonfig: capitalize 'enter description' Heinrich Schuchardt
2024-10-26 7:24 ` Ilias Apalodimas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxyZOk35IJDGUKM8@hades \
--to=ilias.apalodimas@linaro.org \
--cc=heinrich.schuchardt@canonical.com \
--cc=igor.opaniuk@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox