[PATCH] cmd/eficonfig: capitalize 'enter description'

[PATCH] cmd/eficonfig: capitalize 'enter description'

[Heinrich Schuchardt]

To conform with other messages capitalize the first letter:
%s/enter description/Enter description/g

Adjust the unit tests accordingly.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 cmd/eficonfig.c                                | 2 +-
 test/py/tests/test_eficonfig/test_eficonfig.py | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c
index bea09e4ecc7..029180250f0 100644
--- a/cmd/eficonfig.c
+++ b/cmd/eficonfig.c
@@ -963,7 +963,7 @@ static efi_status_t eficonfig_boot_add_enter_description(void *data)
 	return handle_user_input(bo->description, EFICONFIG_DESCRIPTION_MAX, 22,
 				 "\n  ** Edit Description **\n"
 				 "\n"
-				 "  enter description: ");
+				 "  Enter description: ");
 }
 
 /**
diff --git a/test/py/tests/test_eficonfig/test_eficonfig.py b/test/py/tests/test_eficonfig/test_eficonfig.py
index 1d8e033f75d..d98de5249df 100644
--- a/test/py/tests/test_eficonfig/test_eficonfig.py
+++ b/test/py/tests/test_eficonfig/test_eficonfig.py
@@ -117,7 +117,7 @@ def test_efi_eficonfig(u_boot_console, efi_eficonfig_data):
         press_up_down_enter_and_wait(0, 0, True, 'Quit')
 
         # Press the enter key to select 'Description:' entry, then enter Description
-        press_up_down_enter_and_wait(0, 0, True, 'enter description:')
+        press_up_down_enter_and_wait(0, 0, True, 'Enter description:')
         # Send Description user input, press ENTER key to complete
         send_user_input_and_wait('test 1', 'Quit')
 
@@ -166,7 +166,7 @@ def test_efi_eficonfig(u_boot_console, efi_eficonfig_data):
         press_up_down_enter_and_wait(0, 0, True, 'Quit')
 
         # Press the enter key to select 'Description:' entry, then enter Description
-        press_up_down_enter_and_wait(0, 0, True, 'enter description:')
+        press_up_down_enter_and_wait(0, 0, True, 'Enter description:')
         # Send Description user input, press ENTER key to complete
         send_user_input_and_wait('test 2', 'Quit')
 
@@ -278,7 +278,7 @@ def test_efi_eficonfig(u_boot_console, efi_eficonfig_data):
             u_boot_console.p.expect([i])
 
         # Press the enter key to select 'Description:' entry, then enter Description
-        press_up_down_enter_and_wait(0, 0, True, 'enter description:')
+        press_up_down_enter_and_wait(0, 0, True, 'Enter description:')
         # Send Description user input, press ENTER key to complete
         send_user_input_and_wait('test 3', 'Quit')
 
-- 
2.45.2

Re: [PATCH] cmd/eficonfig: capitalize 'enter description'

[Ilias Apalodimas]

On Fri, Oct 25, 2024 at 11:15:05PM +0200, Heinrich Schuchardt wrote:
> To conform with other messages capitalize the first letter:
> %s/enter description/Enter description/g
> 
> Adjust the unit tests accordingly.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  cmd/eficonfig.c                                | 2 +-
>  test/py/tests/test_eficonfig/test_eficonfig.py | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c
> index bea09e4ecc7..029180250f0 100644
> --- a/cmd/eficonfig.c
> +++ b/cmd/eficonfig.c
> @@ -963,7 +963,7 @@ static efi_status_t eficonfig_boot_add_enter_description(void *data)
>  	return handle_user_input(bo->description, EFICONFIG_DESCRIPTION_MAX, 22,
>  				 "\n  ** Edit Description **\n"
>  				 "\n"
> -				 "  enter description: ");
> +				 "  Enter description: ");
>  }
>  
>  /**
> diff --git a/test/py/tests/test_eficonfig/test_eficonfig.py b/test/py/tests/test_eficonfig/test_eficonfig.py
> index 1d8e033f75d..d98de5249df 100644
> --- a/test/py/tests/test_eficonfig/test_eficonfig.py
> +++ b/test/py/tests/test_eficonfig/test_eficonfig.py
> @@ -117,7 +117,7 @@ def test_efi_eficonfig(u_boot_console, efi_eficonfig_data):
>          press_up_down_enter_and_wait(0, 0, True, 'Quit')
>  
>          # Press the enter key to select 'Description:' entry, then enter Description
> -        press_up_down_enter_and_wait(0, 0, True, 'enter description:')
> +        press_up_down_enter_and_wait(0, 0, True, 'Enter description:')
>          # Send Description user input, press ENTER key to complete
>          send_user_input_and_wait('test 1', 'Quit')
>  
> @@ -166,7 +166,7 @@ def test_efi_eficonfig(u_boot_console, efi_eficonfig_data):
>          press_up_down_enter_and_wait(0, 0, True, 'Quit')
>  
>          # Press the enter key to select 'Description:' entry, then enter Description
> -        press_up_down_enter_and_wait(0, 0, True, 'enter description:')
> +        press_up_down_enter_and_wait(0, 0, True, 'Enter description:')
>          # Send Description user input, press ENTER key to complete
>          send_user_input_and_wait('test 2', 'Quit')
>  
> @@ -278,7 +278,7 @@ def test_efi_eficonfig(u_boot_console, efi_eficonfig_data):
>              u_boot_console.p.expect([i])
>  
>          # Press the enter key to select 'Description:' entry, then enter Description
> -        press_up_down_enter_and_wait(0, 0, True, 'enter description:')
> +        press_up_down_enter_and_wait(0, 0, True, 'Enter description:')
>          # Send Description user input, press ENTER key to complete
>          send_user_input_and_wait('test 3', 'Quit')
>  
> -- 
> 2.45.2
> 
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>