From: Janne Grunau <j@jannau.net>
To: Sughosh Ganu <sughosh.ganu@linaro.org>
Cc: Mark Kettenis <kettenis@openbsd.org>,
Tom Rini <trini@konsulko.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH 0/2] Fix device removal order for Apple dart iommu
Date: Fri, 1 Nov 2024 09:09:26 +0100 [thread overview]
Message-ID: <ZySMtvihaERwmqMN@robin> (raw)
In-Reply-To: <CADg8p96v8ocR=8yRLmC7j0CFcCUCFfQv6P9YaST_i-ewUP4RdA@mail.gmail.com>
On Fri, Nov 01, 2024 at 11:52:26AM +0530, Sughosh Ganu wrote:
> On Fri, 1 Nov 2024 at 04:37, Janne Grunau <j@jannau.net> wrote:
> >
> > Starting with v2024.10 dev_iommu_dma_unmap calls during device removal
> > trigger a NULL pointer dereference since the the iommu device is removed
> > before its user. The sparsely used DM_FLAG_VITAL flag is intended for
> > this dependency.
> > This series adds it to the Apple dart iommu driver and implements the
> > two phased device removal to the EFI loader.
>
> Is this also the cause of the crash that you were observing with the
> RFC patches that I had posted earlier?
It shouldn't as I applied those patches on top of this. This is a
separate issue already present in v2024.10. I discovered the LMB changes
while investigating this.
Janne
next prev parent reply other threads:[~2024-11-01 8:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 22:48 [PATCH 0/2] Fix device removal order for Apple dart iommu Janne Grunau
2024-10-31 22:48 ` [PATCH 1/2] iommu: apple: Mark device with DM_FLAG_VITAL Janne Grunau
2024-11-01 7:12 ` Heinrich Schuchardt
2024-11-01 7:12 ` Heinrich Schuchardt
2024-11-01 20:28 ` Mark Kettenis
2024-10-31 22:48 ` [PATCH 2/2] efi_loader: remove non vital devices first Janne Grunau
2024-11-01 20:29 ` Mark Kettenis
2024-11-13 12:47 ` Heinrich Schuchardt
2024-11-13 14:39 ` Simon Glass
2024-11-13 15:17 ` Heinrich Schuchardt
2024-11-13 16:03 ` Simon Glass
2024-11-13 18:45 ` Heinrich Schuchardt
2024-11-14 3:53 ` Simon Glass
2024-11-14 14:26 ` Tom Rini
2024-11-14 17:52 ` Simon Glass
2024-11-13 15:57 ` Mark Kettenis
2024-11-01 6:22 ` [PATCH 0/2] Fix device removal order for Apple dart iommu Sughosh Ganu
2024-11-01 8:09 ` Janne Grunau [this message]
2024-11-21 7:39 ` Janne Grunau
2024-11-22 1:30 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZySMtvihaERwmqMN@robin \
--to=j@jannau.net \
--cc=ilias.apalodimas@linaro.org \
--cc=kettenis@openbsd.org \
--cc=sughosh.ganu@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox