From: Paul Kocialkowski <paulk@sys-base.io>
To: Quentin Schulz <foss+uboot@0leil.net>
Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Kever Yang <kever.yang@rock-chips.com>,
Klaus Goger <klaus.goger@cherry.de>,
u-boot@lists.denx.de, Paul Kocialkowski <contact@paulk.fr>,
Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [PATCH next 3/5] rockchip: tpl: allow to call board/SoC-specific code before DRAM init
Date: Tue, 5 Nov 2024 19:37:28 +0100 [thread overview]
Message-ID: <Zypl6BpHOHBZbH7s@collins> (raw)
In-Reply-To: <20241105-rk3399-sysreset-gpio-tpl-v1-3-12caff07a4e4@cherry.de>
[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]
Hi,
Le Tue 05 Nov 24, 16:36, Quentin Schulz a écrit :
> From: Quentin Schulz <quentin.schulz@cherry.de>
>
> This defines a weak tpl_board_init function that can be used for running
> board/SoC-specific code before the DRAM init happens, similarly to
> spl_board_init() for SPL.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Paul Kocialkowski <paulk@sys-base.io>
Cheers,
Paul
> ---
> arch/arm/mach-rockchip/tpl.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/mach-rockchip/tpl.c b/arch/arm/mach-rockchip/tpl.c
> index bbb9329e725af79ea4c4049aa7890a4a143e7df5..6b880f19f84e57e7bc0c93b16b188bc56267827e 100644
> --- a/arch/arm/mach-rockchip/tpl.c
> +++ b/arch/arm/mach-rockchip/tpl.c
> @@ -21,6 +21,10 @@
> #include <timestamp.h>
> #endif
>
> +__weak void tpl_board_init(void)
> +{
> +}
> +
> void board_init_f(ulong dummy)
> {
> struct udevice *dev;
> @@ -54,6 +58,8 @@ void board_init_f(ulong dummy)
> if (IS_ENABLED(CONFIG_SYS_ARCH_TIMER))
> timer_init();
>
> + tpl_board_init();
> +
> ret = uclass_get_device(UCLASS_RAM, 0, &dev);
> if (ret) {
> printf("DRAM init failed: %d\n", ret);
>
> --
> 2.47.0
>
--
Paul Kocialkowski,
Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/
Specialist in multimedia, graphics and embedded hardware support with Linux.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-11-05 18:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 15:36 [PATCH next 0/5] rockchip: rk3399: allow to trigger sysreset in TPL Quentin Schulz
2024-11-05 15:36 ` [PATCH next 1/5] pinctrl: rockchip: allow to build for TPL Quentin Schulz
2024-11-05 18:34 ` Paul Kocialkowski
2024-11-05 15:36 ` [PATCH next 2/5] rockchip: rk3399: merge CRU check within rk3399_force_power_on_reset Quentin Schulz
2024-11-05 18:36 ` Paul Kocialkowski
2024-11-05 15:36 ` [PATCH next 3/5] rockchip: tpl: allow to call board/SoC-specific code before DRAM init Quentin Schulz
2024-11-05 18:37 ` Paul Kocialkowski [this message]
2024-11-05 15:36 ` [PATCH next 4/5] rockchip: rk3399: allow to handle sysreset-gpio in TPL Quentin Schulz
2024-11-05 18:40 ` Paul Kocialkowski
2024-11-05 18:44 ` Paul Kocialkowski
2024-11-05 15:36 ` [PATCH next 5/5] rockchip: configs: puma-rk3399: do the system reset " Quentin Schulz
2024-11-05 18:40 ` Paul Kocialkowski
2024-11-05 18:45 ` [PATCH next 0/5] rockchip: rk3399: allow to trigger sysreset " Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zypl6BpHOHBZbH7s@collins \
--to=paulk@sys-base.io \
--cc=contact@paulk.fr \
--cc=foss+uboot@0leil.net \
--cc=kever.yang@rock-chips.com \
--cc=klaus.goger@cherry.de \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox