Re: [PATCH next 1/5] pinctrl: rockchip: allow to build for TPL

[Paul Kocialkowski <paulk@sys-base.io>]

[-- Attachment #1: Type: text/plain, Size: 2296 bytes --]

Hi,

Le Tue 05 Nov 24, 16:36, Quentin Schulz a écrit :
> From: Quentin Schulz <quentin.schulz@cherry.de>
> 
> A later commit will make use of the pinctrl driver in TPL so let's add
> the ability to build the Rockchip pinctrl driver in TPL.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>

Reviewed-by: Paul Kocialkowski <paulk@sys-base.io>

Just a nit below in case you need to respin.

Cheers,

Paul

> ---
>  drivers/pinctrl/Kconfig          | 8 ++++++++
>  drivers/pinctrl/rockchip/Kconfig | 7 +++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index a1d53cfbdbed5ef1030fff04715e1436f167554b..cff7c3ef45b1c7c29017a4512d4970bce4bac26b 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -127,6 +127,14 @@ config SPL_PINCTRL_GENERIC
>  	  This option is an SPL-variant of the PINCTRL_GENERIC option.
>  	  See the help of PINCTRL_GENERIC for details.
>  
> +config TPL_PINCTRL_GENERIC
> +	bool "Support generic pin controllers in TPL"
> +	depends on TPL_PINCTRL_FULL
> +	default y
> +	help
> +	  This option is an TPL-variant of the PINCTRL_GENERIC option.
> +	  See the help of PINCTRL_GENERIC for details.

Typo: "a TPL-variant".

>  config SPL_PINMUX
>  	bool "Support pin multiplexing controllers in SPL"
>  	depends on SPL_PINCTRL_GENERIC
> diff --git a/drivers/pinctrl/rockchip/Kconfig b/drivers/pinctrl/rockchip/Kconfig
> index dc4ba34ae5d581be76786fd05d679d26397fd467..6ad6b189715cee20f0e570d93b9b871e5acb99c3 100644
> --- a/drivers/pinctrl/rockchip/Kconfig
> +++ b/drivers/pinctrl/rockchip/Kconfig
> @@ -14,4 +14,11 @@ config SPL_PINCTRL_ROCKCHIP
>  	help
>  	  This option is an SPL-variant of the PINCTRL_ROCKCHIP option.
>  
> +config TPL_PINCTRL_ROCKCHIP
> +	bool "Support Rockchip pin controllers in TPL"
> +	depends on ARCH_ROCKCHIP && TPL_PINCTRL_GENERIC
> +	default y
> +	help
> +	  This option is an TPL-variant of the PINCTRL_ROCKCHIP option.

Ditto.

> +
>  endif
> 
> -- 
> 2.47.0
> 

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Specialist in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]